[Bug bootstrap/108711] New: [13 Regression] ICE in get_equiv, at lra-constraints.cc:534

[Bug bootstrap/108711] New: [13 Regression] ICE in get_equiv, at lra-constraints.cc:534

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108711

            Bug ID: 108711
           Summary: [13 Regression] ICE in get_equiv, at
                    lra-constraints.cc:534
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: bootstrap
          Assignee: unassigned at gcc dot gnu.org
          Reporter: marxin at gcc dot gnu.org
                CC: vmakarov at gcc dot gnu.org
  Target Milestone: ---
              Host: i586-linux-gnu
            Target: i586-linux-gnu

I see the bootstrap is broken due to:

[ 1890s]
/home/abuild/rpmbuild/BUILD/gcc-13.0.1+git5733/obj-i586-suse-linux/./prev-gcc/xg++
-B/home/abuild/rpmbuild/BUILD/gcc-13.0.1+git5733/obj-i586-suse-linux/./prev-gcc/
-B/usr/i586-suse-linux/bin/ -nostdinc++
-B/home/abuild/rpmbuild/BUILD/gcc-13.0.1+git5733/obj-i586-suse-linux/prev-i586-suse-linux/libstdc++-v3/src/.libs
-B/home/abuild/rpmbuild/BUILD/gcc-13.0.1+git5733/obj-i586-suse-linux/prev-i586-suse-linux/libstdc++-v3/libsupc++/.libs

-I/home/abuild/rpmbuild/BUILD/gcc-13.0.1+git5733/obj-i586-suse-linux/prev-i586-suse-linux/libstdc++-v3/include/i586-suse-linux

-I/home/abuild/rpmbuild/BUILD/gcc-13.0.1+git5733/obj-i586-suse-linux/prev-i586-suse-linux/libstdc++-v3/include
 -I/home/abuild/rpmbuild/BUILD/gcc-13.0.1+git5733/libstdc++-v3/libsupc++
-L/home/abuild/rpmbuild/BUILD/gcc-13.0.1+git5733/obj-i586-suse-linux/prev-i586-suse-linux/libstdc++-v3/src/.libs
-L/home/abuild/rpmbuild/BUILD/gcc-13.0.1+git5733/obj-i586-suse-linux/prev-i586-suse-linux/libstdc++-v3/libsupc++/.libs
 -fno-PIE -c  -DIN_GCC_FRONTEND -fomit-frame-pointer -O2 -U_FORTIFY_SOURCE
-D_FORTIFY_SOURCE=3 -funwind-tables -fasynchronous-unwind-tables
-fstack-clash-protection -Werror=return-type -g -U_FORTIFY_SOURCE -DIN_GCC
-fPIC    -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall
-Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute
-Wconditionally-supported -Woverloaded-virtual -pedantic -Wno-long-long
-Wno-variadic-macros -Wno-overlength-strings   -DHAVE_CONFIG_H -I. -Igo
-I../../gcc -I../../gcc/go -I../../gcc/../include 
-I../../gcc/../libcpp/include -I../../gcc/../libcody 
-I../../gcc/../libdecnumber -I../../gcc/../libdecnumber/bid -I../libdecnumber
-I../../gcc/../libbacktrace   -o go/expressions.o -MT go/expressions.o -MMD -MP
-MF go/.deps/expressions.TPo -I ../../gcc/go -I ../../gcc/go/gofrontend
../../gcc/go/gofrontend/expressions.cc
[ 1890s] during RTL pass: reload
[ 1890s] ../../gcc/go/gofrontend/expressions.cc: In member function 'virtual
Expression* Composite_literal_expression::do_copy()':
[ 1890s] ../../gcc/go/gofrontend/expressions.cc:17358:1: internal compiler
error: in get_equiv, at lra-constraints.cc:534
[ 1890s] 17358 | }
[ 1890s]       | ^
[ 1890s] 0x84f9177 _start

I'm reducing that right now.

[Bug rtl-optimization/108711] [13 Regression] ICE in get_equiv, at lra-constraints.cc:534

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108711

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.0
           Keywords|                            |build, ra
           Severity|normal                      |blocker
          Component|bootstrap                   |rtl-optimization
             Target|i586-linux-gnu              |i586-linux-gnu
                   |                            |x86_64-linux-gnu
               Host|i586-linux-gnu              |

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Also reported by me:
https://gcc.gnu.org/pipermail/gcc-patches/2023-February/611549.html

[Bug rtl-optimization/108711] [13 Regression] ICE in get_equiv, at lra-constraints.cc:534

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108711

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
I see it too, on i686-linux as
during RTL pass: reload
../../gcc/d/dmd/expression.d: In function ‘syntaxCopy’:
../../gcc/d/dmd/expression.d:4237:5: internal compiler error: in get_equiv, at
lra-constraints.cc:534
 4237 |     }
      |     ^
/home/jakub/src/gcc/obj11/./prev-gcc/gdc
-B/home/jakub/src/gcc/obj11/./prev-gcc/ -B/usr/local/i686-pc-linux-gnu/bin/ -O2
-g -B/home/jakub/src/gcc/obj11/prev-i686-pc-linux-gnu/libphob
0x8fdfe94 get_equiv
        ../../gcc/lra-constraints.cc:534
0x8fef557 lra_constraints(bool)
        ../../gcc/lra-constraints.cc:5052
0x8fd58a3 lra(_IO_FILE*)
        ../../gcc/lra.cc:2375
0x8f7398b do_reload
        ../../gcc/ira.cc:5955
0x8f73e40 execute
        ../../gcc/ira.cc:6141
and on x86_64 when building 32-bit libgo:
during RTL pass: reload
../../../../libgo/go/reflect/type.go: In function ‘reflect.rtype.Method’:
../../../../libgo/go/reflect/type.go:604:1: internal compiler error: in
get_equiv, at lra-constraints.cc:534
0x7ed869 get_equiv
        ../../gcc/lra-constraints.cc:534
0x127ef32 lra_constraints(bool)
        ../../gcc/lra-constraints.cc:5052
0x1269b04 lra(_IO_FILE*)
        ../../gcc/lra.cc:2375
0x121b7e9 do_reload
        ../../gcc/ira.cc:5955
0x121b7e9 execute
        ../../gcc/ira.cc:6141
Please submit a full bug report, with preprocessed source (by using
-freport-bug).

Reverting r13-5730-gf661c0bb6371f355966a67b5ce71398e80792948 makes it work
again.

[Bug rtl-optimization/108711] [13 Regression] ICE in get_equiv, at lra-constraints.cc:534

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108711

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2023-02-08
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW

--- Comment #3 from Martin Liška <marxin at gcc dot gnu.org> ---
Reduced test-case:

$ cat goexpr.ii

struct Expression_list {
  Expression_list *copy();
} vals_;
struct Parser_expression {
  Parser_expression();
};
struct Composite_literal_expression : Parser_expression {
  Composite_literal_expression(bool has_keys, Expression_list *,
                               bool all_are_names)
      : has_keys_(has_keys), all_are_names_(all_are_names) {}
  void do_copy();
  bool has_keys_;
  bool all_are_names_;
};
void Composite_literal_expression::do_copy() {
  new Composite_literal_expression(has_keys_, vals_.copy(), all_are_names_);
}

$
/home/abuild/rpmbuild/BUILD/gcc-13.0.1+git5733/obj-i586-suse-linux/./prev-gcc/xg++
-B/home/abuild/rpmbuild/BUILD/gcc-13.0.1+git5733/obj-i586-suse-linux/./prev-gcc/
-fno-exceptions   -O2 goexpr.ii -c
during RTL pass: reload
goexpr.ii: In member function 'void Composite_literal_expression::do_copy()':
goexpr.ii:17:1: internal compiler error: in get_equiv, at
lra-constraints.cc:534
   17 | }
      | ^
0x84f9177 _start
        ../sysdeps/i386/start.S:111
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://bugs.opensuse.org/> for instructions.

[Bug rtl-optimization/108711] [13 Regression] ICE in get_equiv, at lra-constraints.cc:534

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108711

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Patch was reverted by r13-5738-gad2bd0ad0413c2448fee0d4a

[Bug rtl-optimization/108711] [13 Regression] ICE in get_equiv, at lra-constraints.cc:534

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108711

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Vladimir Makarov <vmakarov@gcc.gnu.org>:

https://gcc.gnu.org/g:10827a92f1a8c3207b327515f77845b34c1d9512

commit r13-5761-g10827a92f1a8c3207b327515f77845b34c1d9512
Author: Vladimir N. Makarov <vmakarov@redhat.com>
Date:   Thu Feb 9 15:18:48 2023 -0500

    RA: Implement reuse of equivalent memory for caller saves optimization (2nd
version)

    The test pr103541.c shows opportunity to reuse memory with constant address
for
    caller saves optimization for constant or pure function call.  The patch
    implements the memory reuse.

            PR rtl-optimization/103541
            PR rtl-optimization/108711

    gcc/ChangeLog:

            * ira.h (struct ira_reg_equiv_s): Add new field caller_save_p.
            * ira.cc (validate_equiv_mem): Check memref address variance.
            (no_equiv): Clear caller_save_p flag.
            (update_equiv_regs): Define caller save equivalence for
            valid_combine.
            (setup_reg_equiv): Clear defined_p flag for caller save
equivalence.
            * lra-constraints.cc (lra_copy_reg_equiv): Add new arg
            call_save_p.  Use caller save equivalence depending on the arg.
            (split_reg): Adjust the call.

    gcc/testsuite/ChangeLog:

            * gcc.target/i386/pr103541.c: New.
            * g++.target/i386/pr108711.C: New.