[Bug target/108722] New: gcc.dg/analyzer/file-CWE-1341-example.c fails on power 9 BE

[Bug target/108722] New: gcc.dg/analyzer/file-CWE-1341-example.c fails on power 9 BE

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108722

            Bug ID: 108722
           Summary: gcc.dg/analyzer/file-CWE-1341-example.c fails on power
                    9 BE
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: seurer at gcc dot gnu.org
  Target Milestone: ---

g:9ada45967b4cf543aa47091e99a760d0718013cc, r13-4218-g9ada45967b4cf5

This is only failing on a power 9 BE machine.  It fails since the test case's
introduction.

make  -k check-gcc RUNTESTFLAGS="--target_board=unix'{-m32}'
analyzer.exp=gcc.dg/analyzer/file-CWE-1341-example.c"
FAIL: gcc.dg/analyzer/file-CWE-1341-example.c (test for excess errors)
# of expected passes            3
# of unexpected failures        1

spawn -ignore SIGHUP /home/seurer/gcc/git/build/gcc-test/gcc/xgcc
-B/home/seurer/gcc/git/build/gcc-test/gcc/
/home/seurer/gcc/git/gcc-test/gcc/testsuite/gcc.dg/analyzer/file-CWE-1341-example.c
-m32 -fdiagnostics-plain-output -fanalyzer -Wanalyzer-too-complex
-fanalyzer-call-summaries -S -o file-CWE-1341-example.s
/home/seurer/gcc/git/gcc-test/gcc/testsuite/gcc.dg/analyzer/file-CWE-1341-example.c:
In function 'example_1':
/home/seurer/gcc/git/gcc-test/gcc/testsuite/gcc.dg/analyzer/file-CWE-1341-example.c:38:16:
warning: double 'fclose' of FILE 'f' [CWE-1341] [-Wanalyzer-double-fclose]
/home/seurer/gcc/git/gcc-test/gcc/testsuite/gcc.dg/analyzer/file-CWE-1341-example.c:29:13:
note: (1) opened here
/home/seurer/gcc/git/gcc-test/gcc/testsuite/gcc.dg/analyzer/file-CWE-1341-example.c:30:6:
note: (2) assuming 'f' is non-NULL
/home/seurer/gcc/git/gcc-test/gcc/testsuite/gcc.dg/analyzer/file-CWE-1341-example.c:30:6:
note: (3) following 'true' branch (when 'f' is non-NULL)...
/home/seurer/gcc/git/gcc-test/gcc/testsuite/gcc.dg/analyzer/file-CWE-1341-example.c:32:12:
note: (4) ...to here
/home/seurer/gcc/git/gcc-test/gcc/testsuite/gcc.dg/analyzer/file-CWE-1341-example.c:35:16:
note: (5) first 'fclose' here
/home/seurer/gcc/git/gcc-test/gcc/testsuite/gcc.dg/analyzer/file-CWE-1341-example.c:38:16:
note: (6) second 'fclose' here; first 'fclose' was at (5)
/home/seurer/gcc/git/gcc-test/gcc/testsuite/gcc.dg/analyzer/file-CWE-1341-example.c:38:16:
warning: double-'fclose' of 'f' [CWE-415] [-Wanalyzer-double-free]
/home/seurer/gcc/git/gcc-test/gcc/testsuite/gcc.dg/analyzer/file-CWE-1341-example.c:29:13:
note: (1) allocated here
/home/seurer/gcc/git/gcc-test/gcc/testsuite/gcc.dg/analyzer/file-CWE-1341-example.c:30:6:
note: (2) assuming 'f' is non-NULL
/home/seurer/gcc/git/gcc-test/gcc/testsuite/gcc.dg/analyzer/file-CWE-1341-example.c:30:6:
note: (3) following 'true' branch (when 'f' is non-NULL)...
/home/seurer/gcc/git/gcc-test/gcc/testsuite/gcc.dg/analyzer/file-CWE-1341-example.c:32:12:
note: (4) ...to here
/home/seurer/gcc/git/gcc-test/gcc/testsuite/gcc.dg/analyzer/file-CWE-1341-example.c:35:16:
note: (5) first 'fclose' here
/home/seurer/gcc/git/gcc-test/gcc/testsuite/gcc.dg/analyzer/file-CWE-1341-example.c:38:16:
note: (6) second 'fclose' here; first 'fclose' was at (5)
PASS: gcc.dg/analyzer/file-CWE-1341-example.c  (test for warnings, line 29)
PASS: gcc.dg/analyzer/file-CWE-1341-example.c  (test for warnings, line 35)
PASS: gcc.dg/analyzer/file-CWE-1341-example.c  (test for warnings, line 38)
Executing on host: /home/seurer/gcc/git/build/gcc-test/gcc/xgcc
-B/home/seurer/gcc/git/build/gcc-test/gcc/  exceptions_enabled4193687.cc  -m32 
 -fdiagnostics-plain-output  -S -o exceptions_enabled4193687.s    (timeout =
300)
spawn -ignore SIGHUP /home/seurer/gcc/git/build/gcc-test/gcc/xgcc
-B/home/seurer/gcc/git/build/gcc-test/gcc/ exceptions_enabled4193687.cc -m32
-fdiagnostics-plain-output -S -o exceptions_enabled4193687.s
FAIL: gcc.dg/analyzer/file-CWE-1341-example.c (test for excess errors)
Excess errors:
/home/seurer/gcc/git/gcc-test/gcc/testsuite/gcc.dg/analyzer/file-CWE-1341-example.c:38:16:
warning: double-'fclose' of 'f' [CWE-415] [-Wanalyzer-double-free]

[Bug target/108722] gcc.dg/analyzer/file-CWE-1341-example.c fails on power 9 BE

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108722

John David Anglin <danglin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
             Target|powerpc64-linux-gnu         |powerpc64-linux-gnu
                   |                            |hppa-linux-gnu
   Last reconfirmed|                            |2023-04-02
               Host|powerpc64-linux-gnu         |powerpc64-linux-gnu
                   |                            |hppa-linux-gnu
                 CC|                            |danglin at gcc dot gnu.org
              Build|powerpc64-linux-gnu         |powerpc64-linux-gnu
                   |                            |hppa-linux-gnu

[Bug target/108722] gcc.dg/analyzer/file-CWE-1341-example.c fails on power 9 BE

[guojiufu at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108722

Jiu Fu Guo <guojiufu at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |guojiufu at gcc dot gnu.org

--- Comment #1 from Jiu Fu Guo <guojiufu at gcc dot gnu.org> ---
The case only checkes [CWE-1341] which is `double-fclose`.
While on the BE machine, besides [CWE-1341], a message of [CWE-415] is also
reported. Because attribute `malloc` is attached on fopen:
```
# 258 "/usr/include/stdio.h" 3 4
extern FILE *fopen (const char *__restrict __filename,
      const char *__restrict __modes)                                           
  __attribute__ ((__malloc__)) __attribute__ ((__malloc__ (fclose, 1))) ;

or say: __attribute_malloc__ __attr_dealloc_fclose __wur;
```

Because this case is not intended to test CWE-415, it may be ok to add
-Wno-analyzer-double-free for this case.

[Bug analyzer/108722] gcc.dg/analyzer/file-CWE-1341-example.c fails on power 9 BE

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108722

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |testsuite-fail
           Assignee|unassigned at gcc dot gnu.org      |dmalcolm at gcc dot gnu.org
             Target|powerpc64-linux-gnu         |powerpc64-linux-gnu
                   |hppa-linux-gnu              |hppa-linux-gnu
                   |                            |x86_64-unknown-linux-gnu
                 CC|                            |dmalcolm at gcc dot gnu.org
          Component|target                      |analyzer

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
also seeing this on x86_64, it's dependent on the glibc version (I have 2.37).

The bug is in the analyzer I think, it implements FILE open/close tracking
so it should suppress itself from diagnosing malloc/free diagnostic on FILEs.

[Bug analyzer/108722] gcc.dg/analyzer/file-CWE-1341-example.c fails on power 9 BE

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108722

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jiu Fu Guo <guojiufu@gcc.gnu.org>:

https://gcc.gnu.org/g:edc6659c97c4a747123b1150b372dc8e7a83a824

commit r13-7176-gedc6659c97c4a747123b1150b372dc8e7a83a824
Author: Jiufu Guo <guojiufu@linux.ibm.com>
Date:   Wed Apr 12 10:12:58 2023 +0800

    testsuite: filter out warning noise for CWE-1341 test

    The case file-CWE-1341-example.c checkes [CWE-1341](`double-fclose`).
    While on some systems, besides [CWE-1341], a message of [CWE-415] is
    also reported. On those systems, attribute `malloc` may be attached on
    fopen:
    ```
    # 258 "/usr/include/stdio.h" 3 4
    extern FILE *fopen (const char *__restrict __filename,
          const char *__restrict __modes)
      __attribute__ ((__malloc__)) __attribute__ ((__malloc__ (fclose, 1))) ;

    or say: __attribute_malloc__ __attr_dealloc_fclose __wur;
    ```

    See (PR analyzer/108722) for future fix in the analyzer.
    This workaround patch adds -Wno-analyzer-double-free to this case.

    gcc/testsuite/ChangeLog:

            PR analyzer/108722
            * gcc.dg/analyzer/file-CWE-1341-example.c: Update.

[Bug analyzer/108722] [13/14 Regression] gcc.dg/analyzer/file-CWE-1341-example.c fails on power 9 BE

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108722

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.3

[Bug analyzer/108722] [13/14 Regression] gcc.dg/analyzer/file-CWE-1341-example.c fails on power 9 BE

[law at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108722

Jeffrey A. Law <law at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2
                 CC|                            |law at gcc dot gnu.org

[Bug analyzer/108722] [13/14 Regression] gcc.dg/analyzer/file-CWE-1341-example.c fails on power 9 BE

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108722

seurer at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from seurer at gcc dot gnu.org ---
Fixed now.  Thanks!