[Bug middle-end/108754] New: [13 Regression] multiple testsuite errors with r13-5761-g10827a92f1a8c3

[Bug middle-end/108754] New: [13 Regression] multiple testsuite errors with r13-5761-g10827a92f1a8c3

[hp at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108754

            Bug ID: 108754
           Summary: [13 Regression] multiple testsuite errors with
                    r13-5761-g10827a92f1a8c3
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
          Assignee: unassigned at gcc dot gnu.org
          Reporter: hp at gcc dot gnu.org
                CC: vmakarov at gcc dot gnu.org
  Target Milestone: ---
              Host: x86_64-pc-linux-gnu
            Target: cris-elf

I've pin-pointed r13-5761-g10827a92f1a8c3 as the cause of these test-suite
regressions for cris-elf:

gcc.sum gcc.c-torture/execute/960215-1.c
gcc.sum gcc.c-torture/execute/ieee/mzero3.c
gcc.sum gcc.c-torture/execute/pr69447.c
gcc.sum gcc.c-torture/execute/regstack-1.c
gfortran.sum gfortran.dg/bind-c-contiguous-3.f90
gfortran.sum gfortran.dg/c-interop/cf-out-descriptor-4.f90
gfortran.sum gfortran.dg/class_allocate_22.f90
gfortran.sum gfortran.dg/func_derived_1.f90
gfortran.sum gfortran.dg/inline_matmul_14.f90
gfortran.sum gfortran.dg/ptr_func_assign_1.f08

IOW:
gcc:
Running /x/gcc/testsuite/gcc.c-torture/execute/execute.exp ...
FAIL: gcc.c-torture/execute/960215-1.c   -O2  execution test
FAIL: gcc.c-torture/execute/960215-1.c   -O3 -g  execution test
FAIL: gcc.c-torture/execute/960215-1.c   -Os  execution test
FAIL: gcc.c-torture/execute/960215-1.c   -O2 -flto -fno-use-linker-plugin
-flto-partition=none  execution test
FAIL: gcc.c-torture/execute/pr69447.c   -O2  execution test
FAIL: gcc.c-torture/execute/pr69447.c   -O3 -g  execution test
FAIL: gcc.c-torture/execute/pr69447.c   -Os  execution test
FAIL: gcc.c-torture/execute/pr69447.c   -O2 -flto -fno-use-linker-plugin
-flto-partition=none  execution test
FAIL: gcc.c-torture/execute/regstack-1.c   -O2  execution test
FAIL: gcc.c-torture/execute/regstack-1.c   -O3 -g  execution test
FAIL: gcc.c-torture/execute/regstack-1.c   -Os  execution test
FAIL: gcc.c-torture/execute/regstack-1.c   -O2 -flto -fno-use-linker-plugin
-flto-partition=none  execution test
Running /x/gcc/testsuite/gcc.c-torture/execute/ieee/ieee.exp ...
FAIL: gcc.c-torture/execute/ieee/mzero3.c execution,  -O2
FAIL: gcc.c-torture/execute/ieee/mzero3.c execution,  -O3 -g
FAIL: gcc.c-torture/execute/ieee/mzero3.c execution,  -Os
FAIL: gcc.c-torture/execute/ieee/mzero3.c execution,  -O2 -flto
-fno-use-linker-plugin -flto-partition=none

gfortran:
Running /x/gcc/testsuite/gfortran.dg/c-interop/c-interop.exp ...
[...]
FAIL: gfortran.dg/c-interop/cf-out-descriptor-4.f90   -O3 -g  execution test
[...]
Running /x/gcc/testsuite/gfortran.dg/dg.exp ...
[...]
FAIL: gfortran.dg/bind-c-contiguous-3.f90   -O1  execution test
FAIL: gfortran.dg/bind-c-contiguous-3.f90   -O2  execution test
FAIL: gfortran.dg/bind-c-contiguous-3.f90   -O3 -fomit-frame-pointer
-funroll-loops -fpeel-loops -ftracer -finline-functions  execution test
FAIL: gfortran.dg/bind-c-contiguous-3.f90   -O3 -g  execution test
FAIL: gfortran.dg/bind-c-contiguous-3.f90   -Os  execution test
[...]
FAIL: gfortran.dg/class_allocate_22.f90   -O2  execution test
FAIL: gfortran.dg/class_allocate_22.f90   -O3 -g  execution test
[...]
FAIL: gfortran.dg/func_derived_1.f90   -O3 -fomit-frame-pointer -funroll-loops
-fpeel-loops -ftracer -finline-functions  execution test
FAIL: gfortran.dg/func_derived_1.f90   -O3 -g  execution test
FAIL: gfortran.dg/inline_matmul_14.f90   -O3 -fomit-frame-pointer
-funroll-loops -fpeel-loops -ftracer -finline-functions  execution test
[...]
FAIL: gfortran.dg/ptr_func_assign_1.f08   -O1  execution test
FAIL: gfortran.dg/ptr_func_assign_1.f08   -Os  execution test

Being execution errors, gcc.log doesn't tell anything besides abort being
called.

Judging from the patch, the failing tests and the tested target-list (in
particular, their difference to cris-elf), maybe libcalls aren't handled
properly.  The previously pushed (and reverted) version caused the same (or a
very similar set of) regressions.  Will look closer.

[Bug middle-end/108754] [13 Regression] multiple testsuite errors with r13-5761-g10827a92f1a8c3

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108754

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.0
           Keywords|                            |ra, wrong-code
           Severity|normal                      |critical

[Bug middle-end/108754] [13 Regression] multiple testsuite errors with r13-5761-g10827a92f1a8c3

[vmakarov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108754

--- Comment #1 from Vladimir Makarov <vmakarov at gcc dot gnu.org> ---
I think the problem is that cris uses the old reload pass.  Could you check the
following patch:

diff --git a/gcc/ira.cc b/gcc/ira.cc
index d0b6ea062e8..9f9af808f63 100644
--- a/gcc/ira.cc
+++ b/gcc/ira.cc
@@ -3773,7 +3773,7 @@ update_equiv_regs (void)
                    {
                      note = set_unique_reg_note (insn, REG_EQUIV,
replacement);
                    }
-                 else
+                 else if (ira_use_lra_p)
                    {
                      /* We still can use this equivalence for caller save
                         optimization in LRA.  Mark this.  */

[Bug middle-end/108754] [13 Regression] multiple testsuite errors with r13-5761-g10827a92f1a8c3

[hp at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108754

--- Comment #2 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
Diff of .s for mzero3 at -O2:
--- /x/0/gccobj/gcc/testsuite/gcc/mzero3.x2-mzero3.s    2023-02-10
17:57:56.786279467 +0100
+++ /x/1/gccobj/gcc/testsuite/gcc/mzero3.x2-mzero3.s    2023-02-10
17:57:06.083925076 +0100
@@ -94,10 +94,8 @@ _main:
        move.d $r8,$r12
        move.d $r7,$r13
        jsr $r4
-       move.d [_zerof],$r9
-       move.d $r9,[$sp+36]
        move.d _negf,$r2
-       move.d $r9,$r10
+       move.d [$sp+36],$r10
        Jsr $r2
        move.d [_nzerof],$r3
        move.d _expectf,$r0

That's the setup to call negf (zerof), and the diff is that zerof is saved to
stack before the patch, but with the patch, the uninitialized contents of that
slot is used.

[Bug middle-end/108754] [13 Regression] multiple testsuite errors with r13-5761-g10827a92f1a8c3

[hp at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108754

--- Comment #3 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
(In reply to Vladimir Makarov from comment #1)
> I think the problem is that cris uses the old reload pass.  Could you check
> the following patch:

Will do, thanks!

[Bug middle-end/108754] [13 Regression] multiple testsuite errors with r13-5761-g10827a92f1a8c3

[vmakarov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108754

--- Comment #4 from Vladimir Makarov <vmakarov at gcc dot gnu.org> ---
(In reply to Hans-Peter Nilsson from comment #3)
> (In reply to Vladimir Makarov from comment #1)
> > I think the problem is that cris uses the old reload pass.  Could you check
> > the following patch:
> 
> Will do, thanks!

OK.  I'll submit the patch then.

[Bug middle-end/108754] [13 Regression] multiple testsuite errors with r13-5761-g10827a92f1a8c3

[hp at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108754

--- Comment #5 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
Created attachment 54450
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54450&action=edit
suggested change

Here's the exact patch I'm testing, on top of the mentioned commit.
(In submittable format!)

[Bug middle-end/108754] [13 Regression] multiple testsuite errors with r13-5761-g10827a92f1a8c3

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108754

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Vladimir Makarov <vmakarov@gcc.gnu.org>:

https://gcc.gnu.org/g:7757567358a84c3774cb972350bd7ea299daaa8d

commit r13-5809-g7757567358a84c3774cb972350bd7ea299daaa8d
Author: Vladimir N. Makarov <vmakarov@redhat.com>
Date:   Fri Feb 10 12:17:07 2023 -0500

    RA: Use caller save equivalent memory only for LRA

    Recently I submitted a patch to reuse memory with constant address for
    caller saves optimization for constant or pure function call.  It
    seems to work only for targets using LRA instead of the old reload
    pass.  So the patch switches off this optimization when the old reload
    pass is used.

            PR middle-end/108754

    gcc/ChangeLog:

            * ira.cc (update_equiv_regs): Set up ira_reg_equiv for
            valid_combine only when ira_use_lra_p is true.

[Bug middle-end/108754] [13 Regression] multiple testsuite errors with r13-5761-g10827a92f1a8c3

[hp at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108754

--- Comment #7 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
Oh, already committed.  Still testing, FWIW.

[Bug middle-end/108754] [13 Regression] multiple testsuite errors with r13-5761-g10827a92f1a8c3

[hp at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108754

Hans-Peter Nilsson <hp at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
My test-run with the suggested change on top of r13-5761-g10827a92f1a8c3 came
out clean (all regressions resolved, no new ones added) so I'll close this
issue.  Thanks for promptly taking care of this!

[Bug middle-end/108754] [13 Regression] multiple testsuite errors with r13-5761-g10827a92f1a8c3

[vmakarov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108754

--- Comment #9 from Vladimir Makarov <vmakarov at gcc dot gnu.org> ---
(In reply to Hans-Peter Nilsson from comment #8)
> My test-run with the suggested change on top of r13-5761-g10827a92f1a8c3
> came out clean (all regressions resolved, no new ones added) so I'll close
> this issue.  Thanks for promptly taking care of this!

Thank you for your help.  And sorry for the inconveniences because of my patch.
It is hard to do changes in RA as they might affect different targets in some
unexpected way.