[Bug c/108791] New: [12/13 Regression] ICE: verify_gimple failed

[Bug c/108791] New: [12/13 Regression] ICE: verify_gimple failed

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108791

            Bug ID: 108791
           Summary: [12/13 Regression] ICE: verify_gimple failed
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Started between 20210801 and 20210808, at -Ofast :
(gcc configured with --enable-checking=yes)


$ cat z1.c
double f (int *a(), int b, double *c, double *d)
{
  double s = 0;
  for (int *i = a; i < b; ++i, ++c)
    s += *c * d[*i];
  return s;
}


$ gcc-13-20230212 -c z1.c -Ofast
z1.c: In function 'f':
z1.c:4:17: warning: initialization of 'int *' from incompatible pointer type
'int * (*)()' [-Wincompatible-pointer-types]
    4 |   for (int *i = a; i < b; ++i, ++c)
      |                 ^
z1.c:4:22: warning: comparison between pointer and integer
    4 |   for (int *i = a; i < b; ++i, ++c)
      |                      ^
z1.c:1:8: error: type mismatch in 'addr_expr'
    1 | double f (int *a(), int b, double *c, double *d)
      |        ^
int * (*<T389>) ()

vector(4) int

_111 = &MEM <vector(4) int> [(int *)a_14(D) + ivtmp.31_54 * 1];
during GIMPLE pass: forwprop
z1.c:1:8: internal compiler error: verify_gimple failed
0xf85e0e verify_gimple_in_cfg(function*, bool, bool)
        ../../gcc/tree-cfg.cc:5648
0xe1df43 execute_function_todo
        ../../gcc/passes.cc:2091
0xe1e9c2 execute_todo
        ../../gcc/passes.cc:2145

[Bug c/108791] [12/13 Regression] ICE: verify_gimple failed

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108791

G. Steinmetz <gscfq@t-online.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|                            |x86_64-pc-linux-gnu

--- Comment #1 from G. Steinmetz <gscfq@t-online.de> ---

This variant gives an ICE for both -Ofast and -O3 : 

$ cat z2.c
int f (int *a(), int b, int *c, int *d)
{
  int s = 0;
  for (int *i = a; i < b; ++i, ++c)
    s += *c * d[*i];
  return s;
}

[Bug tree-optimization/108791] [12/13 Regression] ICE: verify_gimple failed

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108791

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|c                           |tree-optimization
   Target Milestone|---                         |12.3
                 CC|                            |pinskia at gcc dot gnu.org
           Keywords|                            |ice-on-valid-code

[Bug tree-optimization/108791] [12/13 Regression] ICE: verify_gimple failed

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108791

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2023-02-14
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
      Known to work|                            |11.3.0
      Known to fail|                            |12.1.0

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
  vect__2.16_79 = MEM <vector(4) int> [(int *)a_12(D) + ivtmp.31_52 * 1];
  vect__3.17_80 = [vec_unpack_lo_expr] vect__2.16_79;
  vect__3.17_81 = [vec_unpack_hi_expr] vect__2.16_79;
  _83 = BIT_FIELD_REF <vect__3.17_80, 64, 0>;


into:

  _109 = &MEM <vector(4) int> [(int *)a_12(D) + ivtmp.31_52 * 1];
  _11 = BIT_FIELD_REF <MEM <vector(4) int> [(int *)_109], 32, 32>;

[Bug tree-optimization/108791] [12/13 Regression] ICE: verify_gimple failed

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108791

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
I will have a look.

[Bug tree-optimization/108791] [12/13 Regression] ICE: verify_gimple failed

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108791

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
Created attachment 54467
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54467&action=edit
patch

[Bug tree-optimization/108791] [12/13 Regression] ICE: verify_gimple failed

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108791

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:441c466fd4d8b9afd99f585f7c4bfade911c4652

commit r13-6073-g441c466fd4d8b9afd99f585f7c4bfade911c4652
Author: Richard Biener <rguenther@suse.de>
Date:   Wed Feb 15 14:00:21 2023 +0100

    tree-optimization/108791 - checking ICE with sloppy ADDR_EXPR

    The following fixes a checking ICE by choosing a more appropriate
    type for an ADDR_EXPR built by forwprop.

            PR tree-optimization/108791
            * tree-ssa-forwprop.cc (optimize_vector_load): Build
            the ADDR_EXPR of a TARGET_MEM_REF using a more meaningful
            type.

            * gcc.dg/torture/pr108791.c: New testcase.

[Bug tree-optimization/108791] [12 Regression] ICE: verify_gimple failed

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108791

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |13.0
           Priority|P3                          |P2
            Summary|[12/13 Regression] ICE:     |[12 Regression] ICE:
                   |verify_gimple failed        |verify_gimple failed
           Keywords|                            |ice-checking
             Status|ASSIGNED                    |NEW

--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed on trunk sofar.

[Bug tree-optimization/108791] [12 Regression] ICE: verify_gimple failed since r12-2733-g31855ba6b16cd138

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108791

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[12 Regression] ICE:        |[12 Regression] ICE:
                   |verify_gimple failed        |verify_gimple failed since
                   |                            |r12-2733-g31855ba6b16cd138
                 CC|                            |marxin at gcc dot gnu.org

--- Comment #7 from Martin Liška <marxin at gcc dot gnu.org> ---
Btw. started with r12-2733-g31855ba6b16cd138.

[Bug tree-optimization/108791] [12 Regression] ICE: verify_gimple failed since r12-2733-g31855ba6b16cd138

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108791

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Richard Biener
<rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:fcf27816635186acce77dd9b6d756d5c93fd92ef

commit r12-9481-gfcf27816635186acce77dd9b6d756d5c93fd92ef
Author: Richard Biener <rguenther@suse.de>
Date:   Wed Feb 15 14:00:21 2023 +0100

    tree-optimization/108791 - checking ICE with sloppy ADDR_EXPR

    The following fixes a checking ICE by choosing a more appropriate
    type for an ADDR_EXPR built by forwprop.

            PR tree-optimization/108791
            * tree-ssa-forwprop.cc (optimize_vector_load): Build
            the ADDR_EXPR of a TARGET_MEM_REF using a more meaningful
            type.

            * gcc.dg/torture/pr108791.c: New testcase.

    (cherry picked from commit 441c466fd4d8b9afd99f585f7c4bfade911c4652)

[Bug tree-optimization/108791] [12 Regression] ICE: verify_gimple failed since r12-2733-g31855ba6b16cd138

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108791

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
      Known to fail|                            |12.2.0
         Resolution|---                         |FIXED

--- Comment #9 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.