[Bug c++/108793] New: [12/13 Regression] ICE: verify_gimple failed

[Bug c++/108793] New: [12/13 Regression] ICE: verify_gimple failed

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108793

            Bug ID: 108793
           Summary: [12/13 Regression] ICE: verify_gimple failed
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Started between 20210822 and 20210905, at -O3 or -Ofast :
(gcc configured with --enable-checking=yes)


$ cat z1.cc
typedef void (*p)();
extern "C" p a, b;
int f () {
  int n = 0;
  for (p* i = &a; i > &b; i++) {
    n++;
  }
  return n;
}


$ gcc-13-20230212 -c z1.cc -Ofast
z1.cc: In function 'int f()':
z1.cc:3:5: error: non-trivial conversion in unary operation
    3 | int f () {
      |     ^
unsigned long
void (*p) (void) *
_3 = ~_1;
z1.cc:3:5: error: non-trivial conversion in unary operation
unsigned long
void (*p) (void) *
_24 = ~_23;
during GIMPLE pass: vect
z1.cc:3:5: internal compiler error: verify_gimple failed
0x12942be verify_gimple_in_cfg(function*, bool, bool)
        ../../gcc/tree-cfg.cc:5648
0x1135053 execute_function_todo
        ../../gcc/passes.cc:2091
0x1135ad2 execute_todo
        ../../gcc/passes.cc:2145

[Bug tree-optimization/108793] [12/13 Regression] ICE: verify_gimple failed

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108793

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2023-02-14
   Target Milestone|---                         |12.3

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Confirmed. Version without function pointers:
typedef int *p;
extern p a[], b[];
int f () {
  int n = 0;
  for (p* i = &a[0]; i > &b[0]; i++)
    n++;
  return n;
}

[Bug tree-optimization/108793] [12/13 Regression] ICE: verify_gimple failed

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108793

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
I will have a look.

[Bug tree-optimization/108793] [12/13 Regression] ICE: verify_gimple failed

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108793

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
It's caused by -1 -A -> ~A being invoked from number_of_iterations_until_wrap:

1497          num = fold_build2 (MINUS_EXPR, niter_type, wide_int_to_tree
(type, max),
1498                             iv1->base);
(gdb) p iv1->base
$3 = <addr_expr 0x7ffff6a77560>
(gdb) p niter_type
$4 = <integer_type 0x7ffff68e81f8>

while _until_wrap probably doesn't make much sense for pointer IVs, the above
has signed vs. unsigned type issues anyway.

[Bug tree-optimization/108793] [12/13 Regression] ICE: verify_gimple failed

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108793

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:a7e706df2280de4a42f68b6c44401e4348d3593c

commit r13-6258-ga7e706df2280de4a42f68b6c44401e4348d3593c
Author: Richard Biener <rguenther@suse.de>
Date:   Mon Feb 20 12:58:50 2023 +0100

    tree-optimization/108793 - niter compute type mismatch

    When computing the number of iterations until wrap types are mixed up,
    eventually leading to checking ICEs with a pointer bitwise inversion.
    The following uses niter_type for the calculation.

            PR tree-optimization/108793
            * tree-ssa-loop-niter.cc (number_of_iterations_until_wrap):
            Use convert operands to niter_type when computing num.

            * gcc.dg/torture/pr108793.c: New testcase.

[Bug tree-optimization/108793] [12 Regression] ICE: verify_gimple failed

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108793

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2
      Known to work|                            |13.0
            Summary|[12/13 Regression] ICE:     |[12 Regression] ICE:
                   |verify_gimple failed        |verify_gimple failed

[Bug tree-optimization/108793] [12 Regression] ICE: verify_gimple failed since r12-3136-g3673dcf6d6baeb67

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108793

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marxin at gcc dot gnu.org
            Summary|[12 Regression] ICE:        |[12 Regression] ICE:
                   |verify_gimple failed        |verify_gimple failed since
                   |                            |r12-3136-g3673dcf6d6baeb67

--- Comment #5 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r12-3136-g3673dcf6d6baeb67.

[Bug tree-optimization/108793] [12 Regression] ICE: verify_gimple failed since r12-3136-g3673dcf6d6baeb67

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108793

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Richard Biener
<rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:0a3642dde799ee2be9f2b60ec361191176390005

commit r12-9259-g0a3642dde799ee2be9f2b60ec361191176390005
Author: Richard Biener <rguenther@suse.de>
Date:   Mon Feb 20 12:58:50 2023 +0100

    tree-optimization/108793 - niter compute type mismatch

    When computing the number of iterations until wrap types are mixed up,
    eventually leading to checking ICEs with a pointer bitwise inversion.
    The following uses niter_type for the calculation.

            PR tree-optimization/108793
            * tree-ssa-loop-niter.cc (number_of_iterations_until_wrap):
            Use convert operands to niter_type when computing num.

            * gcc.dg/torture/pr108793.c: New testcase.

    (cherry picked from commit a7e706df2280de4a42f68b6c44401e4348d3593c)

[Bug tree-optimization/108793] [12 Regression] ICE: verify_gimple failed since r12-3136-g3673dcf6d6baeb67

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108793

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |12.2.1
      Known to fail|                            |12.2.0
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.