[Bug ada/108858] New: Assert_Failure at exp_ch6.adb:6499

[Bug ada/108858] New: Assert_Failure at exp_ch6.adb:6499

[Anashe-Lungisani at protonmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108858

            Bug ID: 108858
           Summary: Assert_Failure at exp_ch6.adb:6499
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: ada
          Assignee: unassigned at gcc dot gnu.org
          Reporter: Anashe-Lungisani at protonmail dot com
                CC: dkm at gcc dot gnu.org
  Target Milestone: ---

Created attachment 54492
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54492&action=edit
Code that reproduces the bug. Run through gnatchop first.

Ada code fails to build due to an assertion error:
Is_Build_In_Place_Function_Call (Exp) at exp_ch6.adb:6499 in GCC 13.0.1 (master
branch, commit 0263e9d5d84b4abbb53e73fbc8d72fd233764fc8). This does not happen
in GCC 12 with the same code, where it compiles fine.

To reproduce the bug, download the attached bug.ada into a separate directory,
and run the following two commands:

$ gnatchop bug.ada
$ gcc -c vss-strings.adb
+===========================GNAT BUG DETECTED==============================+
| 13.0.1 20230219 (experimental) (x86_64-linux-gnu) Assert_Failure
exp_ch6.adb:6499|
| Error detected at vss-strings.adb:227:7                                  |
| Compiling vss-strings.adb                                                |
| Please submit a bug report; see https://gcc.gnu.org/bugs/ .              |
| Use a subject line meaningful to you and us to track the bug.            |
| Include the entire contents of this bug box in the report.               |
| Include the exact command that you entered.                              |
| Also include sources listed below.                                       |
+==========================================================================+

The sources are all combined in the enclosed bug.ada.

=== INFORMATION ABOUT GCC: ===

$ gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=~/.local/libexec/gcc/x86_64-linux-gnu/13.0.1/lto-wrapper
Target: x86_64-linux-gnu
Configured with: ../gcc-src/configure --prefix=~/.local --host=x86_64-linux-gnu
--build=x86_64-linux-gnu --target=x86_64-linux-gnu --enable-languages=c,c++,ada
--disable-multilib
Thread model: posix
Supported LTO compression algorithms: zlib
gcc version 13.0.1 20230219 (experimental) (GCC)

=== SYSTEM INFORMATION: ===

Fedora 36, x86_64

[Bug ada/108858] Assert_Failure at exp_ch6.adb:6499

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108858

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ebotcazou at gcc dot gnu.org
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2023-02-22

--- Comment #1 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
I can reproduce.

[Bug ada/108858] [13 regression ] assertion failure at exp_ch6.adb:6499 on VSS library

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108858

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Assert_Failure at           |[13 regression ] assertion
                   |exp_ch6.adb:6499            |failure at exp_ch6.adb:6499
                   |                            |on VSS library
   Target Milestone|---                         |13.0

[Bug ada/108858] [13 regression ] assertion failure at exp_ch6.adb:6499 on VSS library

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108858

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Eric Botcazou <ebotcazou@gcc.gnu.org>:

https://gcc.gnu.org/g:14e5b65fd9bb6a848adda8ec939840c8f3ea6b40

commit r13-6505-g14e5b65fd9bb6a848adda8ec939840c8f3ea6b40
Author: Javier Miranda <miranda@adacore.com>
Date:   Mon Mar 6 11:43:28 2023 +0100

    Fix assertion failure on VSS library

    gcc/ada/
            PR ada/108858
            * sem_ch6.adb (Analyze_Subprogram_Body_Helper): For functions with
            separate spec, if their return type was visible through a limited-
            with context clause, their extra formals were not added when the
            spec was analyzed.  Now the full view must be available, and the
            extra formals can be created and Returns_By_Ref computed.

[Bug ada/108858] [13 regression ] assertion failure at exp_ch6.adb:6499 on VSS library

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108858

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
Thanks for reporting the problem.