[Bug target/108881] New: "__builtin_ia32_cvtne2ps2bf16_v16hi" compiled only with option -mavx512bf16 report ICE.

[Bug target/108881] New: "__builtin_ia32_cvtne2ps2bf16_v16hi" compiled only with option -mavx512bf16 report ICE.

[lin1.hu at intel dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108881

            Bug ID: 108881
           Summary: "__builtin_ia32_cvtne2ps2bf16_v16hi" compiled only
                    with option -mavx512bf16 report ICE.
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: lin1.hu at intel dot com
  Target Milestone: ---

When the compiler compiles "__builtin_ia32_cvtne2ps2bf16_v16hi" with option
-mavx512bf16, it reports ICE.

The detail can refer to https://godbolt.org/z/fEGavbGWz.

[Bug target/108881] "__builtin_ia32_cvtne2ps2bf16_v16hi" compiled only with option -mavx512bf16 report ICE.

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108881

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |crazylht at gmail dot com,
                   |                            |marxin at gcc dot gnu.org

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Test-case:

$ cat pr108881.i
typedef float __m256 __attribute__((__vector_size__(32)));
__attribute__((__vector_size__(16 * sizeof(short)))) short res2;
__m256 x3, x4;
avx512bf16_test() { res2 = __builtin_ia32_cvtne2ps2bf16_v16hi(x3, x4); }

It has changed since r13-3565-g6913cad2a38bc406:

gcc pr108881.c -c -mavx512bf16
pr108881.c: In function ‘avx512bf16_test’:
pr108881.c:5:18: warning: implicit declaration of function
‘__builtin_ia32_cvtne2ps2bf16_v16hi’; did you mean
‘__builtin_ia32_cvtne2ps2bf16_v16bf’? [-Wimplicit-function-declaration]
    5 |           res2 = __builtin_ia32_cvtne2ps2bf16_v16hi (x3, x4);
      |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                  __builtin_ia32_cvtne2ps2bf16_v16bf
pr108881.c:5:18: error: incompatible types when assigning to type ‘__m256bh’
from type ‘int’

[Bug target/108881] "__builtin_ia32_cvtne2ps2bf16_v16hi" compiled only with option -mavx512bf16 report ICE.

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108881

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
With -mavx512bf16
typedef float __m256 __attribute__((__vector_size__(32)));
typedef __bf16 __v16bf16 __attribute__((__vector_size__(32)));
__v16bf16 res2;
__m256 x3, x4;
void foo (void) { res2 = __builtin_ia32_cvtne2ps2bf16_v16bf (x3, x4); }
still ICEs on the trunk.

[Bug target/108881] "__builtin_ia32_cvtne2ps2bf16_v16hi" compiled only with option -mavx512bf16 report ICE.

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108881

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
     Ever confirmed|0                           |1
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org
   Last reconfirmed|                            |2023-02-23

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 54520
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54520&action=edit
gcc13-pr108881.patch

Untested fix.

[Bug target/108881] "__builtin_ia32_cvtne2ps2bf16_v16hi" compiled only with option -mavx512bf16 report ICE.

[crazylht at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108881

--- Comment #4 from Hongtao.liu <crazylht at gmail dot com> ---
(In reply to Jakub Jelinek from comment #3)
> Created attachment 54520 [details]
> gcc13-pr108881.patch
> 
> Untested fix.

Yes, patch LGTM.

[Bug target/108881] "__builtin_ia32_cvtne2ps2bf16_v16hi" compiled only with option -mavx512bf16 report ICE.

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108881

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:0ccfa3884f638816af0f5a3f0ee2695e0771ef6d

commit r13-6318-g0ccfa3884f638816af0f5a3f0ee2695e0771ef6d
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Fri Feb 24 10:12:44 2023 +0100

    i386: Fix up builtins used in avx512bf16vlintrin.h [PR108881]

    The builtins used in avx512bf16vlintrin.h implementation need both
    avx512bf16 and avx512vl ISAs, which the header ensures for them, but
    the builtins weren't actually requiring avx512vl, so when used by hand
    with just -mavx512bf16 -mno-avx512vl it resulted in ICEs.

    Fixed by adding OPTION_MASK_ISA_AVX512VL to their BDESC.

    2023-02-24  Jakub Jelinek  <jakub@redhat.com>

            PR target/108881
            * config/i386/i386-builtin.def (__builtin_ia32_cvtne2ps2bf16_v16bf,
            __builtin_ia32_cvtne2ps2bf16_v16bf_mask,
            __builtin_ia32_cvtne2ps2bf16_v16bf_maskz,
            __builtin_ia32_cvtne2ps2bf16_v8bf,
            __builtin_ia32_cvtne2ps2bf16_v8bf_mask,
            __builtin_ia32_cvtne2ps2bf16_v8bf_maskz,
            __builtin_ia32_cvtneps2bf16_v8sf_mask,
            __builtin_ia32_cvtneps2bf16_v8sf_maskz,
            __builtin_ia32_cvtneps2bf16_v4sf_mask,
            __builtin_ia32_cvtneps2bf16_v4sf_maskz,
            __builtin_ia32_dpbf16ps_v8sf, __builtin_ia32_dpbf16ps_v8sf_mask,
            __builtin_ia32_dpbf16ps_v8sf_maskz, __builtin_ia32_dpbf16ps_v4sf,
            __builtin_ia32_dpbf16ps_v4sf_mask,
            __builtin_ia32_dpbf16ps_v4sf_maskz): Require also
            OPTION_MASK_ISA_AVX512VL.

            * gcc.target/i386/avx512bf16-pr108881.c: New test.

[Bug target/108881] "__builtin_ia32_cvtne2ps2bf16_v16hi" compiled only with option -mavx512bf16 report ICE.

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108881

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed on the trunk so far.
I think we want to backport to 10/11/12, though in that case it won't be v*bf
but v*hi.

[Bug target/108881] "__builtin_ia32_cvtne2ps2bf16_v16hi" compiled only with option -mavx512bf16 report ICE.

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108881

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:1b67cce6e55f57a996228646c21b78db1950e4b8

commit r12-9276-g1b67cce6e55f57a996228646c21b78db1950e4b8
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Fri Feb 24 10:12:44 2023 +0100

    i386: Fix up builtins used in avx512bf16vlintrin.h [PR108881]

    The builtins used in avx512bf16vlintrin.h implementation need both
    avx512bf16 and avx512vl ISAs, which the header ensures for them, but
    the builtins weren't actually requiring avx512vl, so when used by hand
    with just -mavx512bf16 -mno-avx512vl it resulted in ICEs.

    Fixed by adding OPTION_MASK_ISA_AVX512VL to their BDESC.

    2023-02-24  Jakub Jelinek  <jakub@redhat.com>

            PR target/108881
            * config/i386/i386-builtin.def (__builtin_ia32_cvtne2ps2bf16_v16hi,
            __builtin_ia32_cvtne2ps2bf16_v16hi_mask,
            __builtin_ia32_cvtne2ps2bf16_v16hi_maskz,
            __builtin_ia32_cvtne2ps2bf16_v8hi,
            __builtin_ia32_cvtne2ps2bf16_v8hi_mask,
            __builtin_ia32_cvtne2ps2bf16_v8hi_maskz,
            __builtin_ia32_cvtneps2bf16_v8sf_mask,
            __builtin_ia32_cvtneps2bf16_v8sf_maskz,
            __builtin_ia32_cvtneps2bf16_v4sf_mask,
            __builtin_ia32_cvtneps2bf16_v4sf_maskz,
            __builtin_ia32_dpbf16ps_v8sf, __builtin_ia32_dpbf16ps_v8sf_mask,
            __builtin_ia32_dpbf16ps_v8sf_maskz, __builtin_ia32_dpbf16ps_v4sf,
            __builtin_ia32_dpbf16ps_v4sf_mask,
            __builtin_ia32_dpbf16ps_v4sf_maskz): Require also
            OPTION_MASK_ISA_AVX512VL.

            * gcc.target/i386/avx512bf16-pr108881.c: New test.

    (cherry picked from commit 0ccfa3884f638816af0f5a3f0ee2695e0771ef6d)

[Bug target/108881] "__builtin_ia32_cvtne2ps2bf16_v16hi" compiled only with option -mavx512bf16 report ICE.

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108881

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed for 12.3 too.

[Bug target/108881] "__builtin_ia32_cvtne2ps2bf16_v16hi" compiled only with option -mavx512bf16 report ICE.

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108881

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:37c610333335d754f4e4c074a8fd5cc996ffee34

commit r11-10715-g37c610333335d754f4e4c074a8fd5cc996ffee34
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Fri Feb 24 10:12:44 2023 +0100

    i386: Fix up builtins used in avx512bf16vlintrin.h [PR108881]

    The builtins used in avx512bf16vlintrin.h implementation need both
    avx512bf16 and avx512vl ISAs, which the header ensures for them, but
    the builtins weren't actually requiring avx512vl, so when used by hand
    with just -mavx512bf16 -mno-avx512vl it resulted in ICEs.

    Fixed by adding OPTION_MASK_ISA_AVX512VL to their BDESC.

    2023-02-24  Jakub Jelinek  <jakub@redhat.com>

            PR target/108881
            * config/i386/i386-builtin.def (__builtin_ia32_cvtne2ps2bf16_v16hi,
            __builtin_ia32_cvtne2ps2bf16_v16hi_mask,
            __builtin_ia32_cvtne2ps2bf16_v16hi_maskz,
            __builtin_ia32_cvtne2ps2bf16_v8hi,
            __builtin_ia32_cvtne2ps2bf16_v8hi_mask,
            __builtin_ia32_cvtne2ps2bf16_v8hi_maskz,
            __builtin_ia32_cvtneps2bf16_v8sf_mask,
            __builtin_ia32_cvtneps2bf16_v8sf_maskz,
            __builtin_ia32_cvtneps2bf16_v4sf_mask,
            __builtin_ia32_cvtneps2bf16_v4sf_maskz,
            __builtin_ia32_dpbf16ps_v8sf, __builtin_ia32_dpbf16ps_v8sf_mask,
            __builtin_ia32_dpbf16ps_v8sf_maskz, __builtin_ia32_dpbf16ps_v4sf,
            __builtin_ia32_dpbf16ps_v4sf_mask,
            __builtin_ia32_dpbf16ps_v4sf_maskz): Require also
            OPTION_MASK_ISA_AVX512VL.

            * gcc.target/i386/avx512bf16-pr108881.c: New test.

    (cherry picked from commit 0ccfa3884f638816af0f5a3f0ee2695e0771ef6d)

[Bug target/108881] "__builtin_ia32_cvtne2ps2bf16_v16hi" compiled only with option -mavx512bf16 report ICE.

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108881

--- Comment #10 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed for 11.4 as well.

[Bug target/108881] "__builtin_ia32_cvtne2ps2bf16_v16hi" compiled only with option -mavx512bf16 report ICE.

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108881

--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:8f8472f3119751df3b4906bbd08fdad74ef63f33

commit r10-11369-g8f8472f3119751df3b4906bbd08fdad74ef63f33
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Fri Feb 24 10:12:44 2023 +0100

    i386: Fix up builtins used in avx512bf16vlintrin.h [PR108881]

    The builtins used in avx512bf16vlintrin.h implementation need both
    avx512bf16 and avx512vl ISAs, which the header ensures for them, but
    the builtins weren't actually requiring avx512vl, so when used by hand
    with just -mavx512bf16 -mno-avx512vl it resulted in ICEs.

    Fixed by adding OPTION_MASK_ISA_AVX512VL to their BDESC.

    2023-02-24  Jakub Jelinek  <jakub@redhat.com>

            PR target/108881
            * config/i386/i386-builtin.def (__builtin_ia32_cvtne2ps2bf16_v16hi,
            __builtin_ia32_cvtne2ps2bf16_v16hi_mask,
            __builtin_ia32_cvtne2ps2bf16_v16hi_maskz,
            __builtin_ia32_cvtne2ps2bf16_v8hi,
            __builtin_ia32_cvtne2ps2bf16_v8hi_mask,
            __builtin_ia32_cvtne2ps2bf16_v8hi_maskz,
            __builtin_ia32_cvtneps2bf16_v8sf_mask,
            __builtin_ia32_cvtneps2bf16_v8sf_maskz,
            __builtin_ia32_cvtneps2bf16_v4sf_mask,
            __builtin_ia32_cvtneps2bf16_v4sf_maskz,
            __builtin_ia32_dpbf16ps_v8sf, __builtin_ia32_dpbf16ps_v8sf_mask,
            __builtin_ia32_dpbf16ps_v8sf_maskz, __builtin_ia32_dpbf16ps_v4sf,
            __builtin_ia32_dpbf16ps_v4sf_mask,
            __builtin_ia32_dpbf16ps_v4sf_maskz): Require also
            OPTION_MASK_ISA_AVX512VL.

            * gcc.target/i386/avx512bf16-pr108881.c: New test.

    (cherry picked from commit 0ccfa3884f638816af0f5a3f0ee2695e0771ef6d)

[Bug target/108881] "__builtin_ia32_cvtne2ps2bf16_v16hi" compiled only with option -mavx512bf16 report ICE.

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108881

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #12 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed for 10.5 too.