[Bug ada/108909] New: Build process does not honor discovered path to "gnatmake" and "gnatlink"

[Bug ada/108909] New: Build process does not honor discovered path to "gnatmake" and "gnatlink"

[emr-gnu at hev dot psu.edu]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108909

            Bug ID: 108909
           Summary: Build process does not honor discovered path to
                    "gnatmake" and "gnatlink"
           Product: gcc
           Version: 12.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: ada
          Assignee: unassigned at gcc dot gnu.org
          Reporter: emr-gnu at hev dot psu.edu
                CC: dkm at gcc dot gnu.org
  Target Milestone: ---

Created attachment 54521
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54521&action=edit
Patch to resolve gnatmake build issue

When attempting to build GCC 12.2 from released source:

$ GNATBIND=gnatbind-12.1 GNATMAKE=gnatmake-12.1 ../gcc-12.2.0/configure
--enable-languages=c,c++,ada,fortran --program-suffix=-12.2 {...blah blah...}
{...}
checking for x86_64-linux-gnu-gnatbind... gnatbind-12.1
checking for x86_64-linux-gnu-gnatmake... gnatmake-12.1
checking whether compiler driver understands Ada... yes
{...much later...}
mkdir -p ada/gen_il
cd ada/gen_il; gnatmake -q -g -gnata -gnat2012 -gnatw.g -gnatyg -gnatU
-I/build/gcc-12.2.0/gcc/ada gen_il-main
/bin/sh: gnatmake: command not found
make: *** [ada/stamp-gen_il] Error 127

This seems similar to PR 30541, in that if your system-level packages don't
have the GNAT tools installed, but you have specified an alternate compiler
path to Ada tools in the environment, the build scripts ignore the
configure-guessed (or environment-specified) options, and just blindly call
"gnatmake".  Thus, the build fails.

The fix is to change lines 21, 42, and 49 of gcc/ada/Make-generated.in to use
"$(GNATMAKE)" instead of "gnatmake".

[Bug ada/108909] Build process does not honor discovered path to "gnatmake" and "gnatlink"

[emr-gnu at hev dot psu.edu]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108909

--- Comment #1 from Eric Reischer <emr-gnu at hev dot psu.edu> ---
One more:

--- gcc-12.2.0/gcc/ada/gcc-interface/Makefile.in        2022-08-19
04:09:52.352659553 -0400
+++ gcc-12.2.0-fixed/gcc/ada/gcc-interface/Makefile.in  2023-02-23
16:27:59.604161728 -0500
@@ -616,7 +616,7 @@
        -$(MKDIR) ./bldtools/oscons
        $(RM) $(addprefix ./bldtools/oscons/,$(notdir $^))
        $(CP) $^ ./bldtools/oscons
-       (cd ./bldtools/oscons ; gnatmake -q xoscons)
+       (cd ./bldtools/oscons ; $(GNATMAKE) -q xoscons)

 $(RTSDIR)/s-oscons.ads: ../stamp-gnatlib1-$(RTSDIR) s-oscons-tmplt.c gsocket.h
./bldtools/oscons/xoscons
        $(RM) $(RTSDIR)/s-oscons-tmplt.i $(RTSDIR)/s-oscons-tmplt.s

[Bug ada/108909] Build process does not honor discovered path to "gnatmake" and "gnatlink"

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108909

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2023-02-26
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |WAITING
                 CC|                            |ebotcazou at gcc dot gnu.org

--- Comment #2 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
Please post a complete patch on gcc`patches@gcc.gnu.org

[Bug ada/108909] Build process does not honor discovered path to "gnatmake" and "gnatlink"

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108909

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |NEW

--- Comment #3 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
There is already one at
  https://gcc.gnu.org/pipermail/gcc-patches/2023-January/610049.html

[Bug ada/108909] Build process does not honor discovered path to "gnatmake" and "gnatlink"

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108909

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Eric Botcazou <ebotcazou@gcc.gnu.org>:

https://gcc.gnu.org/g:e6d39f68d03c46637ca6e1bede3d28eae6278df3

commit r13-6351-ge6d39f68d03c46637ca6e1bede3d28eae6278df3
Author: Peter Foley <pefoley2@pefoley.com>
Date:   Sun Feb 26 18:52:50 2023 +0100

    Respect GNATMAKE Makefile variable

    gcc/ada/
            PR ada/108909
            * Make-generated.in: Use GNATMAKE.
            * gcc-interface/Makefile.in: Ditto.

[Bug ada/108909] Build process does not honor discovered path to "gnatmake" and "gnatlink"

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108909

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
   Target Milestone|---                         |13.0
         Resolution|---                         |FIXED

--- Comment #5 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
Fixed on the mainline.

[Bug ada/108909] Build process does not honor discovered path to "gnatmake" and "gnatlink"

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108909

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Eric Botcazou <ebotcazou@gcc.gnu.org>:

https://gcc.gnu.org/g:94a67e3044212592ce408952c526210a81e1bf49

commit r13-6504-g94a67e3044212592ce408952c526210a81e1bf49
Author: Eric Botcazou <ebotcazou@adacore.com>
Date:   Mon Mar 6 11:36:19 2023 +0100

    Revert "Respect GNATMAKE Makefile variable" commit

    It breaks cross native builds.

    gcc/ada/
            PR ada/108909
            PR ada/108983
            * Make-generated.in: Do not use GNATMAKE.
            * gcc-interface/Makefile.in: Ditto.

[Bug ada/108909] Build process does not honor discovered path to "gnatmake" and "gnatlink"

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108909

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
             Status|RESOLVED                    |REOPENED

--- Comment #7 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
.

[Bug ada/108909] Build process does not honor discovered path to "gnatmake" and "gnatlink"

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108909

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|13.0                        |13.2

--- Comment #8 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 13.1 is being released, retargeting bugs to GCC 13.2.

[Bug ada/108909] Build process does not honor discovered path to "gnatmake" and "gnatlink"

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108909

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|13.2                        |13.3

--- Comment #9 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 13.2 is being released, retargeting bugs to GCC 13.3.