public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/108924] New: memory leak in doloop_warn
@ 2023-02-24 12:31 rguenth at gcc dot gnu.org
2023-02-24 16:37 ` [Bug fortran/108924] " anlauf at gcc dot gnu.org
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: rguenth at gcc dot gnu.org @ 2023-02-24 12:31 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108924
Bug ID: 108924
Summary: memory leak in doloop_warn
Product: gcc
Version: 13.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: fortran
Assignee: unassigned at gcc dot gnu.org
Reporter: rguenth at gcc dot gnu.org
Target Milestone: ---
valgrind leak check complains
==8747== 16 bytes in 2 blocks are definitely lost in loss record 6 of 2,309
==8747== at 0x4C346A4: malloc (in
/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==8747== by 0x5697698: __gmp_default_allocate (in
/usr/lib64/libgmp.so.10.3.2)
==8747== by 0x56A7A22: __gmpz_init_set (in /usr/lib64/libgmp.so.10.3.2)
==8747== by 0x874110: do_subscript (frontend-passes.cc:2863)
==8747== by 0x874110: do_function(gfc_expr**, int*, void*)
(frontend-passes.cc:2710)
==8747== by 0x870675: gfc_expr_walker(gfc_expr**, int (*)(gfc_expr**, int*,
void*), void*) (frontend-passes.cc:5243)
==8747== by 0x870859: gfc_expr_walker(gfc_expr**, int (*)(gfc_expr**, int*,
void*), void*) (frontend-passes.cc:5250)
==8747== by 0x870859: gfc_expr_walker(gfc_expr**, int (*)(gfc_expr**, int*,
void*), void*) (frontend-passes.cc:5250)
==8747== by 0x8727D9: gfc_code_walker(gfc_code**, int (*)(gfc_code**, int*,
void*), int (*)(gfc_expr**, int*, void*), void*) (frontend-passes.cc:5680)
==8747== by 0x872857: gfc_code_walker(gfc_code**, int (*)(gfc_code**, int*,
void*), int (*)(gfc_expr**, int*, void*), void*) (frontend-passes.cc:5687)
==8747== by 0x872857: gfc_code_walker(gfc_code**, int (*)(gfc_code**, int*,
void*), int (*)(gfc_expr**, int*, void*), void*) (frontend-passes.cc:5687)
==8747== by 0x872857: gfc_code_walker(gfc_code**, int (*)(gfc_code**, int*,
void*), int (*)(gfc_expr**, int*, void*), void*) (frontend-passes.cc:5687)
==8747== by 0x8738CB: doloop_warn(gfc_namespace*) (frontend-passes.cc:3079)
so it looks like some gmp vars are not released.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug fortran/108924] memory leak in doloop_warn
2023-02-24 12:31 [Bug fortran/108924] New: memory leak in doloop_warn rguenth at gcc dot gnu.org
@ 2023-02-24 16:37 ` anlauf at gcc dot gnu.org
2023-02-24 20:30 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: anlauf at gcc dot gnu.org @ 2023-02-24 16:37 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108924
anlauf at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |anlauf at gcc dot gnu.org
--- Comment #1 from anlauf at gcc dot gnu.org ---
Created attachment 54532
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54532&action=edit
Tentative patch
Does the attached fix this? Without a testcase this seems to be the fix
obtained from reviewing the surrounding code. Regtests cleanly here.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug fortran/108924] memory leak in doloop_warn
2023-02-24 12:31 [Bug fortran/108924] New: memory leak in doloop_warn rguenth at gcc dot gnu.org
2023-02-24 16:37 ` [Bug fortran/108924] " anlauf at gcc dot gnu.org
@ 2023-02-24 20:30 ` cvs-commit at gcc dot gnu.org
2023-02-24 20:39 ` anlauf at gcc dot gnu.org
2023-03-03 14:04 ` rguenth at gcc dot gnu.org
3 siblings, 0 replies; 5+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-02-24 20:30 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108924
--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:
https://gcc.gnu.org/g:45f406c4f62e516b58dcda20b5a7aa43ff0aa0f3
commit r13-6336-g45f406c4f62e516b58dcda20b5a7aa43ff0aa0f3
Author: Harald Anlauf <anlauf@gmx.de>
Date: Fri Feb 24 19:56:32 2023 +0100
Fortran: frontend passes do_subscript leaks gmp memory [PR108924]
gcc/fortran/ChangeLog:
PR fortran/108924
* frontend-passes.cc (do_subscript): Clear used gmp variable.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug fortran/108924] memory leak in doloop_warn
2023-02-24 12:31 [Bug fortran/108924] New: memory leak in doloop_warn rguenth at gcc dot gnu.org
2023-02-24 16:37 ` [Bug fortran/108924] " anlauf at gcc dot gnu.org
2023-02-24 20:30 ` cvs-commit at gcc dot gnu.org
@ 2023-02-24 20:39 ` anlauf at gcc dot gnu.org
2023-03-03 14:04 ` rguenth at gcc dot gnu.org
3 siblings, 0 replies; 5+ messages in thread
From: anlauf at gcc dot gnu.org @ 2023-02-24 20:39 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108924
anlauf at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |ASSIGNED
Last reconfirmed| |2023-02-24
Ever confirmed|0 |1
Assignee|unassigned at gcc dot gnu.org |anlauf at gcc dot gnu.org
--- Comment #3 from anlauf at gcc dot gnu.org ---
Taken. Waiting on feedback.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug fortran/108924] memory leak in doloop_warn
2023-02-24 12:31 [Bug fortran/108924] New: memory leak in doloop_warn rguenth at gcc dot gnu.org
` (2 preceding siblings ...)
2023-02-24 20:39 ` anlauf at gcc dot gnu.org
@ 2023-03-03 14:04 ` rguenth at gcc dot gnu.org
3 siblings, 0 replies; 5+ messages in thread
From: rguenth at gcc dot gnu.org @ 2023-03-03 14:04 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108924
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
Building the benchmark set fprate_any_fortran of SPEC CPU 2017 there's no leak
from an allocation in do_subscript or do_function anymore.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-03-03 14:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-24 12:31 [Bug fortran/108924] New: memory leak in doloop_warn rguenth at gcc dot gnu.org
2023-02-24 16:37 ` [Bug fortran/108924] " anlauf at gcc dot gnu.org
2023-02-24 20:30 ` cvs-commit at gcc dot gnu.org
2023-02-24 20:39 ` anlauf at gcc dot gnu.org
2023-03-03 14:04 ` rguenth at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).