[Bug modula2/108944] New: libgm2/libm2pim/sckt.cc:254:3: warning: memset() called to fill 0 bytes. [memsetZeroBytes]

[Bug modula2/108944] New: libgm2/libm2pim/sckt.cc:254:3: warning: memset() called to fill 0 bytes. [memsetZeroBytes]

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108944

            Bug ID: 108944
           Summary: libgm2/libm2pim/sckt.cc:254:3: warning: memset()
                    called to fill 0 bytes. [memsetZeroBytes]
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: modula2
          Assignee: gaius at gcc dot gnu.org
          Reporter: dcb314 at hotmail dot com
  Target Milestone: ---

Source code is

  memset (&sa, sizeof (struct sockaddr_in), 0);

Parameters wrong way around. Maybe better code:

  memset (&sa, 0, sizeof (struct sockaddr_in));

Thanks to static analyser cppcheck for finding this problem.

[Bug modula2/108944] libgm2/libm2pim/sckt.cc:254:3: warning: memset() called to fill 0 bytes. [memsetZeroBytes]

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108944

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2023-02-27
     Ever confirmed|0                           |1

--- Comment #1 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Thank you very much for reporting this bug - very useful regarding PR108835 
(or at least it is related and timely).

[Bug modula2/108944] libgm2/libm2pim/sckt.cc:254:3: warning: memset() called to fill 0 bytes. [memsetZeroBytes]

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108944

--- Comment #2 from David Binderman <dcb314 at hotmail dot com> ---
(In reply to Gaius Mulley from comment #1)
> Thank you very much for reporting this bug - very useful regarding PR108835 
> (or at least it is related and timely).

You are welcome. gcc flags -Wall and -Wmemset-transposed-args
seem to provide this warning.

For example:

memset.cc:17:15: warning: ‘memset’ used with constant zero length parameter;
thi
s could be due to transposed parameters [-Wmemset-transposed-args]
   17 |         memset( t.buf1, 20, 0);
      |         ~~~~~~^~~~~~~~~~~~~~~~

[Bug modula2/108944] libgm2/libm2pim/sckt.cc:254:3: warning: memset() called to fill 0 bytes. [memsetZeroBytes]

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108944

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Gaius Mulley <gaius@gcc.gnu.org>:

https://gcc.gnu.org/g:e5fcf084e381aefe170dcd418dc97e469dacfa91

commit r13-6359-ge5fcf084e381aefe170dcd418dc97e469dacfa91
Author: Gaius Mulley <gaiusmod2@gmail.com>
Date:   Mon Feb 27 16:29:18 2023 +0000

    libgm2/libm2pim/sckt.cc:254:3: warning: memset() called to fill 0 bytes
[PR108944]

    The pattern parameter to memset is second.  Correct an obvious mistake
    in libm2pim/sckt.cc.

    libgm2/ChangeLog:

            PR modula2/108944
            * libm2pim/sckt.cc (getLocalIP): Correct parameter order.

    Signed-off-by: Gaius Mulley <gaiusmod2@gmail.com>

[Bug modula2/108944] libgm2/libm2pim/sckt.cc:254:3: warning: memset() called to fill 0 bytes. [memsetZeroBytes]

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108944

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Gaius Mulley <gaius at gcc dot gnu.org> ---
many thanks for the flag info - will use these when building.
Closing now that the master branch has this fix.