[Bug middle-end/109006] New: [13 Regression] Python Exception <class 'gdb.error'>: There is no member or method named m_vecdata. since r13-6332

[Bug middle-end/109006] New: [13 Regression] Python Exception <class 'gdb.error'>: There is no member or method named m_vecdata. since r13-6332

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109006

            Bug ID: 109006
           Summary: [13 Regression] Python Exception <class 'gdb.error'>:
                    There is no member or method named m_vecdata. since
                    r13-6332
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
          Assignee: unassigned at gcc dot gnu.org
          Reporter: jakub at gcc dot gnu.org
  Target Milestone: ---

r13-6332-g2dd68cddbc745d removed m_vecdata array from vec.h, but gdbhooks.py
still relies on it:
gdbhooks.py:Instead (for now) you must access m_vecdata:
gdbhooks.py:  (gdb) p bb->preds->m_vecdata[0]
gdbhooks.py:  (gdb) p bb->preds->m_vecdata[1]
gdbhooks.py:        m_vecdata = self.gdbval['m_vecdata']
gdbhooks.py:            yield ('[%d]' % i, m_vecdata[i])
read-rtl-function.cc:     We reconstruct
cfun->cfg->x_basic_block_info->m_vecdata with NULL
vec.cc:/* Verify accesses to m_vecdata are done indirectly.  */
vec.h:# pragma GCC poison m_vec m_vecpfx m_vecdata

(the last one can stay although not needed).

So, when trying to print some vector, one can get error like
(gdb) p cfun->local_decls
Python Exception <class 'gdb.error'>: There is no member or method named
m_vecdata.
$2 = 0x7fffea2eb1b8

[Bug middle-end/109006] [13 Regression] Python Exception <class 'gdb.error'>: There is no member or method named m_vecdata. since r13-6332

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109006

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1
   Target Milestone|---                         |13.0

[Bug middle-end/109006] [13 Regression] Python Exception <class 'gdb.error'>: There is no member or method named m_vecdata. since r13-6332

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109006

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
As for the non-*.py comments, perhaps:
2023-03-03  Jakub Jelinek  <jakub@redhat.com>

        PR middle-end/109006
        * vec.cc (test_auto_alias): Adjust comment for removal of
        m_vecdata.
        * read-rtl-function.cc (function_reader::parse_block): Likewise.

--- gcc/vec.cc.jj       2023-02-27 09:41:30.910265623 +0100
+++ gcc/vec.cc  2023-03-03 13:00:01.941663049 +0100
@@ -568,7 +568,7 @@ test_auto_delete_vec ()
   ASSERT_EQ (dtor_count, 2);
 }

-/* Verify accesses to m_vecdata are done indirectly.  */
+/* Verify accesses to vector elements are done indirectly.  */

 static void
 test_auto_alias ()
--- gcc/read-rtl-function.cc.jj 2023-01-02 09:32:54.001828467 +0100
+++ gcc/read-rtl-function.cc    2023-03-03 12:59:15.941340372 +0100
@@ -622,10 +622,11 @@ function_reader::parse_block ()

      These can get out-of-sync when basic blocks are optimized away.
      They get back in sync by "compact_blocks".
-     We reconstruct cfun->cfg->x_basic_block_info->m_vecdata with NULL
-     values in it for any missing basic blocks, so that (a) == (b) for
-     all of the blocks we create.  The doubly-linked list of basic
-     blocks (next_bb/prev_bb) skips over these "holes".  */
+     We reconstruct cfun->cfg->x_basic_block_info->address () pointed
+     vector elements with NULL values in it for any missing basic blocks,
+     so that (a) == (b) for all of the blocks we create.  The
+     doubly-linked list of basic blocks (next_bb/prev_bb) skips over
+     these "holes".  */

   if (m_highest_bb_idx < bb_idx)
     m_highest_bb_idx = bb_idx;

[Bug middle-end/109006] [13 Regression] Python Exception <class 'gdb.error'>: There is no member or method named m_vecdata. since r13-6332

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109006

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:ce1c99f1ccd7b1229a4f8531d6b6de6cf571a9ef

commit r13-6453-gce1c99f1ccd7b1229a4f8531d6b6de6cf571a9ef
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Fri Mar 3 16:41:29 2023 +0000

    gcc: Adjust gdbhooks.py VecPrinter for vec layout changes [PR109006]

    gcc/ChangeLog:

            PR middle-end/109006
            * gdbhooks.py (VecPrinter): Adjust for new vec layout.

[Bug middle-end/109006] [13 Regression] Python Exception <class 'gdb.error'>: There is no member or method named m_vecdata. since r13-6332

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109006

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:59a576f274b9093fd4b25eb6be556b40c2424478

commit r13-6454-g59a576f274b9093fd4b25eb6be556b40c2424478
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Fri Mar 3 16:41:29 2023 +0000

    gcc: Fix gdbhooks.py VecPrinter for vec<> as well as vec<>* [PR109006]

    gcc/ChangeLog:

            PR middle-end/109006
            * gdbhooks.py (VecPrinter): Handle vec<T> as well as vec<T>*.

[Bug middle-end/109006] [13 Regression] Python Exception <class 'gdb.error'>: There is no member or method named m_vecdata. since r13-6332

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109006

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:4ee2f419fe42222dbb21dfb0622cc7c0e46a2261

commit r13-6478-g4ee2f419fe42222dbb21dfb0622cc7c0e46a2261
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Sat Mar 4 11:24:04 2023 +0100

    Remove remaining traces of m_vecdata from comments [PR109006]

    The following patch adjusts remaining references to the removed m_vecdata
    array from vec.h in various comments.

    2023-03-04  Jakub Jelinek  <jakub@redhat.com>

            PR middle-end/109006
            * vec.cc (test_auto_alias): Adjust comment for removal of
            m_vecdata.
            * read-rtl-function.cc (function_reader::parse_block): Likewise.
            * gdbhooks.py: Likewise.

[Bug middle-end/109006] [13 Regression] Python Exception <class 'gdb.error'>: There is no member or method named m_vecdata. since r13-6332

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109006

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed by Jonathan's patches.