[Bug c/109139] New: ice in make_decl_rtl, at varasm.cc:1442

[Bug c/109139] New: ice in make_decl_rtl, at varasm.cc:1442

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109139

            Bug ID: 109139
           Summary: ice in make_decl_rtl, at varasm.cc:1442
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dcb314 at hotmail dot com
  Target Milestone: ---

This C code:

const int COMPARE_CANDIDATE;
char ipmi_ek_compare_link_record1_0, ipmi_ek_compare_link_record2_0;
void ipmi_ek_compare_link() {
  for (; ipmi_ek_compare_link_record1_0;)
    for (; ipmi_ek_compare_link_record2_0;) {
      int link[COMPARE_CANDIDATE];
    }
}

when compiled by today's gcc trunk, does this:

$ ~/gcc/results.20230315/bin/gcc -c -w -O1 -ftrivial-auto-var-init=zero
bug896.c 
during RTL pass: expand
bug896.c: In function ‘ipmi_ek_compare_link’:
bug896.c:6:11: internal compiler error: in make_decl_rtl, at varasm.cc:1442
    6 |       int link[COMPARE_CANDIDATE];
      |           ^~~~
0x7c9502 make_decl_rtl(tree_node*)
        ../../trunk.year/gcc/varasm.cc:1442

It worked yesterday:

$ ~/gcc/results.20230314/bin/gcc -c -w -O1 -ftrivial-auto-var-init=zero
bug896.c 
$ 

The git range seems to be g:e17936f842d28854 .. g:a9ae16db8cbb2c0e.

[Bug tree-optimization/109139] [13 Regression] ice in make_decl_rtl, at varasm.cc:1442

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109139

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
   Target Milestone|---                         |13.0
            Summary|ice in make_decl_rtl, at    |[13 Regression] ice in
                   |varasm.cc:1442              |make_decl_rtl, at
                   |                            |varasm.cc:1442
           Keywords|needs-bisection             |ice-on-valid-code
   Last reconfirmed|                            |2023-03-15

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Before we had:
  unsigned char link.9[0:18446744073709551615];
in the referenced variables
but after it is gone.

But it is still referened:
  MEM[(int[0:D.2753] *)&link.9] = .DEFERRED_INIT (0, 2, &"link"[0]);

release_ssa removes it but I have not looked into how.

Note the way ccp1 turns this VLA into a non-VLA might be an issue too ...

[Bug tree-optimization/109139] [13 Regression] ice in make_decl_rtl, at varasm.cc:1442

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109139

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
I am almost positive it is r13-6661-gbd6e566e9dc543cf4f6df69dcefb40bb8b4100f1 .

[Bug tree-optimization/109139] [13 Regression] ice in make_decl_rtl, at varasm.cc:1442

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109139

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
Will have a look.

[Bug tree-optimization/109139] [13 Regression] ice in make_decl_rtl, at varasm.cc:1442

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109139

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:0fc541efc340535d212cd685176bd9592905de8a

commit r13-6691-g0fc541efc340535d212cd685176bd9592905de8a
Author: Richard Biener <rguenther@suse.de>
Date:   Wed Mar 15 09:47:18 2023 +0100

    tree-optimization/109139 - fix .DEFERRED_INIT removal

    The following make sure to strip MEMs when looking for unused
    decls on the LHS of .DEFERRED_INIT.

            PR tree-optimization/109139
            * tree-ssa-live.cc (remove_unused_locals): Look at the
            base address for unused decls on the LHS of .DEFERRED_INIT.

            * gcc.dg/torture/pr109139.c: New testcase.

[Bug tree-optimization/109139] [13 Regression] ice in make_decl_rtl, at varasm.cc:1442

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109139

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.