[Bug c/109174] New: incorrect intrinsic signature for AVX-512 srai*

[Bug c/109174] New: incorrect intrinsic signature for AVX-512 srai*

[malat at debian dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109174

            Bug ID: 109174
           Summary: incorrect intrinsic signature for AVX-512 srai*
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: malat at debian dot org
  Target Milestone: ---

gcc-13 currently rejects the following:

% /usr/lib/gcc-snapshot/bin/gcc -c -Wsign-conversion -Werror  -mavx512bw -O2
tu2.c
tu2.c: In function 'foo':
tu2.c:7:24: error: conversion to 'int' from 'unsigned int' may change the sign
of the result [-Werror=sign-conversion]
    7 |   _mm512_slli_epi16(a, bar());
      |                        ^~~~~
tu2.c:8:24: error: conversion to 'int' from 'unsigned int' may change the sign
of the result [-Werror=sign-conversion]
    8 |   _mm512_srai_epi16(a, bar());
      |                        ^~~~~
tu2.c:9:24: error: conversion to 'int' from 'unsigned int' may change the sign
of the result [-Werror=sign-conversion]
    9 |   _mm512_srli_epi16(a, bar());
      |                        ^~~~~
cc1: all warnings being treated as errors

with

% cat tu2.c
#include <immintrin.h>

extern unsigned int bar();

void foo(__m512i a)
{
  _mm512_slli_epi16(a, bar());
  _mm512_srai_epi16(a, bar());
  _mm512_srli_epi16(a, bar());
}

intel documentation declares it as unsigned int

https://www.intel.com/content/www/us/en/docs/cpp-compiler/developer-guide-reference/2021-8/intrinsics-for-shift-operations.html

[...]
__m512i _mm512_slli_epi16(__m512i a, unsigned int imm)
[...]

% /usr/lib/gcc-snapshot/bin/gcc --version
gcc (Debian 20230315-1) 13.0.1 20230315 (experimental) [master
r13-6680-ga9ae16db8cb]

[Bug target/109174] incorrect intrinsic signature for AVX-512 srai*

[crazylht at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109174

--- Comment #1 from Hongtao.liu <crazylht at gmail dot com> ---
Yes, it should be changed to align with intrinsic guide.

[Bug target/109174] incorrect intrinsic signature for AVX-512 srai*

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109174

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Haochen Jiang <jianghc@gcc.gnu.org>:

https://gcc.gnu.org/g:4a84a2db2ad7cc57c1674849f845c42ed4ad12ab

commit r14-1234-g4a84a2db2ad7cc57c1674849f845c42ed4ad12ab
Author: Hu, Lin1 <lin1.hu@intel.com>
Date:   Tue May 23 10:08:29 2023 +0800

    i386: Fix incorrect intrinsic signature for AVX512 s{lli|rai|rli}

    This patch aims to fix incorrect intrinsic signature for
    _mm{512|256|}_s{lli|rai|rli}_epi*.

    gcc/ChangeLog:

            PR target/109173
            PR target/109174
            * config/i386/avx512bwintrin.h (_mm512_srli_epi16): Change type
from
            int to const int or const int to const unsigned int.
            (_mm512_mask_srli_epi16): Ditto.
            (_mm512_slli_epi16): Ditto.
            (_mm512_mask_slli_epi16): Ditto.
            (_mm512_maskz_slli_epi16): Ditto.
            (_mm512_srai_epi16): Ditto.
            (_mm512_mask_srai_epi16): Ditto.
            (_mm512_maskz_srai_epi16): Ditto.
            * config/i386/avx512fintrin.h (_mm512_slli_epi64): Ditto.
            (_mm512_mask_slli_epi64): Ditto.
            (_mm512_maskz_slli_epi64): Ditto.
            (_mm512_srli_epi64): Ditto.
            (_mm512_mask_srli_epi64): Ditto.
            (_mm512_maskz_srli_epi64): Ditto.
            (_mm512_srai_epi64): Ditto.
            (_mm512_mask_srai_epi64): Ditto.
            (_mm512_maskz_srai_epi64): Ditto.
            (_mm512_slli_epi32): Ditto.
            (_mm512_mask_slli_epi32): Ditto.
            (_mm512_maskz_slli_epi32): Ditto.
            (_mm512_srli_epi32): Ditto.
            (_mm512_mask_srli_epi32): Ditto.
            (_mm512_maskz_srli_epi32): Ditto.
            (_mm512_srai_epi32): Ditto.
            (_mm512_mask_srai_epi32): Ditto.
            (_mm512_maskz_srai_epi32): Ditto.
            * config/i386/avx512vlbwintrin.h (_mm256_mask_srai_epi16): Ditto.
            (_mm256_maskz_srai_epi16): Ditto.
            (_mm_mask_srai_epi16): Ditto.
            (_mm_maskz_srai_epi16): Ditto.
            (_mm256_mask_slli_epi16): Ditto.
            (_mm256_maskz_slli_epi16): Ditto.
            (_mm_mask_slli_epi16): Ditto.
            (_mm_maskz_slli_epi16): Ditto.
            (_mm_maskz_srli_epi16): Ditto.
            * config/i386/avx512vlintrin.h (_mm256_mask_srli_epi32): Ditto.
            (_mm256_maskz_srli_epi32): Ditto.
            (_mm_mask_srli_epi32): Ditto.
            (_mm_maskz_srli_epi32): Ditto.
            (_mm256_mask_srli_epi64): Ditto.
            (_mm256_maskz_srli_epi64): Ditto.
            (_mm_mask_srli_epi64): Ditto.
            (_mm_maskz_srli_epi64): Ditto.
            (_mm256_mask_srai_epi32): Ditto.
            (_mm256_maskz_srai_epi32): Ditto.
            (_mm_mask_srai_epi32): Ditto.
            (_mm_maskz_srai_epi32): Ditto.
            (_mm256_srai_epi64): Ditto.
            (_mm256_mask_srai_epi64): Ditto.
            (_mm256_maskz_srai_epi64): Ditto.
            (_mm_srai_epi64): Ditto.
            (_mm_mask_srai_epi64): Ditto.
            (_mm_maskz_srai_epi64): Ditto.
            (_mm_mask_slli_epi32): Ditto.
            (_mm_maskz_slli_epi32): Ditto.
            (_mm_mask_slli_epi64): Ditto.
            (_mm_maskz_slli_epi64): Ditto.
            (_mm256_mask_slli_epi32): Ditto.
            (_mm256_maskz_slli_epi32): Ditto.
            (_mm256_mask_slli_epi64): Ditto.
            (_mm256_maskz_slli_epi64): Ditto.

    gcc/testsuite/ChangeLog:

            PR target/109173
            PR target/109174
            * gcc.target/i386/pr109173-1.c: New test.
            * gcc.target/i386/pr109174-1.c: Ditto.

[Bug target/109174] incorrect intrinsic signature for AVX-512 srai*

[crazylht at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109174

--- Comment #3 from Hongtao.liu <crazylht at gmail dot com> ---
Fixed for GCC14.

[Bug target/109174] incorrect intrinsic signature for AVX-512 srai*

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109174

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Target Milestone|---                         |14.0
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Fixed.