[Bug c/109188] New: Building genmodes under MinGW-W64/MSYS2 fails due to undefined HOST_EXTRA_OBJS_SYMBOL

[Bug c/109188] New: Building genmodes under MinGW-W64/MSYS2 fails due to undefined HOST_EXTRA_OBJS_SYMBOL

[jdx at o2 dot pl]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109188

            Bug ID: 109188
           Summary: Building genmodes under MinGW-W64/MSYS2 fails due to
                    undefined HOST_EXTRA_OBJS_SYMBOL
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: jdx at o2 dot pl
  Target Milestone: ---
              Host: x86_64-w64-mingw32
            Target: arm-eabi

I get the following error message when I try to build master (33fb1625):

make[2]: Entering directory '/d/works/xcomp/gcc-build/gcc'
TARGET_CPU_DEFAULT="" \
HEADERS="auto-host.h ansidecl.h config/i386/xm-mingw32.h" DEFINES="" \
/bin/sh ../../../gcc/gcc/mkconfig.sh config.h
TARGET_CPU_DEFAULT="\"arm7tdmi\"" \
HEADERS="options.h insn-constants.h config/vxworks-dummy.h config/elfos.h
config/arm/unknown-elf.h config/arm/elf.h config/arm/bpabi.h
config/newlib-stdint.h config/arm/aout.h config/arm/arm.h
config/initfini-array.h defaults.h" DEFINES="LIBC_GLIBC=1 LIBC_UCLIBC=2
LIBC_BIONIC=3 LIBC_MUSL=4" \
/bin/sh ../../../gcc/gcc/mkconfig.sh tm.h
TARGET_CPU_DEFAULT="" \
HEADERS="config/arm/arm-flags.h config/arm/arm-protos.h
config/arm/aarch-common-protos.h tm-preds.h" DEFINES="" \
/bin/sh ../../../gcc/gcc/mkconfig.sh tm_p.h
TARGET_CPU_DEFAULT="" \
HEADERS="auto-host.h ansidecl.h config/i386/xm-mingw32.h" DEFINES="" \
/bin/sh ../../../gcc/gcc/mkconfig.sh bconfig.h
g++ -c   -g -O2     -DIN_GCC -fPIC -DCROSS_DIRECTORY_STRUCTURE  
-fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing
-Wwrite-strings -Wcast-qual -Wmissing-format-attribute
-Wconditionally-supported -Woverloaded-virtual -pedantic -Wno-long-long
-Wno-variadic-macros -Wno-overlength-strings   -DHAVE_CONFIG_H 
-DGENERATOR_FILE -I. -Ibuild -I../../../gcc/gcc -I../../../gcc/gcc/build
-I../../../gcc/gcc/../include  -I../../../gcc/gcc/../libcpp/include  \
        -o build/genmodes.o ../../../gcc/gcc/genmodes.cc
g++ -c   -g -O2     -DIN_GCC -fPIC -DCROSS_DIRECTORY_STRUCTURE  
-fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing
-Wwrite-strings -Wcast-qual -Wmissing-format-attribute
-Wconditionally-supported -Woverloaded-virtual -pedantic -Wno-long-long
-Wno-variadic-macros -Wno-overlength-strings   -DHAVE_CONFIG_H 
-DGENERATOR_FILE -I. -Ibuild -I../../../gcc/gcc -I../../../gcc/gcc/build
-I../../../gcc/gcc/../include  -I../../../gcc/gcc/../libcpp/include  \
        -o build/errors.o ../../../gcc/gcc/errors.cc
../../../gcc/gcc/errors.cc: In function 'void warning(const char*, ...)':
../../../gcc/gcc/errors.cc:50:12: warning: function 'void warning(const char*,
...)' might be a candidate for 'gnu_printf' format attribute
[-Wsuggest-attribute=format]
   50 |   vfprintf (stderr, format, ap);
      |   ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
../../../gcc/gcc/errors.cc: In function 'void error(const char*, ...)':
../../../gcc/gcc/errors.cc:65:12: warning: function 'void error(const char*,
...)' might be a candidate for 'gnu_printf' format attribute
[-Wsuggest-attribute=format]
   65 |   vfprintf (stderr, format, ap);
      |   ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
../../../gcc/gcc/errors.cc: In function 'void fatal(const char*, ...)':
../../../gcc/gcc/errors.cc:82:12: warning: function 'void fatal(const char*,
...)' might be a candidate for 'gnu_printf' format attribute
[-Wsuggest-attribute=format]
   82 |   vfprintf (stderr, format, ap);
      |   ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
../../../gcc/gcc/errors.cc: In function 'void internal_error(const char*,
...)':
../../../gcc/gcc/errors.cc:97:12: warning: function 'void internal_error(const
char*, ...)' might be a candidate for 'gnu_printf' format attribute
[-Wsuggest-attribute=format]
   97 |   vfprintf (stderr, format, ap);
      |   ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
g++   -g -O2     -DIN_GCC -fPIC -DCROSS_DIRECTORY_STRUCTURE   -fno-exceptions
-fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings
-Wcast-qual -Wmissing-format-attribute -Wconditionally-supported
-Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros
-Wno-overlength-strings   -DHAVE_CONFIG_H  -DGENERATOR_FILE -static-libstdc++
-static-libgcc -Wl,--stack,12582912
-Wl,--require-defined=HOST_EXTRA_OBJS_SYMBOL -o build/genmodes.exe \
    build/genmodes.o build/errors.o
../build-x86_64-w64-mingw32/libiberty/libiberty.a
C:/Tools/MSYS/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/12.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
required symbol `HOST_EXTRA_OBJS_SYMBOL' not defined
collect2.exe: error: ld returned 1 exit status
make[2]: *** [Makefile:3042: build/genmodes.exe] Error 1
make[2]: Leaving directory '/d/works/xcomp/gcc-build/gcc'
make[1]: *** [Makefile:4613: all-gcc] Error 2
make[1]: Leaving directory '/d/works/xcomp/gcc-build'
make: *** [Makefile:1034: all] Error 2



My configuration command:

../../gcc/configure --prefix=/usr/local --with-sysroot=/d/works/xcomp/sysroot
--target=arm-eabi --disable-nls --disable-threads --disable-tls
--enable-checking=release --enable-languages=c --with-newlib --without-headers
--enable-multilib --enable-lto --disable-shared --enable-static
--disable-host-shared --disable-bootstrap --disable-libatomic --disable-libgomp
--disable-libitm --disable-libquadmath --disable-libsanitizer --disable-libssp
--disable-libvtv --with-system-zlib

[Bug bootstrap/109188] Building genmodes under MinGW-W64/MSYS2 fails due to undefined HOST_EXTRA_OBJS_SYMBOL

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109188

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
From config/i386/x-mingw32-utf8:
$(COMPILERS) : override LDFLAGS += -Wl,--require-defined=HOST_EXTRA_OBJS_SYMBOL

So LDFLAGS should have been only overridden for COMPILERS target.

What make version are you using?

[Bug bootstrap/109188] Building genmodes under MinGW-W64/MSYS2 fails due to undefined HOST_EXTRA_OBJS_SYMBOL

[jdx at o2 dot pl]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109188

--- Comment #2 from Jan Dubiec <jdx at o2 dot pl> ---
jdx@jdxpc MINGW64 /d/works/xcomp
$ make --version
GNU Make 4.4.1
Built for x86_64-pc-msys
Copyright (C) 1988-2023 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

[Bug bootstrap/109188] Building genmodes under MinGW-W64/MSYS2 fails due to undefined HOST_EXTRA_OBJS_SYMBOL

[jdx at o2 dot pl]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109188

--- Comment #3 from Jan Dubiec <jdx at o2 dot pl> ---
I have just finished painful "git bisect" and found the offending commit:
https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=d11e088210a551235d3937f867ee1c8b19d02290.
However I do not know where the bug is.

[Bug bootstrap/109188] Building genmodes under MinGW-W64/MSYS2 fails due to undefined HOST_EXTRA_OBJS_SYMBOL

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109188

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Does this only happen with a cross to arm or do you know if other targets are
effected?

[Bug bootstrap/109188] Building genmodes under MinGW-W64/MSYS2 fails due to undefined HOST_EXTRA_OBJS_SYMBOL

[jdx at o2 dot pl]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109188

--- Comment #5 from Jan Dubiec <jdx at o2 dot pl> ---
I forgot to mention it in the first message – at least h8300-elf and mips-elf
are also affected. I have just even tried to build native compiler and,
strangely, it has the same issue.

[Bug bootstrap/109188] Building genmodes under MinGW-W64/MSYS2 fails due to undefined HOST_EXTRA_OBJS_SYMBOL

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109188

--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
What version of make are you using? "make -v"
Only cc1, cc1plus, etc. should be getting that option.
Can youbprovide the output of "env" too?
How are you invoking make?

[Bug bootstrap/109188] Building genmodes under MinGW-W64/MSYS2 fails due to undefined HOST_EXTRA_OBJS_SYMBOL

[jdx at o2 dot pl]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109188

--- Comment #7 from Jan Dubiec <jdx at o2 dot pl> ---
Make version is 4.4.1 as comment #2 shows. Usually I call make from my bash
build script using "make 2>&1 | tee buildlog-gcc.txt", but I tried to build
native compiler by simply calling "make" from the bash command line. The "env"
output is as follows:

$ env
!D:=D:\
ProgramFiles(x86)=C:\Program Files (x86)
!::=::\
CommonProgramFiles(x86)=C:\Program Files (x86)\Common Files
!C:=C:\Tools\MSYS
SHELL=/usr/bin/bash
NUMBER_OF_PROCESSORS=8
FPS_BROWSER_USER_PROFILE_STRING=Default
PROCESSOR_LEVEL=6
WD=C:\Tools\MSYS\usr\bin\
TERM_PROGRAM_VERSION=3.6.3
MINGW_PREFIX=/mingw64
PKG_CONFIG_PATH=/mingw64/lib/pkgconfig:/mingw64/share/pkgconfig
USERDOMAIN_ROAMINGPROFILE=JDXPC
HOSTNAME=jdxpc
PROGRAMFILES=C:\Program Files
MSYSTEM=MINGW64
PATHEXT=.COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC
ORIGINAL_TEMP=/r/Users/jdx/AppData/Local/Temp
MINGW_CHOST=x86_64-w64-mingw32
OS=Windows_NT
HOMEDRIVE=D:
MSYSTEM_CARCH=x86_64
USERDOMAIN=JDXPC
PWD=/d/works/xcomp/gcc-build
USERPROFILE=D:\Users\jdx
MANPATH=/mingw64/local/man:/mingw64/share/man:/usr/local/man:/usr/share/man:/usr/man:/share/man
PRINTER=Microsoft Print to PDF
TZ=Europe/Warsaw
MINGW_PACKAGE_PREFIX=mingw-w64-x86_64
tmp=R:\Users\jdx\AppData\Local\Temp
ALLUSERSPROFILE=C:\ProgramData
ORIGINAL_PATH=/c/Windows/System32:/c/Windows:/c/Windows/System32/Wbem:/c/Windows/System32/WindowsPowerShell/v1.0/
CommonProgramW6432=C:\Program Files\Common Files
HOME=/home/jdx
USERNAME=jdx
VBOX_MSI_INSTALL_PATH=C:\Program Files\Oracle\VirtualBox\
OneDrive=D:\Users\jdx\OneDrive
COMSPEC=C:\Windows\system32\cmd.exe
APPDATA=D:\Users\jdx\AppData\Roaming
SYSTEMROOT=C:\Windows
LOCALAPPDATA=D:\Users\jdx\AppData\Local
PROMPT=$P$G
COMPUTERNAME=JDXPC
INFOPATH=/usr/local/info:/usr/share/info:/usr/info:/share/info
TERM=xterm
LOGONSERVER=\\JDXPC
ACLOCAL_PATH=/mingw64/share/aclocal:/usr/share/aclocal
USER=jdx
PSModulePath=C:\Program
Files\WindowsPowerShell\Modules;C:\Windows\system32\WindowsPowerShell\v1.0\Modules
TEMP=/r/Users/jdx/AppData/Local/Temp
temp=R:\Users\jdx\AppData\Local\Temp
MSYSTEM_CHOST=x86_64-w64-mingw32
ORIGINAL_TMP=/r/Users/jdx/AppData/Local/Temp
SHLVL=1
PROCESSOR_REVISION=3a09
DriverData=C:\Windows\System32\Drivers\DriverData
COMMONPROGRAMFILES=C:\Program Files\Common Files
CONICON=mingw64.ico
LC_CTYPE=en_US.UTF-8
PROCESSOR_IDENTIFIER=Intel64 Family 6 Model 58 Stepping 9, GenuineIntel
SESSIONNAME=Console
PS1=\[\e]0;\w\a\]\n\[\e[32m\]\u@\h \[\e[35m\]$MSYSTEM\[\e[0m\]
\[\e[33m\]\w\[\e[0m\]\n\$
PKG_CONFIG_SYSTEM_LIBRARY_PATH=/mingw64/lib
HOMEPATH=\Users\jdx
XDG_DATA_DIRS=/mingw64/share/:/usr/local/share/:/usr/share/
MSYSCON=mintty.exe
TMP=/r/Users/jdx/AppData/Local/Temp
CONFIG_SITE=/etc/config.site
PATH=/mingw64/bin:/mingw64/bin/site_perl/5.32.1:/mingw64/bin/vendor_perl:/mingw64/bin/core_perl:/usr/local/bin:/usr/bin:/bin:/c/Windows/System32:/c/Windows:/c/Windows/System32/Wbem:/c/Windows/System32/WindowsPowerShell/v1.0/
ProgramW6432=C:\Program Files
MSYSTEM_PREFIX=/mingw64
LOGINSHELL=bash
CONTITLE=MinGW x64
WINDIR=C:\Windows
FPS_BROWSER_APP_PROFILE_STRING=Internet Explorer
PROCESSOR_ARCHITECTURE=AMD64
PUBLIC=D:\Users\Public
PKG_CONFIG_SYSTEM_INCLUDE_PATH=/mingw64/include
SYSTEMDRIVE=C:
OLDPWD=/d/works/xcomp
TERM_PROGRAM=mintty
ProgramData=C:\ProgramData
_=/usr/bin/env

[Bug bootstrap/109188] Building genmodes under MinGW-W64/MSYS2 fails due to undefined HOST_EXTRA_OBJS_SYMBOL

[jdx at o2 dot pl]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109188

--- Comment #8 from Jan Dubiec <jdx at o2 dot pl> ---
Output of another important command:
$ uname -a
MINGW64_NT-10.0-19045 jdxpc 3.4.6.x86_64 2023-02-15 18:03 UTC x86_64 Msys

[Bug bootstrap/109188] Building genmodes under MinGW-W64/MSYS2 fails due to undefined HOST_EXTRA_OBJS_SYMBOL

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109188

--- Comment #9 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Can you change $(COMPILERS) to cc1 in gcc/config/i386/x-mingw32-utf8 and see if
that helps?

I am trying to see if the variable is not being defined before including the
make file fragment or not.

[Bug bootstrap/109188] Building genmodes under MinGW-W64/MSYS2 fails due to undefined HOST_EXTRA_OBJS_SYMBOL

[jdx at o2 dot pl]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109188

--- Comment #10 from Jan Dubiec <jdx at o2 dot pl> ---
(In reply to Andrew Pinski from comment #9)
> Can you change $(COMPILERS) to cc1 in gcc/config/i386/x-mingw32-utf8 and see
> if that helps?
I have changed it and I can confirm that genmodes.exe has been successfully
built. However, the compilation is still in progress so I am not able to tell
what the result of the whole process is.

[Bug bootstrap/109188] Building genmodes under MinGW-W64/MSYS2 fails due to undefined HOST_EXTRA_OBJS_SYMBOL

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109188

--- Comment #11 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
From Makefile.in:
# per-language makefile fragments
-include $(LANG_MAKEFRAGS)

# target and host overrides must follow the per-language makefile fragments
# so they can override or augment language-specific variables

# target overrides
-include $(tmake_file)

# host overrides
-include $(xmake_file)


Unless something is broken with make ...

[Bug bootstrap/109188] Building genmodes under MinGW-W64/MSYS2 fails due to undefined HOST_EXTRA_OBJS_SYMBOL

[jdx at o2 dot pl]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109188

--- Comment #12 from Jan Dubiec <jdx at o2 dot pl> ---
Yes, there is such a snippet in gcc/Makefile.in but I have completely no idea
what you mean.

[Bug bootstrap/109188] Building genmodes under MinGW-W64/MSYS2 fails due to undefined HOST_EXTRA_OBJS_SYMBOL

[jdx at o2 dot pl]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109188

--- Comment #13 from Jan Dubiec <jdx at o2 dot pl> ---
I have applied the patch posted yesterday on PR108865 and everything seems to
be fine.

[Bug bootstrap/109188] Building genmodes under MinGW-W64/MSYS2 fails due to undefined HOST_EXTRA_OBJS_SYMBOL

[costas.argyris at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109188

Costas Argyris <costas.argyris at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |costas.argyris at gmail dot com

--- Comment #14 from Costas Argyris <costas.argyris at gmail dot com> ---
Good to hear that the patch worked in this case as well.

Should we mark this as duplicate of 108865?

Some extra info:

I don't think the target is relevant here, as this was a host-specific change
for host == x86_64-w64-mingw32

Seems like we were asking the same question between this and 108865:

"LDFLAGS should have been only overridden for COMPILERS target."

Could it be that genmodes.exe simply copies the COMPILERS flags, whatever they
are, and assumes that it can just use them?

Since it does end up getting COMPILERS : LDFLAGS, I think the proposed patch in
108865 makes sense - just make the symbol optional, not mandatory, so that
these executables don't fail to build.    I don't see a downside in doing this,
and the actual compilers will still get to pull in the required object file
that gives them UTF-8 support.

[Bug bootstrap/109188] Building genmodes under MinGW-W64/MSYS2 fails due to undefined HOST_EXTRA_OBJS_SYMBOL

[costas.argyris at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109188

--- Comment #15 from Costas Argyris <costas.argyris at gmail dot com> ---
patch that makes symbol optional was pushed to master:

https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=08ef17c75777ef9e4e7ead132ccd7a6d03ae6020

[Bug bootstrap/109188] Building genmodes under MinGW-W64/MSYS2 fails due to undefined HOST_EXTRA_OBJS_SYMBOL

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109188

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #16 from Richard Biener <rguenth at gcc dot gnu.org> ---
duplicate

*** This bug has been marked as a duplicate of bug 108865 ***