[Bug libgcc/109282] New: Libgcc references sh and not $(SHELL) in Makefile.in

[Bug libgcc/109282] New: Libgcc references sh and not $(SHELL) in Makefile.in

[chrisj at rtems dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109282

            Bug ID: 109282
           Summary: Libgcc references sh and not $(SHELL) in Makefile.in
           Product: gcc
           Version: 12.2.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libgcc
          Assignee: unassigned at gcc dot gnu.org
          Reporter: chrisj at rtems dot org
  Target Milestone: ---

Created attachment 54753
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54753&action=edit
Change sh to $(SHELL)

The libgcc Makefile.in has `sh` and not `$(SHELL)` and that failed on MacOS
Ventura. The attached patch fixes the problem and builds an RTEMS crosscompiler
tool chain.

[Bug libgcc/109282] Libgcc references sh and not $(SHELL) in Makefile.in

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109282

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
move-if-change should work just fine with a normal POSIX shell ...

What is the error message with /bin/sh still there?

[Bug libgcc/109282] Libgcc references sh and not $(SHELL) in Makefile.in

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109282

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2023-03-26
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |WAITING

[Bug libgcc/109282] Libgcc references sh and not $(SHELL) in Makefile.in

[chrisj at rtems dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109282

--- Comment #2 from Chris Johns <chrisj at rtems dot org> ---
(In reply to Andrew Pinski from comment #1)
> move-if-change should work just fine with a normal POSIX shell ...

It does. Maybe it was not found?

> What is the error message with /bin/sh still there?

The error message was:

/bin/sh: line 1: 16562 Killed: 9               sh
../../../../gnu-mirror-gcc-cf59d86/libgcc/../move-if-change $dest
../../.././gcc/include/unwind.h

This is the only place in the file `sh` is directly referenced like this. I did
not look into this any further as `$(SHELL)` worked.

[Bug libgcc/109282] Libgcc references sh and not $(SHELL) in Makefile.in

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109282

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
https://developer.apple.com/forums/thread/701242

[Bug libgcc/109282] Libgcc references sh and not $(SHELL) in Makefile.in

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109282

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|---                         |WONTFIX

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
My bet if you do /bin/sh you would also get into trouble too ...

[Bug libgcc/109282] Libgcc references sh and not $(SHELL) in Makefile.in

[chrisj at rtems dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109282

--- Comment #5 from Chris Johns <chrisj at rtems dot org> ---
(In reply to Andrew Pinski from comment #4)
> My bet if you do /bin/sh you would also get into trouble too ...

I do not think it is /bin/sh but you are right with the link bring MacOS
blocking an exe that should not run and it was related to my path and my
mistake. Using make's $(SHELL) with an absolute path made the build ignore my
broken set up and more robust. Make uses:

build/libcc1/config.log:SHELL='/bin/sh'

I think the path as a clean up is a good things to have.