[Bug c/109304] New: ICE when building Python 3.12.0_alpha6 (internal compiler error: in get_vrange, at value-range-storage.cc:87)

[Bug c/109304] New: ICE when building Python 3.12.0_alpha6 (internal compiler error: in get_vrange, at value-range-storage.cc:87)

[sam at gentoo dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109304

            Bug ID: 109304
           Summary: ICE when building Python 3.12.0_alpha6 (internal
                    compiler error: in get_vrange, at
                    value-range-storage.cc:87)
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: sam at gentoo dot org
  Target Milestone: ---
              Host: x86_64-pc-linux-gnu
            Target: x86_64-pc-linux-gnu
             Build: x86_64-pc-linux-gnu

Created attachment 54771
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54771&action=edit
unicodeobject.i.xz

Just hit this with this week's gcc 13 (13.0.1 20230326). Last week's was fine.

```
$ x86_64-pc-linux-gnu-gcc -c ./unicodeobject.i -fprofile-generate -O3
-fno-semantic-interposition -fPIC
during GIMPLE pass: unswitch
Objects/unicodeobject.c: In function ‘_PyUnicode_XStrip’:
Objects/unicodeobject.c:11613:1: internal compiler error: in get_vrange, at
value-range-storage.cc:87
0x828a6f vrange_storage::get_vrange(void const*, vrange&, tree_node*)
       
/usr/src/debug/sys-devel/gcc-13.0.1_pre20230326/gcc-13-20230326/gcc/value-range-storage.cc:87
0x828a6f vrange_storage::get_vrange(void const*, vrange&, tree_node*)
       
/usr/src/debug/sys-devel/gcc-13.0.1_pre20230326/gcc-13-20230326/gcc/value-range-storage.cc:72
0x828a6f range_info_get_range(tree_node*, vrange&)
       
/usr/src/debug/sys-devel/gcc-13.0.1_pre20230326/gcc-13-20230326/gcc/tree-ssanames.cc:121
0x828a6f duplicate_ssa_name_range_info(tree_node*, tree_node*)
       
/usr/src/debug/sys-devel/gcc-13.0.1_pre20230326/gcc-13-20230326/gcc/tree-ssanames.cc:750
0x15ca96a duplicate_ssa_name_fn(function*, tree_node*, gimple*)
       
/usr/src/debug/sys-devel/gcc-13.0.1_pre20230326/gcc-13-20230326/gcc/tree-ssanames.cc:771
0x15ca96a duplicate_ssa_name(tree_node*, gimple*)
       
/usr/src/debug/sys-devel/gcc-13.0.1_pre20230326/gcc-13-20230326/gcc/tree-ssanames.h:115
0x15ca96a create_new_def_for(tree_node*, gimple*, tree_node**)
       
/usr/src/debug/sys-devel/gcc-13.0.1_pre20230326/gcc-13-20230326/gcc/tree-into-ssa.cc:3091
0x15c96cd gimple_duplicate_bb
       
/usr/src/debug/sys-devel/gcc-13.0.1_pre20230326/gcc-13-20230326/gcc/tree-cfg.cc:6555
0x15c8cd5 duplicate_block(basic_block_def*, edge_def*, basic_block_def*,
copy_bb_data*)
       
/usr/src/debug/sys-devel/gcc-13.0.1_pre20230326/gcc-13-20230326/gcc/cfghooks.cc:1117
0x15c84d2 copy_bbs(basic_block_def**, unsigned int, basic_block_def**,
edge_def**, unsigned int, edge_def**, loop*, basic_block_def*, bool)
       
/usr/src/debug/sys-devel/gcc-13.0.1_pre20230326/gcc-13-20230326/gcc/cfghooks.cc:1382
0x15fe319 duplicate_loop_body_to_header_edge(loop*, edge_def*, unsigned int,
simple_bitmap_def*, edge_def*, vec<edge_def*, va_heap, vl_ptr>*, int)
       
/usr/src/debug/sys-devel/gcc-13.0.1_pre20230326/gcc-13-20230326/gcc/cfgloopmanip.cc:1235
0x15fdc4b gimple_duplicate_loop_body_to_header_edge(loop*, edge_def*, unsigned
int, simple_bitmap_def*, edge_def*, vec<edge_def*, va_heap, vl_ptr>*, int)
       
/usr/src/debug/sys-devel/gcc-13.0.1_pre20230326/gcc-13-20230326/gcc/tree-ssa-loop-manip.cc:861
0x175c533 loop_version(loop*, void*, basic_block_def**, profile_probability,
profile_probability, profile_probability, profile_probability, bool)
       
/usr/src/debug/sys-devel/gcc-13.0.1_pre20230326/gcc-13-20230326/gcc/cfgloopmanip.cc:1630
0xcf6c7b tree_unswitch_loop
       
/usr/src/debug/sys-devel/gcc-13.0.1_pre20230326/gcc-13-20230326/gcc/tree-ssa-loop-unswitch.cc:1117
0xcf6c7b tree_unswitch_single_loop
       
/usr/src/debug/sys-devel/gcc-13.0.1_pre20230326/gcc-13-20230326/gcc/tree-ssa-loop-unswitch.cc:1055
0xcf85ed tree_ssa_unswitch_loops(function*)
       
/usr/src/debug/sys-devel/gcc-13.0.1_pre20230326/gcc-13-20230326/gcc/tree-ssa-loop-unswitch.cc:385
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
```

[Bug c/109304] ICE when building Python 3.12.0_alpha6 (internal compiler error: in get_vrange, at value-range-storage.cc:87)

[sam at gentoo dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109304

--- Comment #1 from Sam James <sam at gentoo dot org> ---
Created attachment 54772
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54772&action=edit
reduced.i

```
$ x86_64-pc-linux-gnu-gcc -c /tmp/reduced.i -fprofile-generate -O3
-fno-semantic-interposition -fPIC
/tmp/reduced.i:1:1: warning: data definition has no type or storage class
    1 | PyUnicode_FindChar_i;
      | ^~~~~~~~~~~~~~~~~~~~
/tmp/reduced.i:1:1: warning: type defaults to ‘int’ in declaration of
‘PyUnicode_FindChar_i’ [-Wimplicit-int]
/tmp/reduced.i:2:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
    2 | PyUnicode_FindChar() {
      | ^~~~~~~~~~~~~~~~~~
during GIMPLE pass: unswitch
/tmp/reduced.i: In function ‘PyUnicode_FindChar’:
/tmp/reduced.i:2:1: internal compiler error: in get_vrange, at
value-range-storage.cc:87
0x828a6f vrange_storage::get_vrange(void const*, vrange&, tree_node*)
       
/usr/src/debug/sys-devel/gcc-13.0.1_pre20230326/gcc-13-20230326/gcc/value-range-storage.cc:87
0x828a6f vrange_storage::get_vrange(void const*, vrange&, tree_node*)
       
/usr/src/debug/sys-devel/gcc-13.0.1_pre20230326/gcc-13-20230326/gcc/value-range-storage.cc:72
0x828a6f range_info_get_range(tree_node*, vrange&)
       
/usr/src/debug/sys-devel/gcc-13.0.1_pre20230326/gcc-13-20230326/gcc/tree-ssanames.cc:121
0x828a6f duplicate_ssa_name_range_info(tree_node*, tree_node*)
       
/usr/src/debug/sys-devel/gcc-13.0.1_pre20230326/gcc-13-20230326/gcc/tree-ssanames.cc:750
0x15ca96a duplicate_ssa_name_fn(function*, tree_node*, gimple*)
       
/usr/src/debug/sys-devel/gcc-13.0.1_pre20230326/gcc-13-20230326/gcc/tree-ssanames.cc:771
0x15ca96a duplicate_ssa_name(tree_node*, gimple*)
       
/usr/src/debug/sys-devel/gcc-13.0.1_pre20230326/gcc-13-20230326/gcc/tree-ssanames.h:115
0x15ca96a create_new_def_for(tree_node*, gimple*, tree_node**)
       
/usr/src/debug/sys-devel/gcc-13.0.1_pre20230326/gcc-13-20230326/gcc/tree-into-ssa.cc:3091
0x15c96cd gimple_duplicate_bb
       
/usr/src/debug/sys-devel/gcc-13.0.1_pre20230326/gcc-13-20230326/gcc/tree-cfg.cc:6555
0x15c8cd5 duplicate_block(basic_block_def*, edge_def*, basic_block_def*,
copy_bb_data*)
       
/usr/src/debug/sys-devel/gcc-13.0.1_pre20230326/gcc-13-20230326/gcc/cfghooks.cc:1117
0x15c842e copy_bbs(basic_block_def**, unsigned int, basic_block_def**,
edge_def**, unsigned int, edge_def**, loop*, basic_block_def*, bool)
       
/usr/src/debug/sys-devel/gcc-13.0.1_pre20230326/gcc-13-20230326/gcc/cfghooks.cc:1382
0x15fe319 duplicate_loop_body_to_header_edge(loop*, edge_def*, unsigned int,
simple_bitmap_def*, edge_def*, vec<edge_def*, va_heap, vl_ptr>*, int)
       
/usr/src/debug/sys-devel/gcc-13.0.1_pre20230326/gcc-13-20230326/gcc/cfgloopmanip.cc:1235
0x15fdc4b gimple_duplicate_loop_body_to_header_edge(loop*, edge_def*, unsigned
int, simple_bitmap_def*, edge_def*, vec<edge_def*, va_heap, vl_ptr>*, int)
       
/usr/src/debug/sys-devel/gcc-13.0.1_pre20230326/gcc-13-20230326/gcc/tree-ssa-loop-manip.cc:861
0x175c533 loop_version(loop*, void*, basic_block_def**, profile_probability,
profile_probability, profile_probability, profile_probability, bool)
       
/usr/src/debug/sys-devel/gcc-13.0.1_pre20230326/gcc-13-20230326/gcc/cfgloopmanip.cc:1630
0xcf6c7b tree_unswitch_loop
       
/usr/src/debug/sys-devel/gcc-13.0.1_pre20230326/gcc-13-20230326/gcc/tree-ssa-loop-unswitch.cc:1117
0xcf6c7b tree_unswitch_single_loop
       
/usr/src/debug/sys-devel/gcc-13.0.1_pre20230326/gcc-13-20230326/gcc/tree-ssa-loop-unswitch.cc:1055
0xcf85ed tree_ssa_unswitch_loops(function*)
       
/usr/src/debug/sys-devel/gcc-13.0.1_pre20230326/gcc-13-20230326/gcc/tree-ssa-loop-unswitch.cc:385
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://bugs.gentoo.org/> for instructions.
```

[Bug tree-optimization/109304] ICE when building Python 3.12.0_alpha6 (internal compiler error: in get_vrange, at value-range-storage.cc:87)

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109304

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-valid-code
   Target Milestone|---                         |13.0
          Component|c                           |tree-optimization

[Bug tree-optimization/109304] ICE when building Python 3.12.0_alpha6 (internal compiler error: in get_vrange, at value-range-storage.cc:87)

[sam at gentoo dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109304

--- Comment #2 from Sam James <sam at gentoo dot org> ---
Good: 13.0.1 20230319
Bad: 13.0.1 20230326

I'll bisect now but someone is free to beat me.

[Bug tree-optimization/109304] [13 Regression] ICE when building Python 3.12.0_alpha6 (internal compiler error: in get_vrange, at value-range-storage.cc:87) since r13-6849-ged626f18b189920a

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109304

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
                 CC|                            |marxin at gcc dot gnu.org,
                   |                            |rguenth at gcc dot gnu.org
   Last reconfirmed|                            |2023-03-27
            Summary|ICE when building Python    |[13 Regression] ICE when
                   |3.12.0_alpha6 (internal     |building Python
                   |compiler error: in          |3.12.0_alpha6 (internal
                   |get_vrange, at              |compiler error: in
                   |value-range-storage.cc:87)  |get_vrange, at
                   |                            |value-range-storage.cc:87)
                   |                            |since
                   |                            |r13-6849-ged626f18b189920a
           Priority|P3                          |P1

--- Comment #3 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r13-6849-ged626f18b189920a.

[Bug tree-optimization/109304] [13 Regression] ICE when building Python 3.12.0_alpha6 (internal compiler error: in get_vrange, at value-range-storage.cc:87) since r13-6849-ged626f18b189920a

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109304

--- Comment #4 from Martin Liška <marxin at gcc dot gnu.org> ---
A bit clean-up test-case:

int PyUnicode_FindChar_i;
int PyUnicode_FindChar() {
  while (PyUnicode_FindChar_i)
    if (PyUnicode_FindChar())
      break;
}

[Bug tree-optimization/109304] [13 Regression] ICE in get_vrange, at value-range-storage.cc:87 when building Python 3.12.0_alpha6 since r13-6849-ged626f18b189920a

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109304

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
I will have a look.

[Bug tree-optimization/109304] [13 Regression] ICE in get_vrange, at value-range-storage.cc:87 when building Python 3.12.0_alpha6 since r13-6849-ged626f18b189920a

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109304

--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
Early IPA visibility introduces a local alias (because of
-fno-semantic-interposition).  Local IPA pure-const makes PyUnicode_FindChar
looping pure.
IPA profile instruments the functions, but the .localalias () call remains
pure.

The issue is that node->set_pure_flag uses call_for_symbol_thunks_and_aliases
to apply the adjustments but the call adjustment now no longer updates all
stmts but uses the same guard

        if (!gimple_has_body_p (node->decl)
            || !(!node->clone_of
            || node->decl != node->clone_of->decl))
          continue;

(or rather just gimple_has_body_p), skipping updating the stmt.  For const
calls that would leave the const on the fntype, for pure calls as here
this leaves the call not updated.

We can either restore unconditional updating of all calls or fix the original
issue also for const calls to aliases by adjusting the check.  Maybe like

                /* We do not clear pure/const on decls without body.  */
                tree fndecl = gimple_call_fndecl (call);
                cgraph_node *callee;
                if (fndecl
                    && (callee = cgraph_node::get (fndecl))
                    && callee->get_availability (node) == AVAIL_NOT_AVAILABLE)
                  continue;

that works, but not sure if by design.  Will test that.

[Bug tree-optimization/109304] [13 Regression] ICE in get_vrange, at value-range-storage.cc:87 when building Python 3.12.0_alpha6 since r13-6849-ged626f18b189920a

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109304

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Liska <marxin@gcc.gnu.org>:

https://gcc.gnu.org/g:d0b961b802dd7d9d555ff4515835a479329326e9

commit r13-6995-gd0b961b802dd7d9d555ff4515835a479329326e9
Author: Richard Biener <rguenther@suse.de>
Date:   Tue Mar 28 08:06:12 2023 +0000

    tree-optimization/109304 - properly handle instrumented aliases

    When adjusting calls to reflect instrumentation we failed to handle
    calls to aliases since they appear to have no body.  Instead resort
    to symtab node availability.  The patch also avoids touching
    internal function calls in a more obvious way (builtins might
    have a body available).

    profiledbootstrap & regtest running on x86_64-unknown-linux-gnu.

    Honza - does this look OK?

            PR tree-optimization/109304
            * tree-profile.cc (tree_profiling): Use symtab node
            availability to decide whether to skip adjusting calls.
            Do not adjust calls to internal functions.

            * gcc.dg/pr109304.c: New testcase.

[Bug tree-optimization/109304] [13 Regression] ICE in get_vrange, at value-range-storage.cc:87 when building Python 3.12.0_alpha6 since r13-6849-ged626f18b189920a

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109304

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Martin Liška <marxin at gcc dot gnu.org> ---
Fixed.