[Bug modula2/109336] New: The -fmod= and -fdef= options do not work.

[Bug modula2/109336] New: The -fmod= and -fdef= options do not work.

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109336

            Bug ID: 109336
           Summary: The -fmod= and -fdef= options do not work.
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: modula2
          Assignee: gaius at gcc dot gnu.org
          Reporter: gaius at gcc dot gnu.org
  Target Milestone: ---

The -fmod= and -fdef= options do not work.  After the linking re-implementation
and subsequent restructuring the -fmod= amd -fdef= are now broken.

[Bug modula2/109336] The -fmod= and -fdef= options do not work.

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109336

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2023-03-29

[Bug modula2/109336] The -fmod= and -fdef= options do not work.

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109336

--- Comment #1 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Gaius Mulley <gaius@gcc.gnu.org>:

https://gcc.gnu.org/g:3be4e43a6a0f429648ea188c8e110b74268fed27

commit r13-6931-g3be4e43a6a0f429648ea188c8e110b74268fed27
Author: Gaius Mulley <gaiusmod2@gmail.com>
Date:   Wed Mar 29 17:38:22 2023 +0100

    PR modula2/109336 - The -fmod= and -fdef= options do not work

    The -fmod= and -fdef= options do not work.  After the linking
    re-implementation and subsequent restructuring the -fmod= amd -fdef= are
    now broken.  This patch adds -fmod= and -fdef= processing into gm2spec.cc.
    It also reduces the complexity of extension handling within M2Search
    by storing the preceeding "." in the extension.

    gcc/m2/ChangeLog:

            PR modula2/109336
            PR modula2/109315
            * gm2-compiler/M2FileName.mod (CalculateFileName): Simplified by
            ensuring the extension contains the ".".
            (CalculateStemName): Re-formatted.
            (ExtractExtension): Re-formatted.
            (ExtractModule): Re-formatted.
            * gm2-compiler/M2Options.def (setdefextension): Add block comment.
            (setmodextension): Add block comment.  Re-formatted.
            * gm2-compiler/M2Options.mod (setdefextension): Add block comment.
            (setmodextension): Add block comment.  Re-formatted.
            * gm2-compiler/M2Search.mod (FindSourceDefFile): Use
            DefaultDefExt.
            (DefaultDefExt): New constant.
            (DefaultModExt): New constant.
            (FindSourceModFile): Use DefaultModExt.
            * gm2-gcc/m2decl.cc (m2decl_DeclareKnownVariable): Correct
            spelling.
            * gm2spec.cc (M2SOURCE): New constant.
            (LANGSPEC): New value.
            (MATHLIB): New value.
            (WITHLIBC): New value.
            (SKIPOPT): New value.
            (lang_specific_driver): Replace seen_module_extension bool with
            module_extension char *.  Detect -fmod= and remember extension.
            Use the extension to detect modula-2 source and mark it as such.

    gcc/testsuite/ChangeLog:

            PR modula2/109336
            * gm2/link/nondefaultext/pass/hello.md: New test.
            * gm2/link/nondefaultext/pass/liba.dm: New test.
            * gm2/link/nondefaultext/pass/liba.md: New test.
            * gm2/link/nondefaultext/pass/link-nondefaultext-pass.exp: New
test.

    Signed-off-by: Gaius Mulley <gaiusmod2@gmail.com>

[Bug modula2/109336] The -fmod= and -fdef= options do not work.

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109336

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Closing as a patch has been applied.

[Bug modula2/109336] The -fmod= and -fdef= options do not work.

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109336

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Gaius Mulley <gaius@gcc.gnu.org>:

https://gcc.gnu.org/g:5bb27a1bb2f1c0533e1dda6c4a326e50756830f1

commit r13-6976-g5bb27a1bb2f1c0533e1dda6c4a326e50756830f1
Author: Gaius Mulley <gaiusmod2@gmail.com>
Date:   Sun Apr 2 20:30:43 2023 +0100

    PR modula2/109336 pass -fmod= though and build m2/stage2/cc1gm2 libs

    This patch enables gm2 to pass -fmod= though to cc1gm2.  It also
    builds the libraries for m2/stage2/cc1gm2 with no named path and
    full debugging.

    gcc/m2/ChangeLog:

            PR modula2/109336
            * Make-lang.in (GM2_O): Set to -O0.
            (GM2_LIBS): Remove target libraries and replace with build libs.
            (BUILD-LIBS): New declaration.
            (m2/gm2-libs/libgm2.a): New rule.
            (m2/gm2-libs/%.o): New rule.
            (m2/gm2-libs/choosetemp.o): New rule.
            * gm2-compiler/M2ColorString.mod (append): Use ADR rather than
            implicit conversion.
            * gm2-compiler/M2Comp.mod (Compile): Add qprintf messages for when
            a source file is not found.  Improve comments and formatting.
            * gm2-libs-ch/cgetopt.c (cgetopt_cgetopt_long): Remove
            ansi-decl.h.  Add getopt.h.
            (cgetopt_cgetopt_long_only): Change cgetopt_ to getopt_.
            * gm2spec.cc (lang_specific_driver): Do not skip -fmod=.
            Remove comment.

    Signed-off-by: Gaius Mulley <gaiusmod2@gmail.com>