public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/109359] [12/13 Regression] Compile-time rounding of double literal to float is incorrect with -frounding-math Date: Mon, 05 Feb 2024 22:25:10 +0000 [thread overview] Message-ID: <bug-109359-4-ZhdyT3QQBa@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-109359-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109359 --- Comment #12 from GCC Commits <cvs-commit at gcc dot gnu.org> --- The releases/gcc-12 branch has been updated by Jason Merrill <jason@gcc.gnu.org>: https://gcc.gnu.org/g:470f501f31a4bdb9fa04c691ca7db2915ac3ae5b commit r12-10136-g470f501f31a4bdb9fa04c691ca7db2915ac3ae5b Author: Jason Merrill <jason@redhat.com> Date: Thu Jun 1 14:41:07 2023 -0400 varasm: check float size [PR109359] In PR95226, the testcase was failing because we tried to output_constant a NOP_EXPR to float from a double REAL_CST, and so we output a double where the caller wanted a float. That doesn't happen anymore, but with the output_constant hunk we will ICE in that situation rather than emit the wrong number of bytes. Part of the problem was that initializer_constant_valid_p_1 returned true for that NOP_EXPR, because it compared the sizes of integer types but not floating-point types. So the C++ front end assumed it didn't need to fold the initializer. This also fixed the test for PR109359. PR c++/95226 PR c++/109359 gcc/ChangeLog: * varasm.cc (output_constant) [REAL_TYPE]: Check that sizes match. (initializer_constant_valid_p_1): Compare float precision. gcc/testsuite/ChangeLog: * g++.dg/ext/frounding-math1.C: New test. (cherry picked from commit e7cc4d703bceb9095316c106eba0d1939c6c8044)
next prev parent reply other threads:[~2024-02-05 22:25 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-31 12:33 [Bug c++/109359] New: " rcopley at gmail dot com 2023-03-31 13:23 ` [Bug c++/109359] [12/13 Regression] " rguenth at gcc dot gnu.org 2023-03-31 13:36 ` jakub at gcc dot gnu.org 2023-03-31 14:23 ` jakub at gcc dot gnu.org 2023-04-14 9:49 ` rguenth at gcc dot gnu.org 2023-04-14 10:03 ` jakub at gcc dot gnu.org 2023-04-14 10:08 ` rguenth at gcc dot gnu.org 2023-04-14 10:12 ` jakub at gcc dot gnu.org 2023-05-08 12:26 ` [Bug c++/109359] [12/13/14 " rguenth at gcc dot gnu.org 2024-02-05 18:24 ` jason at gcc dot gnu.org 2024-02-05 18:34 ` [Bug c++/109359] [12/13 " jason at gcc dot gnu.org 2024-02-05 18:47 ` jakub at gcc dot gnu.org 2024-02-05 18:55 ` jason at gcc dot gnu.org 2024-02-05 21:35 ` cvs-commit at gcc dot gnu.org 2024-02-05 22:25 ` cvs-commit at gcc dot gnu.org [this message] 2024-02-05 22:25 ` cvs-commit at gcc dot gnu.org 2024-02-05 22:26 ` jason at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-109359-4-ZhdyT3QQBa@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).