public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/109410] [13 Regression] ICE: verify_flow_info failed
Date: Sun, 23 Apr 2023 04:11:32 +0000	[thread overview]
Message-ID: <bug-109410-4-H2G70gsCPs@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-109410-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109410

--- Comment #14 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #13)
> So the testcase gcc.dg/pr109410.c passes but if you add -g, the ICE will
> show up still.
> 
> This also means there will be some compare-debug failure too as the IR/CFG
> will be different with/without -g.
> 
> I suspect gsi_after_labels here should really be
> gsi_start_nondebug_after_labels_bb .

That is:
diff --git a/gcc/tree-ssa-reassoc.cc b/gcc/tree-ssa-reassoc.cc
index 067a3f07f7e..c71780e6d54 100644
--- a/gcc/tree-ssa-reassoc.cc
+++ b/gcc/tree-ssa-reassoc.cc
@@ -1563,7 +1563,7 @@ build_and_add_sum (tree type, tree op1, tree op2, enum
tree_code opcode)
   if ((!op1def || gimple_nop_p (op1def))
       && (!op2def || gimple_nop_p (op2def)))
     {
-      gsi = gsi_after_labels (single_succ (ENTRY_BLOCK_PTR_FOR_FN (cfun)));
+      gsi = gsi_start_nondebug_after_labels_bb (single_succ
(ENTRY_BLOCK_PTR_FOR_FN (cfun)));
       if (!gsi_end_p (gsi)
          && is_gimple_call (gsi_stmt (gsi))
          && (gimple_call_flags (gsi_stmt (gsi)) & ECF_RETURNS_TWICE))

  parent reply	other threads:[~2023-04-23  4:11 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-04 16:10 [Bug c/109410] New: " gscfq@t-online.de
2023-04-04 20:50 ` [Bug tree-optimization/109410] " pinskia at gcc dot gnu.org
2023-04-04 20:53 ` pinskia at gcc dot gnu.org
2023-04-04 20:58 ` pinskia at gcc dot gnu.org
2023-04-11 12:31 ` rguenth at gcc dot gnu.org
2023-04-11 14:33 ` jakub at gcc dot gnu.org
2023-04-12  5:00 ` sjames at gcc dot gnu.org
2023-04-12 14:55 ` cvs-commit at gcc dot gnu.org
2023-04-12 14:58 ` jakub at gcc dot gnu.org
2023-04-18  7:16 ` cvs-commit at gcc dot gnu.org
2023-04-22 12:41 ` dcb314 at hotmail dot com
2023-04-22 12:58 ` sjames at gcc dot gnu.org
2023-04-23  2:45 ` sjames at gcc dot gnu.org
2023-04-23  3:58 ` sjames at gcc dot gnu.org
2023-04-23  4:07 ` pinskia at gcc dot gnu.org
2023-04-23  4:11 ` pinskia at gcc dot gnu.org [this message]
2023-04-26  6:58 ` [Bug tree-optimization/109410] [13/14 " rguenth at gcc dot gnu.org
2023-05-02 20:16 ` cvs-commit at gcc dot gnu.org
2023-05-03 15:23 ` cvs-commit at gcc dot gnu.org
2023-07-27  9:25 ` rguenth at gcc dot gnu.org
2024-05-21  9:14 ` [Bug tree-optimization/109410] [13/14/15 " jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-109410-4-H2G70gsCPs@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).