public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/109410] [13 Regression] ICE: verify_flow_info failed
Date: Wed, 12 Apr 2023 14:55:47 +0000	[thread overview]
Message-ID: <bug-109410-4-gkZkco30DF@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-109410-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109410

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:51856718a82ce60f067910d9037ca255645b37eb

commit r13-7155-g51856718a82ce60f067910d9037ca255645b37eb
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Apr 12 16:55:15 2023 +0200

    reassoc: Fix up another ICE with returns_twice call [PR109410]

    The following testcase ICEs in reassoc, unlike the last case I've fixed
    there here SSA_NAME_USED_IN_ABNORMAL_PHI is not the case anywhere.
    build_and_add_sum places new statements after the later appearing
definition
    of an operand but if both operands are default defs or constants, we place
    statement at the start of the function.

    If the very first statement of a function is a call to returns_twice
    function, this doesn't work though, because that call has to be the first
    thing in its basic block, so the following patch splits the entry successor
    edge such that the new statements are added into a different block from the
    returns_twice call.

    I think we should in stage1 reconsider such placements, I think it
    unnecessarily enlarges the lifetime of the new lhs if its operand(s)
    are used more than once in the function.  Unless something sinks those
    again.  Would be nice to place it closer to the actual uses (or where
    they will be placed).

    2023-04-12  Jakub Jelinek  <jakub@redhat.com>

            PR tree-optimization/109410
            * tree-ssa-reassoc.cc (build_and_add_sum): Split edge from entry
            block if first statement of the function is a call to returns_twice
            function.

            * gcc.dg/pr109410.c: New test.

  parent reply	other threads:[~2023-04-12 14:55 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-04 16:10 [Bug c/109410] New: " gscfq@t-online.de
2023-04-04 20:50 ` [Bug tree-optimization/109410] " pinskia at gcc dot gnu.org
2023-04-04 20:53 ` pinskia at gcc dot gnu.org
2023-04-04 20:58 ` pinskia at gcc dot gnu.org
2023-04-11 12:31 ` rguenth at gcc dot gnu.org
2023-04-11 14:33 ` jakub at gcc dot gnu.org
2023-04-12  5:00 ` sjames at gcc dot gnu.org
2023-04-12 14:55 ` cvs-commit at gcc dot gnu.org [this message]
2023-04-12 14:58 ` jakub at gcc dot gnu.org
2023-04-18  7:16 ` cvs-commit at gcc dot gnu.org
2023-04-22 12:41 ` dcb314 at hotmail dot com
2023-04-22 12:58 ` sjames at gcc dot gnu.org
2023-04-23  2:45 ` sjames at gcc dot gnu.org
2023-04-23  3:58 ` sjames at gcc dot gnu.org
2023-04-23  4:07 ` pinskia at gcc dot gnu.org
2023-04-23  4:11 ` pinskia at gcc dot gnu.org
2023-04-26  6:58 ` [Bug tree-optimization/109410] [13/14 " rguenth at gcc dot gnu.org
2023-05-02 20:16 ` cvs-commit at gcc dot gnu.org
2023-05-03 15:23 ` cvs-commit at gcc dot gnu.org
2023-07-27  9:25 ` rguenth at gcc dot gnu.org
2024-05-21  9:14 ` [Bug tree-optimization/109410] [13/14/15 " jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-109410-4-gkZkco30DF@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).