[Bug libgomp/109664] New: Deadlocks with gomp_fatal called from libgomp/plugins/

[Bug libgomp/109664] New: Deadlocks with gomp_fatal called from libgomp/plugins/

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109664

            Bug ID: 109664
           Summary: Deadlocks with gomp_fatal called from libgomp/plugins/
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libgomp
          Assignee: unassigned at gcc dot gnu.org
          Reporter: burnus at gcc dot gnu.org
                CC: jakub at gcc dot gnu.org
  Target Milestone: ---

See thread starting at:
https://gcc.gnu.org/pipermail/gcc-patches/2022-October/603616.html


Issue:

Fatal errors inside mutex-locked regions (i.e. basically anything in the
plugin) will cause it to hang up trying to take the lock to clean everything
up.


Possible solutions:

would be not use gomp_fatal from within the
plugins, but use gomp_error instead and through possibly adjusted plugin
APIs tell libgomp that there was a fatal error and let libgomp unlock
anything that needs unlocking and exit (EXIT_FAILURE); afterwards.


another possibility would be not use gomp_fatal from within the
plugins, but use gomp_error instead and through possibly adjusted plugin
APIs tell libgomp that there was a fatal error and let libgomp unlock
anything that needs unlocking and exit (EXIT_FAILURE); afterwards.

[Bug libgomp/109664] Deadlocks with gomp_fatal called from libgomp/plugins/

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109664

--- Comment #1 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Once done, we might want to change some error propagation from a chain of
boolean-returning functions to just GOMP_PLUGIN_fatal – or not.

Cf. for instance:
https://gcc.gnu.org/pipermail/gcc-patches/2023-April/616992.html