[Bug sanitizer/109674] New: [14 Regression] linking with libhwasan is now broken

[Bug sanitizer/109674] New: [14 Regression] linking with libhwasan is now broken

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109674

            Bug ID: 109674
           Summary: [14 Regression] linking with libhwasan is now broken
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Keywords: link-failure
          Severity: normal
          Priority: P3
         Component: sanitizer
          Assignee: unassigned at gcc dot gnu.org
          Reporter: pinskia at gcc dot gnu.org
                CC: dodji at gcc dot gnu.org, dvyukov at gcc dot gnu.org,
                    jakub at gcc dot gnu.org, kcc at gcc dot gnu.org, marxin at gcc dot gnu.org
  Target Milestone: ---
            Target: aarch64

After the sanitizer merge, all of the hwsasan testcases are failing with a link
failure:

/bajas/pinskia/src/upstream-gcc-aarch64/gcc/objdir/aarch64-unknown-linux-gnu/./libsanitizer/hwasan/.libs/libhwasan.so:
undefined reference to `__lsan::HasReportedLeaks()'^M
/bajas/pinskia/src/upstream-gcc-aarch64/gcc/objdir/aarch64-unknown-linux-gnu/./libsanitizer/hwasan/.libs/libhwasan.so:
undefined reference to `__lsan::DoLeakCheck()'^M
/bajas/pinskia/src/upstream-gcc-aarch64/gcc/objdir/aarch64-unknown-linux-gnu/./libsanitizer/hwasan/.libs/libhwasan.so:
undefined reference to `__lsan::DisableInThisThread()'^M
/bajas/pinskia/src/upstream-gcc-aarch64/gcc/objdir/aarch64-unknown-linux-gnu/./libsanitizer/hwasan/.libs/libhwasan.so:
undefined reference to `__lsan::DisabledInThisThread()'^M
/bajas/pinskia/src/upstream-gcc-aarch64/gcc/objdir/aarch64-unknown-linux-gnu/./libsanitizer/hwasan/.libs/libhwasan.so:
undefined reference to `__lsan::DoRecoverableLeakCheckVoid()'^M
/bajas/pinskia/src/upstream-gcc-aarch64/gcc/objdir/aarch64-unknown-linux-gnu/./libsanitizer/hwasan/.libs/libhwasan.so:
undefined reference to `__lsan::EnableInThisThread()'^M
/bajas/pinskia/src/upstream-gcc-aarch64/gcc/objdir/aarch64-unknown-linux-gnu/./libsanitizer/hwasan/.libs/libhwasan.so:
undefined reference to `__lsan::Flags::SetDefaults()'^M
/bajas/pinskia/src/upstream-gcc-aarch64/gcc/objdir/aarch64-unknown-linux-gnu/./libsanitizer/hwasan/.libs/libhwasan.so:
undefined reference to `__lsan::InitCommonLsan()'^M
/bajas/pinskia/src/upstream-gcc-aarch64/gcc/objdir/aarch64-unknown-linux-gnu/./libsanitizer/hwasan/.libs/libhwasan.so:
undefined reference to `__lsan::RegisterLsanFlags(__sanitizer::FlagParser*,
__lsan::Flags*)'^M
/bajas/pinskia/src/upstream-gcc-aarch64/gcc/objdir/aarch64-unknown-linux-gnu/./libsanitizer/hwasan/.libs/libhwasan.so:
undefined reference to `__lsan::lsan_flags'^M

[Bug sanitizer/109674] [14 Regression] linking with libhwasan is now broken

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109674

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |14.0

[Bug sanitizer/109674] [14 Regression] linking with libhwasan is now broken

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109674

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |INVALID

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
I've just built libsanitizer on an aarch64 with revision
g:2744dbb9ecf104a113da3a0f39115da4653bb676 and it's fine:

file libsanitizer/hwasan/.libs/libhwasan.so.0.0.0
libsanitizer/hwasan/.libs/libhwasan.so.0.0.0: ELF 64-bit LSB shared object, ARM
aarch64, version 1 (SYSV), dynamically linked, with debug_info, not stripped

[Bug sanitizer/109674] [14 Regression] linking with libhwasan is now broken

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109674

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|INVALID                     |---
             Status|RESOLVED                    |UNCONFIRMED

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Martin Liška from comment #1)
> I've just built libsanitizer on an aarch64 with revision
> g:2744dbb9ecf104a113da3a0f39115da4653bb676 and it's fine:
> 
> file libsanitizer/hwasan/.libs/libhwasan.so.0.0.0
> libsanitizer/hwasan/.libs/libhwasan.so.0.0.0: ELF 64-bit LSB shared object,
> ARM aarch64, version 1 (SYSV), dynamically linked, with debug_info, not
> stripped

The link failure was while running the testsuite and linking against libhwasan;
NOT while linking libhwasan.

[Bug sanitizer/109674] [14 Regression] linking with libhwasan is now broken

[schwab@linux-m68k.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109674

--- Comment #3 from Andreas Schwab <schwab@linux-m68k.org> ---
The __lsan symbols are defined in liblsan, but only as local symbols.

[Bug sanitizer/109674] [14 Regression] linking with libhwasan is now broken

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109674

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2023-04-30
           Assignee|unassigned at gcc dot gnu.org      |marxin at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #4 from Martin Liška <marxin at gcc dot gnu.org> ---
Oh, now I can reproduce it.

[Bug sanitizer/109674] [14 Regression] linking with libhwasan is now broken

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109674

--- Comment #5 from Martin Liška <marxin at gcc dot gnu.org> ---
The solution is probably very similar to libasan library where also __lsan
symbols are used and where we link against ../lsan/.libs/libsanitizer_lsan.a.

[Bug sanitizer/109674] [14 Regression] linking with libhwasan is now broken

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109674

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Liska <marxin@gcc.gnu.org>:

https://gcc.gnu.org/g:54765c875a0ec961e06d56d916d9ad1ddfc3b221

commit r14-359-g54765c875a0ec961e06d56d916d9ad1ddfc3b221
Author: Martin Liska <mliska@suse.cz>
Date:   Sun Apr 30 21:28:15 2023 +0200

    libsanitizer: link hwasan against lsan library

    Similarly to libasan.so, libhwasan.so also utilizes some
    of the symbols from lsan library.

            PR sanitizer/109674

    libsanitizer/ChangeLog:

            * hwasan/Makefile.am: Depend on liblsan.
            * hwasan/Makefile.in: Re-generate.

[Bug sanitizer/109674] [14 Regression] linking with libhwasan is now broken

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109674

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Martin Liška <marxin at gcc dot gnu.org> ---
Fixed now. There are some hwasan test-suite failures that I'm going to fix
soon.