public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug d/109681] New: suggested preview switches use DMD
@ 2023-04-29 17:32 schveiguy at gmail dot com
  2024-03-17 16:44 ` [Bug d/109681] suggested preview switches use DMD preview flags ibuclaw at gdcproject dot org
  0 siblings, 1 reply; 2+ messages in thread
From: schveiguy at gmail dot com @ 2023-04-29 17:32 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109681

            Bug ID: 109681
           Summary: suggested preview switches use DMD
           Product: gcc
           Version: 13.1.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: d
          Assignee: ibuclaw at gdcproject dot org
          Reporter: schveiguy at gmail dot com
  Target Milestone: ---

When you use features that require preview switches, the messages that inform
you of the need to use the switch are worded using DMD frontend style switches.

For example:

```d
struct S {
   int x : 5;
}
```

Result:
```
<source>:3:14: error: use -preview=bitfields for bitfield support
    3 |     int x : 5;
      |              ^
```

What it should say is:

```
<source>:3:14: error: use -fpreview=bitfields for bitfield support
    3 |     int x : 5;
      |              ^
```

I searched for `-preview=` in the source, and found these instances:

https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=gcc/d/dmd/parse.d;h=36a76f50da20590abc9560533b1901b1258ad00b;hb=HEAD#l1236

https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=gcc/d/dmd/parse.d;h=36a76f50da20590abc9560533b1901b1258ad00b;hb=HEAD#l1252

https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=gcc/d/dmd/parse.d;h=36a76f50da20590abc9560533b1901b1258ad00b;hb=HEAD#l4614

https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=gcc/d/dmd/parse.d;h=36a76f50da20590abc9560533b1901b1258ad00b;hb=HEAD#l5148

There may be more.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [Bug d/109681] suggested preview switches use DMD preview flags
  2023-04-29 17:32 [Bug d/109681] New: suggested preview switches use DMD schveiguy at gmail dot com
@ 2024-03-17 16:44 ` ibuclaw at gdcproject dot org
  0 siblings, 0 replies; 2+ messages in thread
From: ibuclaw at gdcproject dot org @ 2024-03-17 16:44 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109681

Iain Buclaw <ibuclaw at gdcproject dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #1 from Iain Buclaw <ibuclaw at gdcproject dot org> ---
For now, upstream has version condition around the error messages to give the
gdc-style option names if version(IN_GCC).

https://github.com/dlang/dmd/pull/15747

Downstreamed into mainline since r14-5083.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-03-17 16:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-29 17:32 [Bug d/109681] New: suggested preview switches use DMD schveiguy at gmail dot com
2024-03-17 16:44 ` [Bug d/109681] suggested preview switches use DMD preview flags ibuclaw at gdcproject dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).