public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/109741] alignas(64) in libstdc++-v3/src/c++11/shared_ptr.cc
Date: Thu, 29 Jun 2023 23:01:15 +0000 [thread overview]
Message-ID: <bug-109741-4-HGTUbo5jMO@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-109741-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109741
--- Comment #17 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:
https://gcc.gnu.org/g:dbd4acd72274f3b3d542ebf68f9962eda8f8b769
commit r13-7509-gdbd4acd72274f3b3d542ebf68f9962eda8f8b769
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Tue May 16 15:09:20 2023 +0100
libstdc++: Disable cacheline alignment for DJGPP [PR109741]
DJGPP (and maybe other targets) uses MAX_OFILE_ALIGNMENT=16 which means
that globals (and static objects) can't have alignment greater than 16.
This causes an error for the locks defined in src/c++11/shared_ptr.cc
because we try to align them to the cacheline size, to avoid false
sharing.
Add a configure check for the increased alignment, and live with false
sharing where we can't increase the alignment.
libstdc++-v3/ChangeLog:
PR libstdc++/109741
* acinclude.m4 (GLIBCXX_CHECK_ALIGNAS_CACHELINE): Define.
* config.h.in: Regenerate.
* configure: Regenerate.
* configure.ac: Use GLIBCXX_CHECK_ALIGNAS_CACHELINE.
* src/c++11/shared_ptr.cc (__gnu_internal::get_mutex): Do not
align lock table if not supported. use __GCC_DESTRUCTIVE_SIZE
instead of hardcoded 64.
(cherry picked from commit 94a311abf783de754f0f1b2d4c1f00a9788e795b)
prev parent reply other threads:[~2023-06-29 23:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-04 17:30 [Bug libstdc++/109741] New: " janezz55 at gmail dot com
2023-05-04 17:38 ` [Bug libstdc++/109741] " janezz55 at gmail dot com
2023-05-04 17:39 ` pinskia at gcc dot gnu.org
2023-05-04 17:40 ` pinskia at gcc dot gnu.org
2023-05-04 17:42 ` pinskia at gcc dot gnu.org
2023-05-04 17:58 ` janezz55 at gmail dot com
2023-05-04 18:02 ` pinskia at gcc dot gnu.org
2023-05-04 18:05 ` pinskia at gcc dot gnu.org
2023-05-04 18:10 ` janezz55 at gmail dot com
2023-05-04 18:14 ` jakub at gcc dot gnu.org
2023-05-04 18:17 ` redi at gcc dot gnu.org
2023-05-04 18:19 ` redi at gcc dot gnu.org
2023-05-04 18:31 ` jakub at gcc dot gnu.org
2023-05-04 19:30 ` janezz55 at gmail dot com
2023-05-04 20:18 ` redi at gcc dot gnu.org
2023-05-16 17:31 ` cvs-commit at gcc dot gnu.org
2023-05-16 17:33 ` redi at gcc dot gnu.org
2023-05-16 17:33 ` redi at gcc dot gnu.org
2023-06-29 23:01 ` cvs-commit at gcc dot gnu.org [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-109741-4-HGTUbo5jMO@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).