public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug libstdc++/109741] alignas(64) in libstdc++-v3/src/c++11/shared_ptr.cc Date: Thu, 04 May 2023 18:17:23 +0000 [thread overview] Message-ID: <bug-109741-4-5cYk3IvxRf@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-109741-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109741 --- Comment #10 from Jonathan Wakely <redi at gcc dot gnu.org> --- (In reply to Janez Zemva from comment #0) > This line: > > struct alignas(64) M : __gnu_cxx::__mutex { }; > > has been an eyesore for me for a number of years. I propose to change it That belongs on the mailing list, not in bugzilla. > into: > > struct alignas(std::max_align_t) M : __gnu_cxx::__mutex { }; That would be completely wrong though. (In reply to Janez Zemva from comment #1) > alternatively, the line could be changed into: > > struct alignas(void*) M : __gnu_cxx::__mutex { }; > > since this was probably meant with the magic number 64. That would be even more wrong. Please just read the comment instead of making silly assumptions about what we meant. (In reply to Janez Zemva from comment #5) > This line has been patched out by djgpp builds for a long time now. Then say that, instead of suggesting incorrect changes.
next prev parent reply other threads:[~2023-05-04 18:17 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-05-04 17:30 [Bug libstdc++/109741] New: " janezz55 at gmail dot com 2023-05-04 17:38 ` [Bug libstdc++/109741] " janezz55 at gmail dot com 2023-05-04 17:39 ` pinskia at gcc dot gnu.org 2023-05-04 17:40 ` pinskia at gcc dot gnu.org 2023-05-04 17:42 ` pinskia at gcc dot gnu.org 2023-05-04 17:58 ` janezz55 at gmail dot com 2023-05-04 18:02 ` pinskia at gcc dot gnu.org 2023-05-04 18:05 ` pinskia at gcc dot gnu.org 2023-05-04 18:10 ` janezz55 at gmail dot com 2023-05-04 18:14 ` jakub at gcc dot gnu.org 2023-05-04 18:17 ` redi at gcc dot gnu.org [this message] 2023-05-04 18:19 ` redi at gcc dot gnu.org 2023-05-04 18:31 ` jakub at gcc dot gnu.org 2023-05-04 19:30 ` janezz55 at gmail dot com 2023-05-04 20:18 ` redi at gcc dot gnu.org 2023-05-16 17:31 ` cvs-commit at gcc dot gnu.org 2023-05-16 17:33 ` redi at gcc dot gnu.org 2023-05-16 17:33 ` redi at gcc dot gnu.org 2023-06-29 23:01 ` cvs-commit at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-109741-4-5cYk3IvxRf@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).