public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/109811] libjxl 0.7 is a lot slower in GCC 13.1 vs Clang 16 Date: Mon, 19 Jun 2023 16:28:57 +0000 [thread overview] Message-ID: <bug-109811-4-swXo0hyTb0@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-109811-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109811 --- Comment #12 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Jan Hubicka <hubicka@gcc.gnu.org>: https://gcc.gnu.org/g:7b34cacc5735385e7e2855d7c0a6fad60ef4a99b commit r14-1951-g7b34cacc5735385e7e2855d7c0a6fad60ef4a99b Author: Jan Hubicka <jh@suse.cz> Date: Mon Jun 19 18:28:17 2023 +0200 optimize std::max early we currently produce very bad code on loops using std::vector as a stack, since we fail to inline push_back which in turn prevents SRA and we fail to optimize out some store-to-load pairs. I looked into why this function is not inlined and it is inlined by clang. We currently estimate it to 66 instructions and inline limits are 15 at -O2 and 30 at -O3. Clang has similar estimate, but still decides to inline at -O2. I looked into reason why the body is so large and one problem I spotted is the way std::max is implemented by taking and returning reference to the values. const T& max( const T& a, const T& b ); This makes it necessary to store the values to memory and load them later and max is used by code computing new size of vector on resize. We optimize this to MAX_EXPR, but only during late optimizations. I think this is a common enough coding pattern and we ought to make this transparent to early opts and IPA. The following is easist fix that simply adds phiprop pass that turns the PHI of address values into PHI of values so later FRE can propagate values across memory, phiopt discover the MAX_EXPR pattern and DSE remove the memory stores. gcc/ChangeLog: PR tree-optimization/109811 PR tree-optimization/109849 * passes.def: Add phiprop to early optimization passes. * tree-ssa-phiprop.cc: Allow clonning. gcc/testsuite/ChangeLog: PR tree-optimization/109811 PR tree-optimization/109849 * gcc.dg/tree-ssa/phiprop-1.c: New test. * gcc.dg/tree-ssa/pr21463.c: Adjust template.
next prev parent reply other threads:[~2023-06-19 16:29 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-05-11 14:24 [Bug tree-optimization/109811] New: libxjl " aros at gmx dot com 2023-05-11 15:30 ` [Bug target/109811] " xry111 at gcc dot gnu.org 2023-05-11 15:49 ` aros at gmx dot com 2023-05-12 6:59 ` rguenth at gcc dot gnu.org 2023-05-17 8:42 ` hubicka at gcc dot gnu.org 2023-05-17 9:08 ` hubicka at gcc dot gnu.org 2023-05-17 12:35 ` [Bug target/109811] libjxl " hubicka at gcc dot gnu.org 2023-05-17 13:59 ` juzhe.zhong at rivai dot ai 2023-05-17 14:04 ` hubicka at gcc dot gnu.org 2023-05-17 14:10 ` jakub at gcc dot gnu.org 2023-05-17 14:58 ` hubicka at gcc dot gnu.org 2023-05-18 13:40 ` hubicka at gcc dot gnu.org 2023-06-19 16:28 ` cvs-commit at gcc dot gnu.org [this message] 2023-11-02 14:12 ` hubicka at gcc dot gnu.org 2023-11-21 14:17 ` cvs-commit at gcc dot gnu.org 2023-11-24 23:13 ` hubicka at gcc dot gnu.org 2023-11-24 23:23 ` sjames at gcc dot gnu.org 2023-11-25 6:22 ` aros at gmx dot com 2023-11-25 13:31 ` hubicka at gcc dot gnu.org 2024-01-05 21:31 ` hubicka at gcc dot gnu.org 2024-01-20 17:23 ` pinskia at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-109811-4-swXo0hyTb0@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).