public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "burnus at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug libstdc++/109816] [13/14 Regression] r14-321 fix for PR108969 breaks NVPTX offloading due to __asm (".globl _ZSt21ios_base_library_initv") Date: Thu, 11 May 2023 20:51:49 +0000 [thread overview] Message-ID: <bug-109816-4-6A6VciwJjU@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-109816-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109816 --- Comment #6 from Tobias Burnus <burnus at gcc dot gnu.org> --- (In reply to Jakub Jelinek from comment #5) > The above can work only if toplevel asms are in separate section and so > inputting it or not doesn't affect input of other data. > I think it would be better to also not to stream it if lto_stream_offload_p. The toplevel asms are in a special section: LTO_section_asm — and that section (enum value) is only used by lto_output_toplevel_asms/lto_input_toplevel_asms. The output symbols are in symtab->first_asm_symbol(); and all symbols added there are added through symbol_table::finalize_toplevel_asm(t). However, if you don't want to stream it out, we could do the following to prevent it: diff --git a/gcc/lto-streamer-out.cc b/gcc/lto-streamer-out.cc index 0bca530..853688b 100644 --- a/gcc/lto-streamer-out.cc +++ b/gcc/lto-streamer-out.cc @@ -2525,3 +2525,4 @@ lto_output_toplevel_asms (void) - if (!symtab->first_asm_symbol ()) + /* Skip if there is no LTO but only flag_generate_offload. */ + if ((!in_lto_p && !flag_lto) || !symtab->first_asm_symbol ()) return; --- a/gcc/lto-cgraph.cc +++ b/gcc/lto-cgraph.cc @@ -1587,3 +1587,5 @@ input_cgraph_1 (struct lto_file_decl_data *file_data, +#ifndef ACCEL_COMPILER lto_input_toplevel_asms (file_data, file_data->order_base); +#endif
next prev parent reply other threads:[~2023-05-11 20:51 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-05-11 17:55 [Bug libstdc++/109816] New: [14 " burnus at gcc dot gnu.org 2023-05-11 18:02 ` [Bug libstdc++/109816] [13/14 " pinskia at gcc dot gnu.org 2023-05-11 18:40 ` burnus at gcc dot gnu.org 2023-05-11 18:48 ` jakub at gcc dot gnu.org 2023-05-11 20:10 ` burnus at gcc dot gnu.org 2023-05-11 20:16 ` jakub at gcc dot gnu.org 2023-05-11 20:51 ` burnus at gcc dot gnu.org [this message] 2023-05-11 21:06 ` jakub at gcc dot gnu.org 2023-05-11 21:37 ` burnus at gcc dot gnu.org 2023-05-12 7:06 ` rguenth at gcc dot gnu.org 2023-05-12 14:30 ` cvs-commit at gcc dot gnu.org 2023-05-16 9:39 ` cvs-commit at gcc dot gnu.org 2023-05-16 13:24 ` burnus at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-109816-4-6A6VciwJjU@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).