[Bug tree-optimization/109834] New: internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (ssa_name) in gimple_simplify_191 when building harfbuzz

[Bug tree-optimization/109834] New: internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (ssa_name) in gimple_simplify_191 when building harfbuzz

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109834

            Bug ID: 109834
           Summary: internal compiler error: tree check: expected class
                    ‘type’, have ‘exceptional’ (ssa_name) in
                    gimple_simplify_191 when building harfbuzz
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: sjames at gcc dot gnu.org
  Target Milestone: ---

Created attachment 55066
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=55066&action=edit
hb-subset.cc.ii

```
FAILED: src/libharfbuzz-subset.so.0.60730.0.p/hb-subset.cc.o
aarch64-unknown-linux-gnu-g++ -Isrc/libharfbuzz-subset.so.0.60730.0.p -Isrc
-I../harfbuzz-7.3.0/src -I. -I../harfbuzz-7.3.0 -fdiagnostics-color=always
-D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -std=c++11 -fno-exceptions -fno-rtti
-fno-exceptions -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden
-DU_DISABLE_RENAMING=1 -DHAVE_CONFIG_H -O3 -pipe -mcpu=native -DHB_NDEBUG -fPIC
-Wno-non-virtual-dtor -MD -MQ
src/libharfbuzz-subset.so.0.60730.0.p/hb-subset.cc.o -MF
src/libharfbuzz-subset.so.0.60730.0.p/hb-subset.cc.o.d -o
src/libharfbuzz-subset.so.0.60730.0.p/hb-subset.cc.o -c
../harfbuzz-7.3.0/src/hb-subset.cc
during GIMPLE pass: forwprop
../harfbuzz-7.3.0/src/hb-subset.cc: In member function ‘unsigned int
OT::Layout::GPOS_impl::ValueFormat::get_len() const’:
../harfbuzz-7.3.0/src/hb-subset.cc:639:1: internal compiler error: tree check:
expected class ‘type’, have ‘exceptional’ (ssa_name) in gimple_simplify_191, at
gimple-match-2.cc:1184
  639 | }
      | ^
0x72bcb7 tree_class_check_failed(tree_node const*, tree_code_class, char
const*, int, char const*)
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/tree.cc:8949
0x224af97 tree_class_check(tree_node*, tree_code_class, char const*, int, char
const*)
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/tree.h:3663
0x224af97 gimple_simplify_191(gimple_match_op*, gimple**, tree_node*
(*)(tree_node*), tree_node*, tree_node**, combined_fn, combined_fn)
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/build/gcc/gimple-match-2.cc:1184
0x179e3d7 gimple_simplify_CFN_BUILT_IN_POPCOUNT(gimple_match_op*, gimple**,
tree_node* (*)(tree_node*), code_helper, tree_node*, tree_node*)
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/build/gcc/gimple-match-8.cc:5618
0x186dd1b gimple_resimplify1
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/gimple-match-exports.cc:890
0x186e71f gimple_simplify(gimple*, gimple_match_op*, gimple**, tree_node*
(*)(tree_node*), tree_node* (*)(tree_node*))
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/gimple-match-exports.cc:834
0xdff7e3 fold_stmt_1
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/gimple-fold.cc:6251
0x134facb execute
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/tree-ssa-forwprop.cc:3919
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://bugs.gentoo.org/> for instructions.
```

```
gcc (Gentoo 14.0.0.9999 p, commit 29d805847dc870c92f705ed9c5e7eac955c7e7d4)
14.0.0 20230512 (experimental) f52bf590e3336979ee47658d74a8478e3234da9b
Copyright (C) 2023 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
```

I can reproduce it with `aarch64-unknown-linux-gnu-g++ -std=c++11 -c
hb-subset.cc.ii -O2`.

I've got a bunch of these and just picked Harfbuzz at random.

[Bug tree-optimization/109834] internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (ssa_name) in gimple_simplify_191 when building harfbuzz

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109834

--- Comment #1 from Sam James <sjames at gcc dot gnu.org> ---
The *other* main issue I have is with graphite2:
```
FAILED: src/CMakeFiles/graphite2.dir/GlyphCache.cpp.o 
/usr/bin/aarch64-unknown-linux-gnu-g++ -DGRAPHITE2_NTRACING -Dgraphite2_EXPORTS
-I/var/tmp/portage/media-gfx/graphite2-1.3.14_p20210810-r3/work/graphite-80c52493ef42e6fe605a69dcddd2a691cd8a1380/include
-I/var/tmp/portage/media-gfx/graphite2-1.3.14_p20210810-r3/work/graphite-80c52493ef42e6fe605a69dcddd2a691cd8a1380/src
 -O3 -pipe -mcpu=native -std=gnu++11 -fPIC   -Wno-class-memaccess
-Wdouble-promotion -Wall -Wextra -Wno-unknown-pragmas -Wendif-labels -Wshadow
-Wctor-dtor-privacy -Wnon-virtual-dtor -fno-rtti -fno-exceptions
-fvisibility=hidden -fvisibility-inlines-hidden -MD -MT
src/CMakeFiles/graphite2.dir/GlyphCache.cpp.o -MF
src/CMakeFiles/graphite2.dir/GlyphCache.cpp.o.d -o
src/CMakeFiles/graphite2.dir/GlyphCache.cpp.o -c
/var/tmp/portage/media-gfx/graphite2-1.3.14_p20210810-r3/work/graphite-80c52493ef42e6fe605a69dcddd2a691cd8a1380/src/GlyphCache.cpp
during GIMPLE pass: ccp
/var/tmp/portage/media-gfx/graphite2-1.3.14_p20210810-r3/work/graphite-80c52493ef42e6fe605a69dcddd2a691cd8a1380/src/GlyphCache.cpp:
In member function ‘const graphite2::GlyphFace*
graphite2::GlyphCache::Loader::read_glyph(short unsigned int,
graphite2::GlyphFace&, int*) const’:
/var/tmp/portage/media-gfx/graphite2-1.3.14_p20210810-r3/work/graphite-80c52493ef42e6fe605a69dcddd2a691cd8a1380/src/GlyphCache.cpp:348:19:
internal compiler error: tree check: expected class ‘type’, have ‘exceptional’
(ssa_name) in gimple_simplify_352, at gimple-match-5.cc:2216
  348 | const GlyphFace * GlyphCache::Loader::read_glyph(unsigned short
glyphid, GlyphFace & glyph, int *numsubs) const throw()
      |                   ^~~~~~~~~~
0x72bcb7 tree_class_check_failed(tree_node const*, tree_code_class, char
const*, int, char const*)
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/tree.cc:8949
0x1704b3b tree_class_check(tree_node*, tree_code_class, char const*, int, char
const*)
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/tree.h:3663
0x1704b3b gimple_simplify_352(gimple_match_op*, gimple**, tree_node*
(*)(tree_node*), tree_node*, tree_node**, tree_code, combined_fn)
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/build/gcc/gimple-match-5.cc:2216
0x222fc47 gimple_simplify_CFN_POPCOUNT(gimple_match_op*, gimple**, tree_node*
(*)(tree_node*), code_helper, tree_node*, tree_node*)
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/build/gcc/gimple-match-1.cc:5764
0x186dd1b gimple_resimplify1
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/gimple-match-exports.cc:890
0x186e71f gimple_simplify(gimple*, gimple_match_op*, gimple**, tree_node*
(*)(tree_node*), tree_node* (*)(tree_node*))
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/gimple-match-exports.cc:834
0xdf9753 gimple_fold_stmt_to_constant_1(gimple*, tree_node* (*)(tree_node*),
tree_node* (*)(tree_node*))
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/gimple-fold.cc:7444
0x132547b ccp_fold
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/tree-ssa-ccp.cc:1289
0x132547b evaluate_stmt
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/tree-ssa-ccp.cc:2222
0x1326d77 visit_assignment
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/tree-ssa-ccp.cc:2855
0x13d949b ssa_propagation_engine::simulate_stmt(gimple*)
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/tree-ssa-propagate.cc:221
0x13d97f7 ssa_propagation_engine::simulate_block(basic_block_def*)
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/tree-ssa-propagate.cc:328
0x13d9d73 ssa_propagation_engine::ssa_propagate()
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/tree-ssa-propagate.cc:478
0x131f603 do_ssa_ccp
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/tree-ssa-ccp.cc:2974
0x131f603 execute
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/tree-ssa-ccp.cc:3020
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://bugs.gentoo.org/> for instructions.
ninja: build stopped: subcommand failed.
```

Please tell me if you want a PR for that, otherwise I'll assume it's the same
as this.

[Bug tree-optimization/109834] internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (ssa_name) in gimple_simplify_191 when building harfbuzz

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109834

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu.org
           Keywords|                            |ice-on-valid-code
   Target Milestone|---                         |14.0

[Bug tree-optimization/109834] [14 Regression] internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (ssa_name) in gimple_simplify_191 when building harfbuzz

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109834

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
I am 99% sure it was introduced by r14-673-g5fdcfe3c5776

The bug is:
+         (if (prec0 == prec1 || (prec0 > prec1 && TYPE_UNSIGNED (@1)))

Should have been:
+         (if (prec0 == prec1 || (prec0 > prec1 && TYPE_UNSIGNED (TREE_TYPE
(@1))))

In both places.

[Bug tree-optimization/109834] [14 Regression] internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (ssa_name) in gimple_simplify_191 when building harfbuzz

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109834

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Sam James from comment #1)
> The *other* main issue I have is with graphite2:

It is a similar enough issue; that is there was two locations where the bad
code was introduced with that patch and should be fixed in a similar fashion.

(Note I am double checking my original thought here too).

[Bug tree-optimization/109834] [14 Regression] internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (ssa_name) in gimple_simplify_191 when building harfbuzz

[mikael at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109834

Mikael Morin <mikael at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mikael at gcc dot gnu.org

--- Comment #4 from Mikael Morin <mikael at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #2)
> I am 99% sure it was introduced by r14-673-g5fdcfe3c5776
> 
I think the correct link is r14-673-gc0dd80e4c4c3

[Bug tree-optimization/109834] [14 Regression] internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (ssa_name) in gimple_simplify_191 when building harfbuzz

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109834

--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Mikael Morin from comment #4)
> (In reply to Andrew Pinski from comment #2)
> > I am 99% sure it was introduced by r14-673-g5fdcfe3c5776
> > 
> I think the correct link is r14-673-gc0dd80e4c4c3

Yes, I copied the wrong git commit hash in there :). I really need to update my
gcc-git-customization for this git tree to produce the correct thing in the
first place.

[Bug tree-optimization/109834] [14 Regression] internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (ssa_name) in gimple_simplify_191 when building harfbuzz

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109834

--- Comment #6 from Sam James <sjames at gcc dot gnu.org> ---
Created attachment 55069
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=55069&action=edit
reduced.ii

I might reduce the graphite2 one for fun just to see how different it is but no
promises.

[Bug tree-optimization/109834] [14 Regression] internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (ssa_name) in gimple_simplify_191 when building harfbuzz

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109834

--- Comment #7 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Reduced further:
int split_subtables(char v)
{
  return __builtin_popcount((int)__builtin_bswap16(v));
}

[Bug tree-optimization/109834] [14 Regression] internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (ssa_name) in gimple_simplify_191 when building harfbuzz

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109834

--- Comment #8 from Sam James <sjames at gcc dot gnu.org> ---
Created attachment 55071
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=55071&action=edit
graphite2-GlyphCache.cpp.ii (maybe related)

[Bug tree-optimization/109834] [14 Regression] internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (ssa_name) in gimple_simplify_191 when building harfbuzz

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109834

--- Comment #9 from Sam James <sjames at gcc dot gnu.org> ---
(In reply to Sam James from comment #8)
> Created attachment 55071 [details]
> graphite2-GlyphCache.cpp.ii (maybe related)

I guess this is really the same given the operations it's doing (its own
bswaps).

[Bug tree-optimization/109834] [14 Regression] internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (ssa_name) in gimple_simplify_191 when building harfbuzz

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109834

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2023-05-12
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW

--- Comment #10 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Sam James from comment #8)
> Created attachment 55071 [details]
> graphite2-GlyphCache.cpp.ii (maybe related)

bit_set_count is optimized to __builtin_popcount and read/_peek gets optimized
to __builtin_bswap16 so it is exactly the same just the long way of hitting the
same bug.

[Bug tree-optimization/109834] [14 Regression] internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (ssa_name) in gimple_simplify_191 when building harfbuzz

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109834

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |pinskia at gcc dot gnu.org

--- Comment #11 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Mine I will take care of this.

[Bug tree-optimization/109834] [14 Regression] internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (ssa_name) in gimple_simplify_191 when building harfbuzz

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109834

--- Comment #12 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Andrew Pinski <pinskia@gcc.gnu.org>:

https://gcc.gnu.org/g:99488a6048745a7b999c22f46e5814d02ebf88d9

commit r14-804-g99488a6048745a7b999c22f46e5814d02ebf88d9
Author: Andrew Pinski <apinski@marvell.com>
Date:   Fri May 12 16:33:44 2023 -0700

    MATCH: Fix PR 109834, ICE with popcount combined with bswap

    After r14-673-gc0dd80e4c4c3, there was a check in the match
    patterns which was checking the type is unsigned but
    instead of using the type, the patch used the expression.
    This adds the needed TREE_TYPE so get the correct answer and don't ICE.

    Committed as obvious after a bootstrap/test on x86_64-linux-gnu.

            PR tree-optimization/109834

    gcc/ChangeLog:

            * match.pd (popcount(bswap(x))->popcount(x)): Fix up unsigned type
checking.
            (popcount(rotate(x,y))->popcount(x)): Likewise.

    gcc/testsuite/ChangeLog:

            * gcc.c-torture/compile/pr109834-1.c: New test.
            * gcc.dg/tree-ssa/pr109834-1.c: New test.

[Bug tree-optimization/109834] [14 Regression] internal compiler error: tree check: expected class ‘type’, have ‘exceptional’ (ssa_name) in gimple_simplify_191 when building harfbuzz

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109834

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #13 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Fixed.