[Bug tree-optimization/109848] New: [14 Regression] Recent change causing testsuite ICE on csky port

[Bug tree-optimization/109848] New: [14 Regression] Recent change causing testsuite ICE on csky port

[law at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109848

            Bug ID: 109848
           Summary: [14 Regression] Recent change causing testsuite ICE on
                    csky port
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: law at gcc dot gnu.org
  Target Milestone: ---

This patch:

commit cc0e22b3f25d4b2a326322bce711179c02377e6c
Author: Richard Biener <rguenther@suse.de>
Date:   Fri May 12 13:43:27 2023 +0200

    tree-optimization/64731 - extend store-from CTOR lowering to TARGET_MEM_REF

    The following also covers TARGET_MEM_REF when decomposing stores from
    CTORs to supported elementwise operations.  This avoids spilling
    and cleans up after vector lowering which doesn't touch loads or
    stores.  It also mimics what we already do for loads.

            PR tree-optimization/64731
            * tree-ssa-forwprop.cc (pass_forwprop::execute): Also
            handle TARGET_MEM_REF destinations of stores from vector
            CTORs.

            * gcc.target/i386/pr64731.c: New testcase.


Is causing the csky port to abort in forwprop with an verify_ssa failure
FAIL: gcc.dg/torture/pr52407.c   -O2  (internal compiler error: verify_ssa
failed)
FAIL: gcc.dg/torture/pr52407.c   -O2  (test for excess errors)
Excess errors:
/home/jlaw/test/gcc/gcc/testsuite/gcc.dg/torture/pr52407.c:22:1: error:
definition in block 3 follows the use
for SSA_NAME: _38 in statement:
_24 = &MEM[(vl_t *)_38];
during GIMPLE pass: forwprop
/home/jlaw/test/gcc/gcc/testsuite/gcc.dg/torture/pr52407.c:22:1: internal
compiler error: verify_ssa failed
0x11a93bf verify_ssa(bool, bool)
        /home/jlaw/test/gcc/gcc/tree-ssa.cc:1203
0xe5f8a5 execute_function_todo
        /home/jlaw/test/gcc/gcc/passes.cc:2105
0xe5e4de do_per_function
        /home/jlaw/test/gcc/gcc/passes.cc:1694
0xe5fa4e execute_todo
        /home/jlaw/test/gcc/gcc/passes.cc:2152


Testsuite is gcc.dg/torture/pr52407 can can be seen with just a cross compiler.

[Bug tree-optimization/109848] [14 Regression] Recent change causing testsuite ICE on csky port

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109848

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |14.0
           Keywords|                            |testsuite-fail

[Bug tree-optimization/109848] [14 Regression] Recent change causing testsuite ICE on csky port

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109848

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2023-05-15
             Status|UNCONFIRMED                 |ASSIGNED

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
I will have a look.

[Bug tree-optimization/109848] [14 Regression] Recent change causing testsuite ICE on csky port

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109848

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:7db541ce448c2776971be63c957dcc887bd09bf8

commit r14-817-g7db541ce448c2776971be63c957dcc887bd09bf8
Author: Richard Biener <rguenther@suse.de>
Date:   Mon May 15 09:10:08 2023 +0200

    tree-optimization/109848 - fix TARGET_MEM_REF store from CTOR
simplification

    I've put the preparation stmt in the wrong place.

            PR tree-optimization/109848
            * tree-ssa-forwprop.cc (pass_forwprop::execute): Put the
            TARGET_MEM_REF address preparation before the store, not
            before the CTOR.

[Bug tree-optimization/109848] [14 Regression] Recent change causing testsuite ICE on csky port

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109848

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.