public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug modula2/109908] New: Delete from m2iso Strings is broken
@ 2023-05-19 11:01 gaius at gcc dot gnu.org
2023-05-19 11:02 ` [Bug modula2/109908] " gaius at gcc dot gnu.org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: gaius at gcc dot gnu.org @ 2023-05-19 11:01 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109908
Bug ID: 109908
Summary: Delete from m2iso Strings is broken
Product: gcc
Version: 14.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: modula2
Assignee: gaius at gcc dot gnu.org
Reporter: gaius at gcc dot gnu.org
Target Milestone: ---
Created attachment 55117
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=55117&action=edit
test code for m2iso Strings.Delete
As reported on the gm2 mailing list the m2iso Strings.Delete is broken for
example the following test code fails:
$ gm2 --version
gm2 (GCC) 14.0.0 20230511 (experimental)
Copyright (C) 2023 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
$ gm2 -g -fiso testdelete.mod
$ ./a.out
after Delete string one = '1'
error: string one should be empty after delete
error: string one have length 0 after delete
after Delete string two = '221'
error: string two should be '2' after delete
error: string two have length 1 after delete
after Delete string three = '233221'
error: string three should be '23' after delete
error: string three should have length 2 after delete
after Delete string four = ''
after Delete string large = '01234567890123456789'
after Delete string large = '01234567890123456789'
after Delete string three = '133221'
error: string three should be '13' after delete
error: string three should have length 2 after delete
after Delete string four = '13'
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug modula2/109908] Delete from m2iso Strings is broken
2023-05-19 11:01 [Bug modula2/109908] New: Delete from m2iso Strings is broken gaius at gcc dot gnu.org
@ 2023-05-19 11:02 ` gaius at gcc dot gnu.org
2023-05-19 11:13 ` gaius at gcc dot gnu.org
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: gaius at gcc dot gnu.org @ 2023-05-19 11:02 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109908
Gaius Mulley <gaius at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Last reconfirmed| |2023-05-19
Ever confirmed|0 |1
Status|UNCONFIRMED |ASSIGNED
--- Comment #1 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Confirmed on gcc master.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug modula2/109908] Delete from m2iso Strings is broken
2023-05-19 11:01 [Bug modula2/109908] New: Delete from m2iso Strings is broken gaius at gcc dot gnu.org
2023-05-19 11:02 ` [Bug modula2/109908] " gaius at gcc dot gnu.org
@ 2023-05-19 11:13 ` gaius at gcc dot gnu.org
2023-05-19 11:19 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: gaius at gcc dot gnu.org @ 2023-05-19 11:13 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109908
Gaius Mulley <gaius at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |gaius at gcc dot gnu.org
--- Comment #2 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Created attachment 55118
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=55118&action=edit
Proposed fix
Here is a proposed fix for a re-implementation of Delete in Strings.mod
(m2iso).
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug modula2/109908] Delete from m2iso Strings is broken
2023-05-19 11:01 [Bug modula2/109908] New: Delete from m2iso Strings is broken gaius at gcc dot gnu.org
2023-05-19 11:02 ` [Bug modula2/109908] " gaius at gcc dot gnu.org
2023-05-19 11:13 ` gaius at gcc dot gnu.org
@ 2023-05-19 11:19 ` cvs-commit at gcc dot gnu.org
2023-05-19 11:20 ` gaius at gcc dot gnu.org
2023-07-29 1:04 ` cvs-commit at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-05-19 11:19 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109908
--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Gaius Mulley <gaius@gcc.gnu.org>:
https://gcc.gnu.org/g:0a78bc26dadcb6f4c8b59b41858d70bb5432fadd
commit r14-994-g0a78bc26dadcb6f4c8b59b41858d70bb5432fadd
Author: Gaius Mulley <gaiusmod2@gmail.com>
Date: Fri May 19 12:18:53 2023 +0100
PR modula2/109908 Delete from m2iso Strings is broken
This patch re-implements Strings.Delete and also supplies
some runtime test code.
gcc/m2/ChangeLog:
PR modula2/109908
* gm2-libs-iso/Strings.mod (Delete): Re-implement.
gcc/testsuite/ChangeLog:
PR modula2/109908
* gm2/isolib/run/pass/testdelete.mod: New test.
Signed-off-by: Gaius Mulley <gaiusmod2@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug modula2/109908] Delete from m2iso Strings is broken
2023-05-19 11:01 [Bug modula2/109908] New: Delete from m2iso Strings is broken gaius at gcc dot gnu.org
` (2 preceding siblings ...)
2023-05-19 11:19 ` cvs-commit at gcc dot gnu.org
@ 2023-05-19 11:20 ` gaius at gcc dot gnu.org
2023-07-29 1:04 ` cvs-commit at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: gaius at gcc dot gnu.org @ 2023-05-19 11:20 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109908
Gaius Mulley <gaius at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #4 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Closing now that the patch has been applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug modula2/109908] Delete from m2iso Strings is broken
2023-05-19 11:01 [Bug modula2/109908] New: Delete from m2iso Strings is broken gaius at gcc dot gnu.org
` (3 preceding siblings ...)
2023-05-19 11:20 ` gaius at gcc dot gnu.org
@ 2023-07-29 1:04 ` cvs-commit at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-07-29 1:04 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109908
--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Gaius Mulley
<gaius@gcc.gnu.org>:
https://gcc.gnu.org/g:9306ef0d5786496a9bbe1850c2e826d5cdf5582e
commit r13-7639-g9306ef0d5786496a9bbe1850c2e826d5cdf5582e
Author: Gaius Mulley <gaiusmod2@gmail.com>
Date: Sat Jul 29 02:03:43 2023 +0100
PR modula2/109908 Delete from m2iso Strings is broken
This patch re-implements Strings.Delete and also supplies
some runtime test code.
gcc/m2/ChangeLog:
PR modula2/109908
* gm2-libs-iso/Strings.mod (Delete): Re-implement.
gcc/testsuite/ChangeLog:
PR modula2/109908
* gm2/isolib/run/pass/testdelete.mod: New test.
(cherry picked from commit 0a78bc26dadcb6f4c8b59b41858d70bb5432fadd)
Signed-off-by: Gaius Mulley <gaiusmod2@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-07-29 1:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-19 11:01 [Bug modula2/109908] New: Delete from m2iso Strings is broken gaius at gcc dot gnu.org
2023-05-19 11:02 ` [Bug modula2/109908] " gaius at gcc dot gnu.org
2023-05-19 11:13 ` gaius at gcc dot gnu.org
2023-05-19 11:19 ` cvs-commit at gcc dot gnu.org
2023-05-19 11:20 ` gaius at gcc dot gnu.org
2023-07-29 1:04 ` cvs-commit at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).