public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug tree-optimization/110038] New: [14 Regression] ICE: in rewrite_expr_tree_parallel, at tree-ssa-reassoc.cc:5522 with --param=tree-reassoc-width=2147483647
@ 2023-05-30 10:49 zsojka at seznam dot cz
2023-05-30 11:43 ` [Bug tree-optimization/110038] " rguenth at gcc dot gnu.org
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: zsojka at seznam dot cz @ 2023-05-30 10:49 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110038
Bug ID: 110038
Summary: [14 Regression] ICE: in rewrite_expr_tree_parallel, at
tree-ssa-reassoc.cc:5522 with
--param=tree-reassoc-width=2147483647
Product: gcc
Version: 14.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: tree-optimization
Assignee: unassigned at gcc dot gnu.org
Reporter: zsojka at seznam dot cz
Target Milestone: ---
Created attachment 55216
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=55216&action=edit
reduced testcase
Compiler output:
$ x86_64-pc-linux-gnu-gcc -O --param=tree-reassoc-width=2147483647 testcase.c
during GIMPLE pass: reassoc
testcase.c: In function 'foo':
testcase.c:4:1: internal compiler error: in rewrite_expr_tree_parallel, at
tree-ssa-reassoc.cc:5522
4 | foo (unsigned u)
| ^~~
0x82f7b5 rewrite_expr_tree_parallel
/repo/gcc-trunk/gcc/tree-ssa-reassoc.cc:5522
0x160d21d reassociate_bb
/repo/gcc-trunk/gcc/tree-ssa-reassoc.cc:6931
0x160b55a reassociate_bb
/repo/gcc-trunk/gcc/tree-ssa-reassoc.cc:6994
0x160dc33 do_reassoc
/repo/gcc-trunk/gcc/tree-ssa-reassoc.cc:7106
0x160dc33 execute_reassoc
/repo/gcc-trunk/gcc/tree-ssa-reassoc.cc:7195
0x160dc33 execute
/repo/gcc-trunk/gcc/tree-ssa-reassoc.cc:7236
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.
What probably happens, is an overflow in tree-ssa-reassoc.c due to the extreme
value of param_tree_reassoc_width:
5459 while (width > width_min)
5460 {
5461 int width_mid = (width + width_min) / 2;
5462
5463 if (get_required_cycles (ops_num, width_mid) == cycles_best)
$ x86_64-pc-linux-gnu-gcc -v
Using built-in specs.
COLLECT_GCC=/repo/gcc-trunk/binary-latest-amd64/bin/x86_64-pc-linux-gnu-gcc
COLLECT_LTO_WRAPPER=/repo/gcc-trunk/binary-trunk-r14-1399-20230530111808-g456cf52c0d3-checking-yes-rtl-df-extra-nobootstrap-amd64/bin/../libexec/gcc/x86_64-pc-linux-gnu/14.0.0/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: /repo/gcc-trunk//configure --enable-languages=c,c++
--enable-valgrind-annotations --disable-nls --enable-checking=yes,rtl,df,extra
--disable-bootstrap --with-cloog --with-ppl --with-isl
--build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu
--target=x86_64-pc-linux-gnu --with-ld=/usr/bin/x86_64-pc-linux-gnu-ld
--with-as=/usr/bin/x86_64-pc-linux-gnu-as --disable-libstdcxx-pch
--prefix=/repo/gcc-trunk//binary-trunk-r14-1399-20230530111808-g456cf52c0d3-checking-yes-rtl-df-extra-nobootstrap-amd64
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 14.0.0 20230530 (experimental) (GCC)
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug tree-optimization/110038] [14 Regression] ICE: in rewrite_expr_tree_parallel, at tree-ssa-reassoc.cc:5522 with --param=tree-reassoc-width=2147483647
2023-05-30 10:49 [Bug tree-optimization/110038] New: [14 Regression] ICE: in rewrite_expr_tree_parallel, at tree-ssa-reassoc.cc:5522 with --param=tree-reassoc-width=2147483647 zsojka at seznam dot cz
@ 2023-05-30 11:43 ` rguenth at gcc dot gnu.org
2023-05-31 2:32 ` lili.cui at intel dot com
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: rguenth at gcc dot gnu.org @ 2023-05-30 11:43 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110038
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Last reconfirmed| |2023-05-30
Target Milestone|--- |14.0
Ever confirmed|0 |1
Priority|P3 |P1
Status|UNCONFIRMED |NEW
CC| |lili.cui at intel dot com
--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Probably best to limit the values to reassoc-width by adding the
appropriate IntegerRange attribute in params.opt
IntegerRange(0, 256)
maybe?
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug tree-optimization/110038] [14 Regression] ICE: in rewrite_expr_tree_parallel, at tree-ssa-reassoc.cc:5522 with --param=tree-reassoc-width=2147483647
2023-05-30 10:49 [Bug tree-optimization/110038] New: [14 Regression] ICE: in rewrite_expr_tree_parallel, at tree-ssa-reassoc.cc:5522 with --param=tree-reassoc-width=2147483647 zsojka at seznam dot cz
2023-05-30 11:43 ` [Bug tree-optimization/110038] " rguenth at gcc dot gnu.org
@ 2023-05-31 2:32 ` lili.cui at intel dot com
2023-05-31 7:51 ` cvs-commit at gcc dot gnu.org
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: lili.cui at intel dot com @ 2023-05-31 2:32 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110038
--- Comment #2 from cuilili <lili.cui at intel dot com> ---
(In reply to Richard Biener from comment #1)
> Probably best to limit the values to reassoc-width by adding the
> appropriate IntegerRange attribute in params.opt
>
> IntegerRange(0, 256)
>
> maybe?
"rewrite_expr_tree_parallel" got a wrong width from "get_reassociation_width"
The number of ops is 4, width is 2147483647.
get_reassociation_width:
...
width_min = 1;
while (width > width_min)
{
int width_mid = (width + width_min) / 2; --> (width + 1) out of bounds
...
So Richard suggested that limiting tree-reassoc-width to IntegerRange(0, 256)
would solve the ICE, I also added a width constraint in
rewrite_expr_tree_parallel, here is the patch.
https://gcc.gnu.org/pipermail/gcc-patches/2023-May/620154.html
1. Limit the value of tree-reassoc-width to IntegerRange(0, 256).
2. Add width limit in rewrite_expr_tree_parallel.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug tree-optimization/110038] [14 Regression] ICE: in rewrite_expr_tree_parallel, at tree-ssa-reassoc.cc:5522 with --param=tree-reassoc-width=2147483647
2023-05-30 10:49 [Bug tree-optimization/110038] New: [14 Regression] ICE: in rewrite_expr_tree_parallel, at tree-ssa-reassoc.cc:5522 with --param=tree-reassoc-width=2147483647 zsojka at seznam dot cz
2023-05-30 11:43 ` [Bug tree-optimization/110038] " rguenth at gcc dot gnu.org
2023-05-31 2:32 ` lili.cui at intel dot com
@ 2023-05-31 7:51 ` cvs-commit at gcc dot gnu.org
2023-06-06 14:46 ` jamborm at gcc dot gnu.org
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-05-31 7:51 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110038
--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Lili Cui <cuilili@gcc.gnu.org>:
https://gcc.gnu.org/g:80ee7d02e8db4893e104de02659fb71cc1dc81e9
commit r14-1425-g80ee7d02e8db4893e104de02659fb71cc1dc81e9
Author: Cui, Lili <lili.cui@intel.com>
Date: Wed May 31 07:39:13 2023 +0000
Fix ICE in rewrite_expr_tree_parallel
1. Limit the value of tree-reassoc-width to IntegerRange(0, 256).
2. Add width limit in rewrite_expr_tree_parallel.
gcc/ChangeLog:
PR tree-optimization/110038
* params.opt: Add a limit on tree-reassoc-width.
* tree-ssa-reassoc.cc
(rewrite_expr_tree_parallel): Add width limit.
gcc/testsuite/ChangeLog:
PR tree-optimization/110038
* gcc.dg/pr110038.c: New test.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug tree-optimization/110038] [14 Regression] ICE: in rewrite_expr_tree_parallel, at tree-ssa-reassoc.cc:5522 with --param=tree-reassoc-width=2147483647
2023-05-30 10:49 [Bug tree-optimization/110038] New: [14 Regression] ICE: in rewrite_expr_tree_parallel, at tree-ssa-reassoc.cc:5522 with --param=tree-reassoc-width=2147483647 zsojka at seznam dot cz
` (2 preceding siblings ...)
2023-05-31 7:51 ` cvs-commit at gcc dot gnu.org
@ 2023-06-06 14:46 ` jamborm at gcc dot gnu.org
2023-06-07 1:57 ` lili.cui at intel dot com
2023-06-07 8:18 ` jamborm at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: jamborm at gcc dot gnu.org @ 2023-06-06 14:46 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110038
Martin Jambor <jamborm at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jamborm at gcc dot gnu.org
--- Comment #4 from Martin Jambor <jamborm at gcc dot gnu.org> ---
So is this now fixed?
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug tree-optimization/110038] [14 Regression] ICE: in rewrite_expr_tree_parallel, at tree-ssa-reassoc.cc:5522 with --param=tree-reassoc-width=2147483647
2023-05-30 10:49 [Bug tree-optimization/110038] New: [14 Regression] ICE: in rewrite_expr_tree_parallel, at tree-ssa-reassoc.cc:5522 with --param=tree-reassoc-width=2147483647 zsojka at seznam dot cz
` (3 preceding siblings ...)
2023-06-06 14:46 ` jamborm at gcc dot gnu.org
@ 2023-06-07 1:57 ` lili.cui at intel dot com
2023-06-07 8:18 ` jamborm at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: lili.cui at intel dot com @ 2023-06-07 1:57 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110038
--- Comment #5 from cuilili <lili.cui at intel dot com> ---
(In reply to Martin Jambor from comment #4)
> So is this now fixed?
Yes, the attachment case has been fixed.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug tree-optimization/110038] [14 Regression] ICE: in rewrite_expr_tree_parallel, at tree-ssa-reassoc.cc:5522 with --param=tree-reassoc-width=2147483647
2023-05-30 10:49 [Bug tree-optimization/110038] New: [14 Regression] ICE: in rewrite_expr_tree_parallel, at tree-ssa-reassoc.cc:5522 with --param=tree-reassoc-width=2147483647 zsojka at seznam dot cz
` (4 preceding siblings ...)
2023-06-07 1:57 ` lili.cui at intel dot com
@ 2023-06-07 8:18 ` jamborm at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: jamborm at gcc dot gnu.org @ 2023-06-07 8:18 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110038
Martin Jambor <jamborm at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #6 from Martin Jambor <jamborm at gcc dot gnu.org> ---
Let's mark it as fixed then.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-06-07 8:18 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-30 10:49 [Bug tree-optimization/110038] New: [14 Regression] ICE: in rewrite_expr_tree_parallel, at tree-ssa-reassoc.cc:5522 with --param=tree-reassoc-width=2147483647 zsojka at seznam dot cz
2023-05-30 11:43 ` [Bug tree-optimization/110038] " rguenth at gcc dot gnu.org
2023-05-31 2:32 ` lili.cui at intel dot com
2023-05-31 7:51 ` cvs-commit at gcc dot gnu.org
2023-06-06 14:46 ` jamborm at gcc dot gnu.org
2023-06-07 1:57 ` lili.cui at intel dot com
2023-06-07 8:18 ` jamborm at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).