public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug libstdc++/110077] [14 regression] libstdc++-abi/abi_check FAILs on Solaris Date: Wed, 19 Jul 2023 20:14:51 +0000 [thread overview] Message-ID: <bug-110077-4-A8fA92jUOe@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-110077-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110077 --- Comment #15 from Jonathan Wakely <redi at gcc dot gnu.org> --- I now think the right fix is: --- a/libstdc++-v3/src/c++17/floating_from_chars.cc +++ b/libstdc++-v3/src/c++17/floating_from_chars.cc @@ -1325,24 +1325,14 @@ _ZSt10from_charsPKcS0_RDF128_St12chars_format(const char* first, __ieee128& value, chars_format fmt) noexcept __attribute__((alias ("_ZSt10from_charsPKcS0_Ru9__ieee128St12chars_format"))); -#elif __FLT128_MANT_DIG__ == 113 && __LDBL_MANT_DIG__ != 113 +#elif defined(USE_STRTOF128_FOR_FROM_CHARS) // Overload for _Float128 is not defined inline in <charconv>, define it here. from_chars_result from_chars(const char* first, const char* last, _Float128& value, chars_format fmt) noexcept { -#ifdef USE_STRTOF128_FOR_FROM_CHARS // fast_float doesn't support IEEE binary128 format, but we can use strtold. return from_chars_strtod(first, last, value, fmt); -#else - // Read a long double. This might give an incorrect result (e.g. values - // out of range of long double give an error, even if they fit in _Float128). - long double ldbl_val; - auto res = std::from_chars(first, last, ldbl_val, fmt); - if (res.ec == errc{}) - value = ldbl_val; - return res; -#endif } #endif I think r14-1431-g7037e7b6e4ac41 was wrong to try to define that overload unconditionally. Not all targets need it, so defining the lossy fallback using long double is not useful (and caused this ABI change on Solaris x86).
next prev parent reply other threads:[~2023-07-19 20:14 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-06-01 10:57 [Bug libstdc++/110077] New: " ro at gcc dot gnu.org 2023-06-01 10:57 ` [Bug libstdc++/110077] " ro at gcc dot gnu.org 2023-06-01 10:58 ` redi at gcc dot gnu.org 2023-06-01 11:00 ` redi at gcc dot gnu.org 2023-06-09 10:17 ` redi at gcc dot gnu.org 2023-06-09 12:26 ` cvs-commit at gcc dot gnu.org 2023-06-09 12:26 ` redi at gcc dot gnu.org 2023-06-12 11:26 ` ro at gcc dot gnu.org 2023-06-29 12:46 ` redi at gcc dot gnu.org 2023-06-29 12:54 ` ro at gcc dot gnu.org 2023-06-29 12:55 ` ro at gcc dot gnu.org 2023-06-29 13:33 ` redi at gcc dot gnu.org 2023-06-29 14:41 ` redi at gcc dot gnu.org 2023-06-29 14:42 ` redi at gcc dot gnu.org 2023-06-29 14:52 ` redi at gcc dot gnu.org 2023-06-30 13:54 ` ro at CeBiTec dot Uni-Bielefeld.DE 2023-06-30 14:47 ` redi at gcc dot gnu.org 2023-07-19 20:14 ` redi at gcc dot gnu.org [this message] 2023-07-19 22:43 ` cvs-commit at gcc dot gnu.org 2023-07-19 22:45 ` redi at gcc dot gnu.org 2023-07-21 11:35 ` ro at CeBiTec dot Uni-Bielefeld.DE 2023-07-21 13:04 ` redi at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-110077-4-A8fA92jUOe@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).