[Bug target/110144] New: cris-unknown-elf cross build fails with ICE if RTL checking is enabled

[Bug target/110144] New: cris-unknown-elf cross build fails with ICE if RTL checking is enabled

[dimitar at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110144

            Bug ID: 110144
           Summary: cris-unknown-elf cross build fails with ICE if RTL
                    checking is enabled
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: minor
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dimitar at gcc dot gnu.org
  Target Milestone: ---

I'm trying to cross build the current trunk:

  $ configure --target=cris-unknown-elf --with-newlib --without-headers
--enable-languages=c --disable-nls --disable-libssp --enable-checking=yes,rtl

But the configure stage for libgcc fails with:

configure:3814:
/home/dinux/projects/pru/local-workspace/cris-gcc-build/./gcc/xgcc
-B/home/dinux/projects/pru/local-workspace/cris-gcc-build/./gcc/
-B/usr/local/cris-unknown-elf/bin/ -B/usr/local/cris-unknown-elf/lib/ -isystem
/usr/local/cris-unknown-elf/include -isystem
/usr/local/cris-unknown-elf/sys-include    -c -g -O2  conftest.c >&5
during RTL pass: mach2
conftest.c: In function 'main':
conftest.c:16:1: internal compiler error: RTL check: expected elt 3 type 'e' or
'u', have '0' (rtx note) in PATTERN, at rtl.h:1511
   16 | }
      | ^
0x6c9a81 rtl_check_failed_type2(rtx_def const*, int, int, int, char const*,
int, char const*)
        ../../gcc/gcc/rtl.cc:907
0x767bb8 PATTERN(rtx_def*)
        ../../gcc/gcc/rtl.h:1511
0x768158 PATTERN(rtx_def*)
        ../../gcc/gcc/rtl.h:1479
0x768158 cris_postdbr_cmpelim
        ../../gcc/gcc/config/cris/cris.cc:378
0x768158 execute
        ../../gcc/gcc/config/cris/cris.cc:331


Note that without "--enable-checking=yes,rtl" the cross toolchain compilation
is successful.

[Bug target/110144] cris-unknown-elf cross build fails with ICE if RTL checking is enabled

[hp at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110144

Hans-Peter Nilsson <hp at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2023-06-28
                 CC|                            |hp at gcc dot gnu.org
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |hp at gcc dot gnu.org

--- Comment #1 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
Thanks for the report.  Confirmed.  I'm on it; testing a first patch candidate.

[Bug target/110144] cris-unknown-elf cross build fails with ICE if RTL checking is enabled

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110144

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Hans-Peter Nilsson <hp@gcc.gnu.org>:

https://gcc.gnu.org/g:c15905da939fd5cf6ccc3f19f3ab273525f34f98

commit r14-2173-gc15905da939fd5cf6ccc3f19f3ab273525f34f98
Author: Hans-Peter Nilsson <hp@axis.com>
Date:   Wed Jun 28 03:01:08 2023 +0200

    CRIS: Don't apply PATTERN to insn before validation (PR 110144)

    Oops.  The validation was there, but PATTERN was applied
    before that.  Noticeable only with rtl-checking (for example
    as in the report: "--enable-checking=yes,rtl") as this
    statement was only a (one of many) straggling olde-C
    declare-and-initialize-at-beginning-of-block thing.

            PR target/110144
            * config/cris/cris.cc (cris_postdbr_cmpelim): Don't apply PATTERN
            to insn before validating it.

[Bug target/110144] cris-unknown-elf cross build fails with ICE if RTL checking is enabled

[hp at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110144

Hans-Peter Nilsson <hp at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
   Target Milestone|---                         |14.0
         Resolution|---                         |FIXED

--- Comment #3 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
JFTR, the committed patch, passed a "full" regtest for cris-elf with
--enable-checking=yes,rtl, not just for --enable-languages=c.