[Bug modula2/110189] New: Using an unknown TYPE as argument to VAL gives ICE

[Bug modula2/110189] New: Using an unknown TYPE as argument to VAL gives ICE

[admin@tho-otto.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110189

            Bug ID: 110189
           Summary: Using an unknown TYPE as argument to VAL gives ICE
           Product: gcc
           Version: 13.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: modula2
          Assignee: gaius at gcc dot gnu.org
          Reporter: admin@tho-otto.de
  Target Milestone: ---

In the following example:

MODULE foo;

VAR x: INTEGER;

BEGIN
  x := VAL(abcd, 0);
END foo.

I get:

M2MetaError.mod:1535:internalformat error detected


errorBlock

type      = abort
out       = ||
in        = |undeclared type found in builtin procedure function {%AkVAL}
{%A1ad}|
Length (out) = 0
len       = 68
highplus1 = 1*** WARNING *** there are active plugins, do not report this as a
bug unless you can reproduce it without enabling any plugins.
Event                            | Plugins
PLUGIN_FINISH                    | m2rte
cc1gm2: internal compiler error: in libc_abort, at m2/mc-boot-ch/Glibc.c:70
0x195d5c6 internal_error(char const*, ...)
        ???:0
0x6f0e97 fancy_abort(char const*, int, char const*)
        ???:0
0x6aa497 libc_abort
        ???:0
0x808f05 FormatStrings_Sprintf1
        ???:0
0x767c73 M2Printf_fprintf1
        ???:0
0x76da13 M2MetaError_MetaErrorStringT1
        ???:0
0x786078 M2Quads_BuildFunctionCall
        ???:0
0x7e59d9 P3Build_CompilationUnit
        ???:0
0x75ba6b M2Comp_compile
        ???:0

[Bug modula2/110189] Using an unknown TYPE as argument to VAL gives ICE

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110189

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2023-06-12
     Ever confirmed|0                           |1

--- Comment #1 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Thanks for the bug report - I've reproduced the error and have a patch in
progress.

[Bug modula2/110189] Using an unknown TYPE as argument to VAL gives ICE

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110189

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gaius at gcc dot gnu.org

--- Comment #2 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Created attachment 55315
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=55315&action=edit
Proposed fix

Here is a proposed patch which will I'll apply when/if a bootstrap completes.

[Bug modula2/110189] Using an unknown TYPE as argument to VAL gives ICE

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110189

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Gaius Mulley <gaius@gcc.gnu.org>:

https://gcc.gnu.org/g:8089f26b94f47d9923d3bc0c05aae09363983b2e

commit r14-1739-g8089f26b94f47d9923d3bc0c05aae09363983b2e
Author: Gaius Mulley <gaiusmod2@gmail.com>
Date:   Tue Jun 13 00:53:53 2023 +0100

    PR modula2/110189 Using an unknown TYPE as argument to VAL gives ICE

    This patch tidies P3Build.bnf and fixes error format specs in
    M2Quads.mod when encountering unknown symbols.

    gcc/m2/ChangeLog:

            PR modula2/110189
            * gm2-compiler/M2Quads.mod (BuildAbsFunction): Replace abort
            format specifier.
            (BuildValFunction): Replace abort format specifier.
            (BuildCastFunction): Replace abort format specifier.
            (BuildMinFunction): Replace abort format specifier.
            (BuildMaxFunction): Replace abort format specifier.
            (BuildTruncFunction): Replace abort format specifier.
            * gm2-compiler/P3Build.bnf (Pass1): Remove.
            (Pass2): Remove.
            (Pass3): Remove.
            (Expect): Add Pass1.
            (AsmStatement): Remove Pass3.
            (AsmOperands): Remove Pass3.
            (AsmOperandSpec): Remove Pass3.
            (AsmInputElement): Remove Pass3.
            (AsmOutputElement): Remove Pass3.
            (AsmTrashList): Remove Pass3.

    gcc/testsuite/ChangeLog:

            PR modula2/110189
            * gm2/pim/fail/foovaltype.mod: New test.

    Signed-off-by: Gaius Mulley <gaiusmod2@gmail.com>

[Bug modula2/110189] Using an unknown TYPE as argument to VAL gives ICE

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110189

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Many thanks for the bug report - closing now that the patch has been applied.

[Bug modula2/110189] Using an unknown TYPE as argument to VAL gives ICE

[admin@tho-otto.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110189

--- Comment #5 from Thorsten Otto <admin@tho-otto.de> ---
Many thanks for fixing it. But just found, that same thing seems to happen when
using other builtin functions like ORD(). Should i open a new report for this?

[Bug modula2/110189] Using an unknown TYPE as argument to VAL gives ICE

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110189

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Gaius Mulley
<gaius@gcc.gnu.org>:

https://gcc.gnu.org/g:8b0bd9ae4e2927f770da352ac64261411e6d652e

commit r13-7647-g8b0bd9ae4e2927f770da352ac64261411e6d652e
Author: Gaius Mulley <gaiusmod2@gmail.com>
Date:   Sat Jul 29 22:41:13 2023 +0100

    PR modula2/110189 Using an unknown TYPE as argument to VAL gives ICE

    This patch tidies P3Build.bnf and fixes error format specs in
    M2Quads.mod when encountering unknown symbols.

    gcc/m2/ChangeLog:

            PR modula2/110189
            * gm2-compiler/M2Quads.mod (BuildAbsFunction): Replace abort
            format specifier.
            (BuildValFunction): Replace abort format specifier.
            (BuildCastFunction): Replace abort format specifier.
            (BuildMinFunction): Replace abort format specifier.
            (BuildMaxFunction): Replace abort format specifier.
            (BuildTruncFunction): Replace abort format specifier.
            * gm2-compiler/P3Build.bnf (Pass1): Remove.
            (Pass2): Remove.
            (Pass3): Remove.
            (Expect): Add Pass1.
            (AsmStatement): Remove Pass3.
            (AsmOperands): Remove Pass3.
            (AsmOperandSpec): Remove Pass3.
            (AsmInputElement): Remove Pass3.
            (AsmOutputElement): Remove Pass3.
            (AsmTrashList): Remove Pass3.

    gcc/testsuite/ChangeLog:

            PR modula2/110189
            * gm2/pim/fail/foovaltype.mod: New test.

    (cherry picked from commit 8089f26b94f47d9923d3bc0c05aae09363983b2e)

    Signed-off-by: Gaius Mulley <gaiusmod2@gmail.com>