[Bug c/110205] New: Some new warnings from clang for the range code

[Bug c/110205] New: Some new warnings from clang for the range code

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110205

            Bug ID: 110205
           Summary: Some new warnings from clang for the range code
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dcb314 at hotmail dot com
  Target Milestone: ---

I just did a build of gcc trunk with clang. It said

../../trunk.year/gcc/range-op-mixed.h:215:8: warning: 'fold_range' overrides a
member function but is not marked 'override' [-Winconsistent-missing-override]
../../trunk.year/gcc/range-op-mixed.h:222:8: warning: 'op1_range' overrides a
member function but is not marked 'override' [-Winconsistent-missing-override]
../../trunk.year/gcc/range-op-mixed.h:229:8: warning: 'op2_range' overrides a
member function but is not marked 'override' [-Winconsistent-missing-override]
../../trunk.year/gcc/range-op-mixed.h:236:8: warning: 'update_bitmask'
overrides a member function but is not marked 'override'
[-Winconsistent-missing-override]
../../trunk.year/gcc/range-op.cc:169:16: warning: unused variable 'RO_FII'
[-Wunused-const-variable]
../../trunk.year/gcc/range-op.cc:2292:8: warning: 'update_bitmask' overrides a
member function but is not marked 'override' [-Winconsistent-missing-override]

These might be worth fixing. The unused variable might be a typo or some
missing code.

[Bug c/110205] Some new warnings from clang for the range code

[amacleod at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110205

Andrew Macleod <amacleod at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amacleod at redhat dot com

--- Comment #1 from Andrew Macleod <amacleod at redhat dot com> ---
There is a second set of patches coming, I will make sure anything that remains
from this list is addressed when they go in.

[Bug c/110205] Some new warnings from clang for the range code

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110205

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Andrew Macleod <amacleod@gcc.gnu.org>:

https://gcc.gnu.org/g:0ddc8c7871fdc7748315d9c09fcf29c2607a1077

commit r14-1735-g0ddc8c7871fdc7748315d9c09fcf29c2607a1077
Author: Andrew MacLeod <amacleod@redhat.com>
Date:   Mon Jun 12 09:47:43 2023 -0400

    Add some overrides.

            PR tree-optimization/110205
            * range-op-float.cc (range_operator::fold_range): Add default FII
            fold routine.
            * range-op-mixed.h (class operator_gt): Add missing final
overrides.
            * range-op.cc (range_op_handler::fold_range): Add RO_FII case.
            (operator_lshift ::update_bitmask): Add final override.
            (operator_rshift ::update_bitmask): Add final override.
            * range-op.h (range_operator::fold_range): Add FII prototype.

[Bug c/110205] Some new warnings from clang for the range code

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110205

--- Comment #3 from David Binderman <dcb314 at hotmail dot com> ---
Nearly a month later, the current list of clang warnings for the range code is:

../../trunk.year/gcc/gimple-range-cache.h:140:17: warning: private field
'm_estimate' is not used [-Wunused-private-field]
../../trunk.year/gcc/range-op-mixed.h:567:8: warning: 'op1_op2_relation_effect'
overrides a member function but is not marked 'override'
[-Winconsistent-missing-override]
../../trunk.year/gcc/range-op.cc:2254:8: warning: 'update_bitmask' overrides a
member function but is not marked 'override' [-Winconsistent-missing-override]
../../trunk.year/gcc/range-op.cc:2392:16: warning: 'op1_range' overrides a
member function but is not marked 'override' [-Winconsistent-missing-override]
../../trunk.year/gcc/range-op.cc:2396:16: warning: 'fold_range' overrides a
member function but is not marked 'override' [-Winconsistent-missing-override]
../../trunk.year/gcc/range-op.cc:2401:16: warning: 'wi_fold' overrides a member
function but is not marked 'override' [-Winconsistent-missing-override]
../../trunk.year/gcc/range-op.cc:2404:16: warning: 'wi_op_overflows' overrides
a member function but is not marked 'override'
[-Winconsistent-missing-override]
../../trunk.year/gcc/range-op.cc:2419:16: warning: 'fold_range' overrides a
member function but is not marked 'override' [-Winconsistent-missing-override]
../../trunk.year/gcc/range-op.cc:2423:16: warning: 'wi_fold' overrides a member
function but is not marked 'override' [-Winconsistent-missing-override]
../../trunk.year/gcc/range-op.cc:2428:16: warning: 'wi_op_overflows' overrides
a member function but is not marked 'override'
[-Winconsistent-missing-override]
../../trunk.year/gcc/range-op.cc:2432:16: warning: 'op1_range' overrides a
member function but is not marked 'override' [-Winconsistent-missing-override]
../../trunk.year/gcc/range-op.cc:2436:25: warning: 'lhs_op1_relation' overrides
a member function but is not marked 'override'
[-Winconsistent-missing-override]

These might be worth fixing.

[Bug other/110205] Some new warnings from clang for the range code

[xry111 at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110205

Xi Ruoyao <xry111 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|c                           |other
                 CC|                            |xry111 at gcc dot gnu.org

--- Comment #4 from Xi Ruoyao <xry111 at gcc dot gnu.org> ---
We need a general decision.  If we think these warning must fixed, we'd better
enable the equivalent GCC warnings for bootstrapping too.

[Bug other/110205] Some new warnings from clang for the range code

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110205

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Andrew Macleod <amacleod@gcc.gnu.org>:

https://gcc.gnu.org/g:7905c071c35070fff3397b1e24f140c128c08e64

commit r14-2859-g7905c071c35070fff3397b1e24f140c128c08e64
Author: Andrew MacLeod <amacleod@redhat.com>
Date:   Mon Jul 10 13:58:22 2023 -0400

    Fix some warnings

            PR tree-optimization/110205
            * gimple-range-cache.h (ranger_cache::m_estimate): Delete.
            * range-op-mixed.h (operator_bitwise_xor::op1_op2_relation_effect):
            Add final override.
            * range-op.cc (operator_lshift): Add missing final overrides.
            (operator_rshift): Ditto.

[Bug other/110205] Some new warnings from clang for the range code

[amacleod at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110205

Andrew Macleod <amacleod at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #6 from Andrew Macleod <amacleod at redhat dot com> ---
fixed.

[Bug other/110205] Some new warnings from clang for the range code

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110205

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |14.0