public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/110252] [14 Regression] Wrong code at -O2/3/s on x86_64-linux-gnu Date: Wed, 19 Jul 2023 16:19:34 +0000 [thread overview] Message-ID: <bug-110252-4-OPTVnkF5U6@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-110252-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110252 --- Comment #18 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The trunk branch has been updated by Andrew Pinski <pinskia@gcc.gnu.org>: https://gcc.gnu.org/g:8c79b49cd4fa742f7be739dd21fd2aa040cc1ba3 commit r14-2650-g8c79b49cd4fa742f7be739dd21fd2aa040cc1ba3 Author: Andrew Pinski <apinski@marvell.com> Date: Fri Jul 14 15:55:34 2023 -0700 [PATCH] Fix tree-opt/110252: wrong code due to phiopt using flow sensitive info during match Match will query ranger via tree_nonzero_bits/get_nonzero_bits for 2 and 3rd operand of the COND_EXPR and phiopt tries to do create the COND_EXPR even if we moving one statement. That one statement could have some flow sensitive information on it based on the condition that is for the COND_EXPR but that might create wrong code if the statement was moved out. This is similar to the previous version of the patch except now we use flow_sensitive_info_storage instead of manually doing the save/restore and also handle all defs on a gimple statement rather than just for lhs of the gimple statement. Oh and a few more testcases were added that was failing before. OK? Bootsrapped and tested on x86_64-linux-gnu with no regressions. PR tree-optimization/110252 gcc/ChangeLog: * tree-ssa-phiopt.cc (class auto_flow_sensitive): New class. (auto_flow_sensitive::auto_flow_sensitive): New constructor. (auto_flow_sensitive::~auto_flow_sensitive): New deconstructor. (match_simplify_replacement): Temporarily remove the flow sensitive info on the two statements that might be moved. gcc/testsuite/ChangeLog: * gcc.dg/tree-ssa/phi-opt-25b.c: Updated as __builtin_parity loses the nonzerobits info. * gcc.c-torture/execute/pr110252-1.c: New test. * gcc.c-torture/execute/pr110252-2.c: New test. * gcc.c-torture/execute/pr110252-3.c: New test. * gcc.c-torture/execute/pr110252-4.c: New test.
next prev parent reply other threads:[~2023-07-19 16:19 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-06-14 14:52 [Bug c/110252] New: " shaohua.li at inf dot ethz.ch 2023-06-14 16:13 ` [Bug tree-optimization/110252] [14 Regression] " pinskia at gcc dot gnu.org 2023-06-14 21:09 ` pinskia at gcc dot gnu.org 2023-06-15 2:13 ` pinskia at gcc dot gnu.org 2023-06-15 3:11 ` pinskia at gcc dot gnu.org 2023-06-15 6:22 ` rguenth at gcc dot gnu.org 2023-06-15 6:22 ` rguenth at gcc dot gnu.org 2023-06-21 22:51 ` pinskia at gcc dot gnu.org 2023-06-22 15:36 ` pinskia at gcc dot gnu.org 2023-06-28 20:31 ` pinskia at gcc dot gnu.org 2023-06-28 20:35 ` pinskia at gcc dot gnu.org 2023-06-29 9:22 ` zhendong.su at inf dot ethz.ch 2023-06-29 15:42 ` pinskia at gcc dot gnu.org 2023-06-30 5:18 ` pinskia at gcc dot gnu.org 2023-07-03 11:31 ` pinskia at gcc dot gnu.org 2023-07-06 6:12 ` pinskia at gcc dot gnu.org 2023-07-08 17:16 ` pinskia at gcc dot gnu.org 2023-07-15 3:21 ` pinskia at gcc dot gnu.org 2023-07-19 7:41 ` pinskia at gcc dot gnu.org 2023-07-19 16:19 ` cvs-commit at gcc dot gnu.org [this message] 2023-07-19 16:19 ` pinskia at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-110252-4-OPTVnkF5U6@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).