[Bug ipa/110276] New: [13 Regression] ICE building efibootguard on x86_64-linux-gnu

[Bug ipa/110276] New: [13 Regression] ICE building efibootguard on x86_64-linux-gnu

[doko at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110276

            Bug ID: 110276
           Summary: [13 Regression] ICE building efibootguard on
                    x86_64-linux-gnu
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: ipa
          Assignee: unassigned at gcc dot gnu.org
          Reporter: doko at gcc dot gnu.org
                CC: marxin at gcc dot gnu.org
  Target Milestone: ---

seen with the gcc-13 branch 20230611 on x86_64-linux-gnu:

works with -O1, fails with -O2

$ cat itco.i
typedef long (*EFI_PCI_IO_PROTOCOL_CONFIG)();
typedef struct {
  EFI_PCI_IO_PROTOCOL_CONFIG Read;
} EFI_PCI_IO_PROTOCOL_CONFIG_ACCESS;
typedef struct {
  EFI_PCI_IO_PROTOCOL_CONFIG_ACCESS Pci;
} EFI_PCI_IO_PROTOCOL;
int init_regs_0;
static void __attribute__((constructor)) init(EFI_PCI_IO_PROTOCOL *pci_io) {
  if (init_regs_0)
    pci_io->Pci.Read();
}
$ gcc -c -O2 -std=gnu99 -fpic -fshort-wchar -ffreestanding -fno-strict-aliasing
-fno-stack-protector itco.i 
during IPA pass: sra
itco.i:12:1: internal compiler error: in adjust_parameter_descriptions, at
ipa-sra.cc:4263
   12 | }
      | ^
0x74317d adjust_parameter_descriptions
        ../../src/gcc/ipa-sra.cc:4263
0x74317d ipa_sra_analysis
        ../../src/gcc/ipa-sra.cc:4427
0x74317d execute
        ../../src/gcc/ipa-sra.cc:4554
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.

[Bug ipa/110276] [13/14 Regression] ICE building efibootguard on x86_64-linux-gnu

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110276

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unknown                     |13.1.1
           Priority|P3                          |P2
   Target Milestone|---                         |13.2
            Summary|[13 Regression] ICE         |[13/14 Regression] ICE
                   |building efibootguard on    |building efibootguard on
                   |x86_64-linux-gnu            |x86_64-linux-gnu
   Last reconfirmed|                            |2023-06-16
     Ever confirmed|0                           |1
                 CC|                            |jamborm at gcc dot gnu.org
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Huh, I could swear we had a duplicate ...

Confirmed on trunk.

[Bug ipa/110276] [13/14 Regression] ICE building efibootguard on x86_64-linux-gnu

[jamborm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110276

Martin Jambor <jamborm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |jamborm at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #2 from Martin Jambor <jamborm at gcc dot gnu.org> ---
Mine

[Bug ipa/110276] [13/14 Regression] ICE building efibootguard on x86_64-linux-gnu

[jamborm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110276

--- Comment #3 from Martin Jambor <jamborm at gcc dot gnu.org> ---
I have proposed a fix on the mailing list:

https://gcc.gnu.org/pipermail/gcc-patches/2023-June/622019.html

[Bug ipa/110276] [13/14 Regression] ICE building efibootguard on x86_64-linux-gnu

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110276

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Jambor <jamborm@gcc.gnu.org>:

https://gcc.gnu.org/g:0be3a051c03965c5c0385b783837154902bc08fa

commit r14-1998-g0be3a051c03965c5c0385b783837154902bc08fa
Author: Martin Jambor <mjambor@suse.cz>
Date:   Tue Jun 20 18:15:22 2023 +0200

    ipa-sra: Disable candidates with no known callers (PR 110276)

    In IPA-SRA we use can_be_local_p () predicate rather than just plain
    local call graph flag in order to figure out whether the node is a
    part of an external API that we cannot change.  Although there are
    cases where this can allow more transformations, it also means we can
    analyze functions which have no callers at all, which is pointless.

    Moreover, it makes an assert of hint propagation trigger, which checks
    that we have looked at callers before processing hints that come from
    them.  This has been reported as PR 110276.

    This patch simply adds a check that a node has at least one caller
    into the early checks and makes the node a non-candidate for any
    transformation if it does not.

    gcc/ChangeLog:

    2023-06-16  Martin Jambor  <mjambor@suse.cz>

            PR ipa/110276
            * ipa-sra.cc (struct caller_issues): New field there_is_one.
            (check_for_caller_issues): Set it.
            (check_all_callers_for_issues): Check it.

    gcc/testsuite/ChangeLog:

    2023-06-16  Martin Jambor  <mjambor@suse.cz>

            PR ipa/110276
            * gcc.dg/ipa/pr110276.c: New test.

[Bug ipa/110276] [13/14 Regression] ICE building efibootguard on x86_64-linux-gnu

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110276

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Martin Jambor
<jamborm@gcc.gnu.org>:

https://gcc.gnu.org/g:7085905d7842e71af7a59c7d20d050716dd22e9b

commit r13-7483-g7085905d7842e71af7a59c7d20d050716dd22e9b
Author: Martin Jambor <mjambor@suse.cz>
Date:   Tue Jun 27 18:01:13 2023 +0200

    ipa-sra: Disable candidates with no known callers (PR 110276)

    In IPA-SRA we use can_be_local_p () predicate rather than just plain
    local call graph flag in order to figure out whether the node is a
    part of an external API that we cannot change.  Although there are
    cases where this can allow more transformations, it also means we can
    analyze functions which have no callers at all, which is pointless.

    Moreover, it makes an assert of hint propagation trigger, which checks
    that we have looked at callers before processing hints that come from
    them.  This has been reported as PR 110276.

    This patch simply adds a check that a node has at least one caller
    into the early checks and makes the node a non-candidate for any
    transformation if it does not.

    gcc/ChangeLog:

    2023-06-16  Martin Jambor  <mjambor@suse.cz>

            PR ipa/110276
            * ipa-sra.cc (struct caller_issues): New field there_is_one.
            (check_for_caller_issues): Set it.
            (check_all_callers_for_issues): Check it.

    gcc/testsuite/ChangeLog:

    2023-06-16  Martin Jambor  <mjambor@suse.cz>

            PR ipa/110276
            * gcc.dg/ipa/pr110276.c: New test.

    (cherry picked from commit 8a665a8d3b45c947d5793e2c9c3df8a1c0302f03)

[Bug ipa/110276] [13/14 Regression] ICE building efibootguard on x86_64-linux-gnu

[jamborm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110276

Martin Jambor <jamborm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #6 from Martin Jambor <jamborm at gcc dot gnu.org> ---
Fixed on both master and the 13 branch.