[Bug c/110280] New: internal compiler error: in const_unop, at fold-const.cc:1884

[Bug c/110280] New: internal compiler error: in const_unop, at fold-const.cc:1884

[malat at debian dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110280

            Bug ID: 110280
           Summary: internal compiler error: in const_unop, at
                    fold-const.cc:1884
           Product: gcc
           Version: 13.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: malat at debian dot org
  Target Milestone: ---

I cannot compile highway on arm64 with gcc-13.

Compilation fails with:

 % /usr/bin/g++-13 -freport-bug -DHWY_SHARED_DEFINE
-I"/home/malat/arm64/highway-1.0.5~git20230612.46fb57d" -g -O2
-ffile-prefix-map=/home/malat/arm64/highway-1.0.5~git20230612.46fb57d=.
-fstack-protector-strong -Wformat -Werror=format-security -DHWY_BROKEN_EMU128=0
-Wdate-time -D_FORTIFY_SOURCE=2 -fPIE -fvisibility=hidden
-fvisibility-inlines-hidden -Wno-builtin-macro-redefined
-D__DATE__=\"redacted\" -D__TIMESTAMP__=\"redacted\" -D__TIME__=\"redacted\"
-fmerge-all-constants -Wall -Wextra -Wconversion -Wsign-conversion -Wvla
-Wnon-virtual-dtor -fmath-errno -fno-exceptions -Werror -DHWY_IS_TEST=1
-DGTEST_HAS_PTHREAD=1 -MD -MT
CMakeFiles/swizzle_test.dir/hwy/tests/swizzle_test.cc.o -MF
CMakeFiles/swizzle_test.dir/hwy/tests/swizzle_test.cc.o.d -o
CMakeFiles/swizzle_test.dir/hwy/tests/swizzle_test.cc.o -c
'/home/malat/arm64/highway-1.0.5~git20230612.46fb57d/hwy/tests/swizzle_test.cc'
during GIMPLE pass: fre
/home/malat/arm64/highway-1.0.5~git20230612.46fb57d/hwy/tests/swizzle_test.cc:
In static member function 'static void
hwy::N_SVE::TestPer4LaneBlockShuffle::TestTblLookupPer4LaneBlkShuf(D, size_t,
hwy::N_SVE::TFromD<D>*, hwy::N_SVE::TFromD<D>*) [with D = hwy::N_SVE::Simd<long
int, 32, 0>]':
/home/malat/arm64/highway-1.0.5~git20230612.46fb57d/hwy/tests/swizzle_test.cc:787:1:
internal compiler error: in const_unop, at fold-const.cc:1884
  787 | }  // namespace hwy
      | ^
0xcd88f7 const_unop(tree_code, tree_node*, tree_node*)
        ../../src/gcc/fold-const.cc:1884
0xdfbadb gimple_resimplify1
        ../../src/gcc/gimple-match-head.cc:214
0xdcbee3 gimple_simplify(gimple*, gimple_match_op*, gimple**, tree_node*
(*)(tree_node*), tree_node* (*)(tree_node*))
        ../../src/gcc/gimple-match-head.cc:1115
0xfdec5f gimple_fold_stmt_to_constant_1(gimple*, tree_node* (*)(tree_node*),
tree_node* (*)(tree_node*))
        ../../src/gcc/gimple-fold.cc:7444
0xfdc88f try_to_simplify
        ../../src/gcc/tree-ssa-sccvn.cc:6076
0xfdc88f visit_stmt
        ../../src/gcc/tree-ssa-sccvn.cc:6119
0xfd6d9f process_bb
        ../../src/gcc/tree-ssa-sccvn.cc:7925
0xfcc1ff do_rpo_vn_1
        ../../src/gcc/tree-ssa-sccvn.cc:8411
0x108dedb execute
        ../../src/gcc/tree-ssa-sccvn.cc:8683
Please submit a full bug report, with preprocessed source.
Please include the complete backtrace with any bug report.
See <file:///usr/share/doc/gcc-13/README.Bugs> for instructions.
Preprocessed source stored into /tmp/ccLfBeeb.out file, please attach this to
your bugreport.

[Bug c/110280] internal compiler error: in const_unop, at fold-const.cc:1884

[malat at debian dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110280

--- Comment #1 from Mathieu Malaterre <malat at debian dot org> ---
Created attachment 55340
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=55340&action=edit
preprocessed source

[Bug target/110280] internal compiler error: in const_unop, at fold-const.cc:1884

[ktkachov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110280

ktkachov at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
                 CC|                            |ktkachov at gcc dot gnu.org
   Last reconfirmed|                            |2023-06-16
             Status|UNCONFIRMED                 |NEW
             Target|arm64                       |aarch64

--- Comment #2 from ktkachov at gcc dot gnu.org ---
Confirmed, reducing.

[Bug tree-optimization/110280] internal compiler error: in const_unop, at fold-const.cc:1884

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110280

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
#6  0x000000000087710b in const_unop (code=VEC_UNPACK_LO_EXPR, type=<optimized
out>, arg0=<optimized out>) at ../../gcc/fold-const.cc:1954
1954            gcc_assert (known_eq (out_nelts, TYPE_VECTOR_SUBPARTS (type)));

[Bug tree-optimization/110280] internal compiler error: in const_unop, at fold-const.cc:1884

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110280

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(gdb) p debug_gimple_stmt(stmt)
_41 = [vec_unpack_lo_expr] _40;

[Bug tree-optimization/110280] internal compiler error: in const_unop, at fold-const.cc:1884

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110280

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.2
      Known to fail|                            |13.1.0

--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
First reduced testcase with the same ICE:
```
#include "arm_sve.h"
auto l() {
  svuint32_t ttt;
  {
    alignas(16) const unsigned int lanes[4] = {0, 0, 0, 0};
    ttt = svld1rq_u32(svptrue_b8(), lanes);
  }
  return svunpklo_u64 (ttt);
}
```

Another reduced testcase with a related ICE:
```
#include "arm_sve.h"
svuint32_t l() {
  alignas(16) const unsigned int lanes[4] = {0, 0, 0, 0};
  return svld1rq_u32(svptrue_b8(), lanes);
}
```

For the first one, we have:
```
  lanes[0] = 0;
  lanes[1] = 0;
  lanes[2] = 0;
  lanes[3] = 0;
  _10 = MEM <vector(4) unsigned int> [(unsigned int * {ref-all})&lanes];
  ttt_7 = VEC_PERM_EXPR <_10, _10, { 0, 1, 2, 3, ... }>;
  lanes ={v} {CLOBBER(eol)};
  _9 = [vec_unpack_lo_expr] ttt_7;
```
The ICE is on simplifying _9.
The second one we have a similar thing except no vec_unpack_lo_expr there.

I suspect it is the simplification of the VEC_PERM which is causing the issue
rather than vec_unpack_lo_expr directly.
And dealing with how _10 is generated inside fre to a vector.

[Bug tree-optimization/110280] internal compiler error: in const_unop, at fold-const.cc:1884

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110280

--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Match-and-simplified VEC_PERM_EXPR <_10, _10, { 0, 1, 2, 3, ... }> to { 0, 0,
0, 0 }


Ok, that is wrong ...

[Bug tree-optimization/110280] internal compiler error: in const_unop, at fold-const.cc:1884

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110280

--- Comment #7 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
I think this part of match is incorrect:
    (if (sel.series_p (0, 1, 0, 1))
     { op0; }
     (if (sel.series_p (0, 1, nelts, 1))
      { op1; }

This is only true if type == TREE_TYPE (op0) (well compatible) ...

[Bug tree-optimization/110280] internal compiler error: in const_unop, at fold-const.cc:1884

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110280

--- Comment #8 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
In the original case FRE is trying to do the same thing as the reduced
testcase:
```
Successfully combined 4 partial definitions
Setting value number of _39 to { 0, 0, 0, 0 } (changed)
Value numbering stmt = _40 = VEC_PERM_EXPR <_39, _39, { 0, 1, 2, 3, ... }>;
Match-and-simplified VEC_PERM_EXPR <_39, _39, { 0, 1, 2, 3, ... }> to { 0, 0,
0, 0 }
RHS VEC_PERM_EXPR <_39, _39, { 0, 1, 2, 3, ... }> simplified to { 0, 0, 0, 0 }
Setting value number of _40 to { 0, 0, 0, 0 } (changed)
Value numbering stmt = lanes ={v} {CLOBBER(eol)};
Setting value number of .MEM_54 to .MEM_54 (changed)
Value numbering stmt = _41 = [vec_unpack_lo_expr] _40;
```

[Bug tree-optimization/110280] internal compiler error: in const_unop, at fold-const.cc:1884

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110280

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://gcc.gnu.org/bugzill
                   |                            |a/show_bug.cgi?id=96463

--- Comment #9 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
The creation of that VEC_PERM comes started at r13-1055-g494bec025002df422f2f
(aka PR 96463). 

The VEC_PERM match-and-simplify was not updated for the new semantics it seems
(it was added at r10-507-gebd733a78ccf ).

[Bug tree-optimization/110280] [13/14 Regression] internal compiler error: in const_unop, at fold-const.cc:1884

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110280

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|internal compiler error: in |[13/14 Regression] internal
                   |const_unop, at              |compiler error: in
                   |fold-const.cc:1884          |const_unop, at
                   |                            |fold-const.cc:1884
           Priority|P3                          |P2
                 CC|                            |rsandifo at gcc dot gnu.org

--- Comment #10 from Richard Biener <rguenth at gcc dot gnu.org> ---
Can SVE folks please have a look here?

[Bug tree-optimization/110280] [13/14 Regression] internal compiler error: in const_unop, at fold-const.cc:1884

[prathamesh3492 at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110280

prathamesh3492 at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |prathamesh3492 at gcc dot gnu.org

--- Comment #11 from prathamesh3492 at gcc dot gnu.org ---
Hi, sorry for the breakage, I will take a look.

Thanks,
Prathamesh

[Bug tree-optimization/110280] [13/14 Regression] internal compiler error: in const_unop, at fold-const.cc:1884

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110280

--- Comment #12 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Prathamesh Kulkarni
<prathamesh3492@gcc.gnu.org>:

https://gcc.gnu.org/g:85d8e0d8d5342ec8b4e6a54e22741c30b33c6f04

commit r14-2044-g85d8e0d8d5342ec8b4e6a54e22741c30b33c6f04
Author: Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org>
Date:   Fri Jun 23 15:27:17 2023 +0530

    [aarch64/match.pd] Fix ICE observed in PR110280.

    gcc/ChangeLog:
            PR tree-optimization/110280
            * match.pd (vec_perm_expr(v, v, mask) -> v): Explicitly build
vector
            using build_vector_from_val with the element of input operand, and
            mask's type if operand and mask's types don't match.

    gcc/testsuite/ChangeLog:
            PR tree-optimization/110280
            * gcc.target/aarch64/sve/pr110280.c: New test.

[Bug tree-optimization/110280] [13/14 Regression] internal compiler error: in const_unop, at fold-const.cc:1884

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110280

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alice at ayaya dot dev

--- Comment #13 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 110804 has been marked as a duplicate of this bug. ***

[Bug tree-optimization/110280] [13 Regression] internal compiler error: in const_unop, at fold-const.cc:1884

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110280

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[13/14 Regression] internal |[13 Regression] internal
                   |compiler error: in          |compiler error: in
                   |const_unop, at              |const_unop, at
                   |fold-const.cc:1884          |fold-const.cc:1884
      Known to work|                            |14.0
             Status|NEW                         |ASSIGNED
      Known to fail|14.0                        |

--- Comment #14 from Richard Biener <rguenth at gcc dot gnu.org> ---
Unfortunately the bugreport wasn't updated for the trunk fix so we didn't
notice a missing backport, has to wait for 13.3 now.

[Bug tree-optimization/110280] [13 Regression] internal compiler error: in const_unop, at fold-const.cc:1884

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110280

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|13.2                        |13.3

--- Comment #15 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 13.2 is being released, retargeting bugs to GCC 13.3.

[Bug tree-optimization/110280] [13 Regression] internal compiler error: in const_unop, at fold-const.cc:1884

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110280

--- Comment #16 from Sam James <sjames at gcc dot gnu.org> ---
Prathamesh, could you cherry-pick this on to the releases/13 branch please?

[Bug tree-optimization/110280] [13 Regression] internal compiler error: in const_unop, at fold-const.cc:1884

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110280

--- Comment #17 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Prathamesh Kulkarni
<prathamesh3492@gcc.gnu.org>:

https://gcc.gnu.org/g:f4029de35fb1b293a4fd586574b1b4b73ddf7880

commit r13-7661-gf4029de35fb1b293a4fd586574b1b4b73ddf7880
Author: Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org>
Date:   Wed Jul 26 22:36:26 2023 +0530

    [aarch64/match.pd] Fix ICE observed in PR110280.

    gcc/ChangeLog:
            PR tree-optimization/110280
            * match.pd (vec_perm_expr(v, v, mask) -> v): Explicitly build
vector
            using build_vector_from_val with the element of input operand, and
            mask's type if operand and mask's types don't match.

    gcc/testsuite/ChangeLog:
            PR tree-optimization/110280
            * gcc.target/aarch64/sve/pr110280.c: New test.

    (cherry picked from commit 85d8e0d8d5342ec8b4e6a54e22741c30b33c6f04)

[Bug tree-optimization/110280] [13 Regression] internal compiler error: in const_unop, at fold-const.cc:1884

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110280

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
      Known to fail|                            |13.2.0
      Known to work|                            |13.2.1

--- Comment #18 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.