public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/110316] [10/11/12/13/14 Regression] g++.dg/ext/timevar1.C and timevar2.C fail erratically
Date: Tue, 20 Jun 2023 06:58:32 +0000 [thread overview]
Message-ID: <bug-110316-4-Ta0KSG7x4v@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-110316-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110316
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
Target Milestone|--- |10.5
Known to fail| |4.8.0
Last reconfirmed| |2023-06-20
Component|testsuite |middle-end
Summary|[14 regression] |[10/11/12/13/14 Regression]
|g++.dg/ext/timevar1.C and |g++.dg/ext/timevar1.C and
|timevar2.C fail erratically |timevar2.C fail erratically
Keywords| |ice-on-valid-code
Status|UNCONFIRMED |NEW
Known to work| |4.7.0
--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
I would not call this a regression from GCC 13 but from much earlier,
r0-117422-ga910399dfd44.
The check is definitely wrong since wall difference is less than ticks_to_msec
here.
Most likely the check should be rather:
if (phase_user > total->user + toleranceu
|| phase_sys > total->sys + tolerances
|| phase_wall > total->wall + tolerancew
|| phase_ggc_mem > total->ggc_mem * tolerance)
Where toleranceu, etc. should be defined as:
tolerancew = total->user * (tolerance - 1);
toleranceu = total->user * (tolerance - 1);
tolerances = total->sys * (tolerance - 1);
#ifdef USE_TIMES
if (tolerancew < ticks_to_msec)
tolerancew = ticks_to_msec;
if (toleranceu < ticks_to_msec)
toleranceu = ticks_to_msec;
if (tolerances < ticks_to_msec)
tolerances = ticks_to_msec;
#endif
#ifdef USE_GETRUSAGE
toleranceu = total->user * (tolerance - 1);
tolerances = total->sys * (tolerance - 1);
#endif
#ifdef USE_CLOCK
if (toleranceu < clocks_to_msec)
toleranceu = clocks_to_msec;
#endif
The reasoning is the tolerance should be at min a tick.
next prev parent reply other threads:[~2023-06-20 6:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 0:21 [Bug testsuite/110316] New: [14 regression] " seurer at gcc dot gnu.org
2023-06-20 6:58 ` pinskia at gcc dot gnu.org [this message]
2023-07-07 10:45 ` [Bug middle-end/110316] [11/12/13/14 Regression] " rguenth at gcc dot gnu.org
2023-07-21 17:47 ` pinskia at gcc dot gnu.org
2023-08-04 10:29 ` cvs-commit at gcc dot gnu.org
2024-02-21 7:12 ` pinskia at gcc dot gnu.org
2024-03-20 19:50 ` seurer at gcc dot gnu.org
2024-03-20 20:32 ` pinskia at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-110316-4-Ta0KSG7x4v@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).