[Bug bootstrap/110324] New: [14 Regression][bootstrap, nvptx] build/genpreds: Internal error: RTL check: expected elt 2 type 'T', have 's' due to r14-1949-g957ae904065917

[Bug bootstrap/110324] New: [14 Regression][bootstrap, nvptx] build/genpreds: Internal error: RTL check: expected elt 2 type 'T', have 's' due to r14-1949-g957ae904065917

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110324

            Bug ID: 110324
           Summary: [14 Regression][bootstrap, nvptx] build/genpreds:
                    Internal error: RTL check: expected elt 2 type 'T',
                    have 's' due to r14-1949-g957ae904065917
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Keywords: build
          Severity: normal
          Priority: P3
         Component: bootstrap
          Assignee: unassigned at gcc dot gnu.org
          Reporter: burnus at gcc dot gnu.org
                CC: tnfchris at gcc dot gnu.org
  Target Milestone: ---
            Target: nvptx-none

Since r14-1949-g957ae90406591739b68e95ad49a0232faeb74217
  New compact syntax for insn and insn_split in Machine Descriptions.

The nvptx bootstrap fails with:

build/genpreds -c src/gcc-mainline/gcc/common.md
src/gcc-mainline/gcc/config/nvptx/nvptx.md > tmp-constrs.h
build/genpreds: Internal error: RTL check: expected elt 2 type 'T', have 's'
(rtx define_cond_exec) in convert_syntax, at gensupport.cc:883
genconditions: Internal error: RTL check: expected elt 2 type 'T', have 's'
(rtx define_cond_exec) in convert_syntax, at gensupport.cc:883

build/genpreds src/gcc-mainline/gcc/common.md
src/gcc-mainline/gcc/config/nvptx/nvptx.md > tmp-preds.cc
build/genpreds: Internal error: Makefile:2625: recipe for target 's-preds-h'
failed
RTL check: expected elt 2 type 'T', have 's' (rtx define_cond_exec) in
convert_syntax, at gensupport.cc:883

[Bug bootstrap/110324] [14 Regression][bootstrap, nvptx] build/genpreds: Internal error: RTL check: expected elt 2 type 'T', have 's' due to r14-1949-g957ae904065917

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110324

--- Comment #1 from Tobias Burnus <burnus at gcc dot gnu.org> ---
In the debugger for 'convert_syntax', it fails immediately. The caller is:

1055        case DEFINE_COND_EXEC:
1056          convert_syntax (desc, loc);

(gdb) p debug_rtx(desc)
(define_cond_exec [
        (match_operator 0 ("predicate_operator")
             [
                (match_operand:BI 1 ("nvptx_register_operand") (""))
                (match_operand:BI 2 ("const0_operand") (""))
            ])
    ] ("") ("")
     [])

the check output is:

build/genpreds: Internal error: RTL check: expected elt 2 type 'T', have 's'
(rtx define_cond_exec) in convert_syntax, at gensupport.cc:883

which internally is:

  templ_index = GET_CODE (x) == DEFINE_INSN ? 3 : 2;
  templ = XTMPL (x, templ_index);

The first one gives '2' and then:

#define XTMPL(RTX, N)   (RTL_CHECK1 (RTX, N, 'T').rt_str)

and the error string is:

751  ("RTL check: expected elt %d type '%c', have '%c' (rtx %s) in %s, at
%s:%d",
752   n, c1, GET_RTX_FORMAT (GET_CODE (r))[n], GET_RTX_NAME (GET_CODE (r)),

* * *

#define RTL_CHECK1(RTX, N, C1) __extension__                            \
(*({ __typeof (RTX) const _rtx = (RTX); const int _n = (N);             \
     const enum rtx_code _code = GET_CODE (_rtx);                       \
     if (_n < 0 || _n >= GET_RTX_LENGTH (_code))                        \
       rtl_check_failed_bounds (_rtx, _n, __FILE__, __LINE__,           \
                                __FUNCTION__);                          \
     if (GET_RTX_FORMAT (_code)[_n] != C1)                              \
       rtl_check_failed_type1 (_rtx, _n, C1, __FILE__, __LINE__,        \
                               __FUNCTION__);                           \
     &_rtx->u.fld[_n]; }))

[Bug bootstrap/110324] [14 Regression][bootstrap, nvptx] build/genpreds: Internal error: RTL check: expected elt 2 type 'T', have 's' due to r14-1949-g957ae904065917

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110324

--- Comment #2 from Tobias Burnus <burnus at gcc dot gnu.org> ---
BTW, regarding:  type 'T', have 's'

/* Indexed by rtx code, gives a sequence of operand-types for
   rtx's of that code.  The sequence is a C string in which
   each character describes one operand.  */

const char * const rtx_format[NUM_RTX_CODE] = {
...
     "s" a pointer to a string
         prints the string
...
     "T" like "s", but treated specially by the RTL reader;
         only found in machine description patterns.
...
#define DEF_RTL_EXPR(ENUM, NAME, FORMAT, CLASS)   FORMAT ,
#include "rtl.def"              /* rtl expressions are defined here */
#undef DEF_RTL_EXPR
};

[Bug bootstrap/110324] [14 Regression][bootstrap, nvptx] build/genpreds: Internal error: RTL check: expected elt 2 type 'T', have 's' due to r14-1949-g957ae904065917

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110324

--- Comment #3 from Tobias Burnus <burnus at gcc dot gnu.org> ---
(gdb) p ((enum rtx_code) (x)->code)
$3 = DEFINE_COND_EXEC
(gdb) p (int)((enum rtx_code) (x)->code)
$4 = 172

and hence:

(gdb) p rtx_format[172]
$6 = 0x4bcda0 "EssV"


where we take the index 2 => 's'.

The EssV matches the rtl.def entry:

   DEF_RTL_EXPR(DEFINE_COND_EXEC, "define_cond_exec", "EssV", RTX_EXTRA)

Actually, grepping for 'T' I only find:

 "define_insn", "sEsTV"
 "define_peephole", "EsTV"
 "define_insn_and_split", "sEsTsESV"
 "define_insn_and_rewrite", "sEsTsSV"

[Bug bootstrap/110324] [14 Regression][build][nvptx] build/genpreds: Internal error: RTL check: expected elt 2 type 'T', have 's' due to r14-1949-g957ae904065917

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110324

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[14 Regression][bootstrap,  |[14
                   |nvptx] build/genpreds:      |Regression][build][nvptx]
                   |Internal error: RTL check:  |build/genpreds: Internal
                   |expected elt 2 type 'T',    |error: RTL check: expected
                   |have 's' due to             |elt 2 type 'T', have 's'
                   |r14-1949-g957ae904065917    |due to
                   |                            |r14-1949-g957ae904065917

--- Comment #4 from Tobias Burnus <burnus at gcc dot gnu.org> ---
The commit r14-1949-g957ae90406591739b68e95ad49a0232faeb74217 did change
in  gcc/gensupport.cc the following.

@@ -553,10 +1048,12 @@ process_rtx (rtx desc, file_location loc)
   switch (GET_CODE (desc))
     {
     case DEFINE_INSN:
+      convert_syntax (desc, loc);
       queue_pattern (desc, &define_insn_tail, loc);
       break;

     case DEFINE_COND_EXEC:
+      convert_syntax (desc, loc);
       queue_pattern (desc, &define_cond_exec_tail, loc);
       break;


IMHO it seems as if there shouldn't be a convert_syntax for
DEFINE_COND_EXEC - or 's' needs to be accepted for it
or rtl.def needs to be change to have a 'T' and not an 's'.

[Bug bootstrap/110324] [14 Regression][build][nvptx] build/genpreds: Internal error: RTL check: expected elt 2 type 'T', have 's' due to r14-1949-g957ae904065917

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110324

--- Comment #5 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Patch by Tamar (thanks!):

https://gcc.gnu.org/pipermail/gcc-patches/2023-June/622387.html

[Bug bootstrap/110324] [14 Regression][build][nvptx] build/genpreds: Internal error: RTL check: expected elt 2 type 'T', have 's' due to r14-1949-g957ae904065917

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110324

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tamar Christina <tnfchris@gcc.gnu.org>:

https://gcc.gnu.org/g:f5d0cec170d6d5496edf4038499d288c07d79b18

commit r14-2005-gf5d0cec170d6d5496edf4038499d288c07d79b18
Author: Tamar Christina <tamar.christina@arm.com>
Date:   Tue Jun 20 23:31:40 2023 +0100

    gensupport: drop suppport for define_cond_exec from compact syntac

    define_cond_exec does not support the special @@ syntax
    and so can't support {@.  As such just remove support
    for it.

    gcc/ChangeLog:

            PR bootstrap/110324
            * gensupport.cc (convert_syntax): Explicitly check for RTX code.

[Bug bootstrap/110324] [14 Regression][build][nvptx] build/genpreds: Internal error: RTL check: expected elt 2 type 'T', have 's' due to r14-1949-g957ae904065917

[tnfchris at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110324

Tamar Christina <tnfchris at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Tamar Christina <tnfchris at gcc dot gnu.org> ---
Fixed, thanks for the report.