[Bug tree-optimization/110332] New: [14 regression] ICE in dominated_by_p when building LLVM with -O3

[Bug tree-optimization/110332] New: [14 regression] ICE in dominated_by_p when building LLVM with -O3

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110332

            Bug ID: 110332
           Summary: [14 regression] ICE in dominated_by_p when building
                    LLVM with -O3
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: sjames at gcc dot gnu.org
  Target Milestone: ---

Created attachment 55377
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=55377&action=edit
SplitKit.ii.xz

```
# /usr/bin/aarch64-unknown-linux-gnu-g++ -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS
-D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS
-I/var/tmp/portage/sys-devel/llvm-16.0.6/work/llvm_build-.arm64/lib/CodeGen
-I/var/tmp/portage/sys-devel/llvm-16.0.6/work/llvm/lib/CodeGen
-I/var/tmp/portage/sys-devel/llvm-16.0.6/work/llvm_build-.arm64/include
-I/var/tmp/portage/sys-devel/llvm-16.0.6/work/llvm/include  -DNDEBUG -O3 -pipe
-mcpu=native -fdiagnostics-color=always -fPIC -fno-semantic-interposition
-fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra
-Wno-unused-parameter -Wwrite-strings -Wcast-qual
-Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough
-Wno-maybe-uninitialized -Wno-class-memaccess -Wno-redundant-move
-Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor
-Wsuggest-override -Wno-comment -Wno-misleading-indentation
-Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections
-fdata-sections -std=c++17 -fdiagnostics-color=always -c
/var/tmp/portage/sys-devel/llvm-16.0.6/work/llvm/lib/CodeGen/SplitKit.cpp
-save-temps
aarch64-unknown-linux-gnu-g++: warning: ‘-pipe’ ignored because ‘-save-temps’
specified
during GIMPLE pass: phiprop
/var/tmp/portage/sys-devel/llvm-16.0.6/work/llvm/lib/CodeGen/SplitKit.cpp: In
member function ‘bool llvm::SplitEditor::transferValues()’:
/var/tmp/portage/sys-devel/llvm-16.0.6/work/llvm/lib/CodeGen/SplitKit.cpp:1888:1:
internal compiler error: Segmentation fault
 1888 | }
      | ^
0xaaaab5e4625f crash_signal
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/toplev.cc:314
0xaaaab58a4ec8 dominated_by_p(cdi_direction, basic_block_def const*,
basic_block_def const*)
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/dominance.cc:1128
0xaaaab603cd8f propagate_with_phi
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/tree-ssa-phiprop.cc:408
0xaaaab603cd8f execute
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/tree-ssa-phiprop.cc:528
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://bugs.gentoo.org/> for instructions.
```

```
gcc (Gentoo 14.0.0 p, commit 6cb33e2f39e289ec4f25f845d8153053147c5c49) 14.0.0
20230620 (experimental) f5d0cec170d6d5496edf4038499d288c07d79b18
Copyright (C) 2023 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
```

[Bug tree-optimization/110332] [14 regression] ICE in dominated_by_p when building LLVM with -O3

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110332

--- Comment #1 from Sam James <sjames at gcc dot gnu.org> ---
g++ -O3 -c ... is enough to repro

[Bug tree-optimization/110332] [14 regression] ICE in dominated_by_p when building LLVM with -O3

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110332

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu.org
   Target Milestone|---                         |14.0
           Keywords|                            |ice-on-valid-code

[Bug tree-optimization/110332] [14 regression] ICE in dominated_by_p when building LLVM with -O3

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110332

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Either r14-1981 or r14-1951

[Bug tree-optimization/110332] [14 regression] ICE in dominated_by_p when building LLVM with -O3

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110332

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Reducing ...

[Bug tree-optimization/110332] [14 regression] ICE in dominated_by_p when building LLVM with -O3

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110332

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
possibly edge insertions with virtual operands confuse the machinery

[Bug tree-optimization/110332] [14 regression] ICE in dominated_by_p when building LLVM with -O3

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110332

--- Comment #5 from Sam James <sjames at gcc dot gnu.org> ---
Created attachment 55379
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=55379&action=edit
reduced.ii

[Bug tree-optimization/110332] [14 regression] ICE in dominated_by_p when building LLVM with -O3

[slyfox at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110332

Sergei Trofimovich <slyfox at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slyfox at gcc dot gnu.org

--- Comment #6 from Sergei Trofimovich <slyfox at gcc dot gnu.org> ---
I think I see the same ICE on llvm-12 and r14-2009-g864c6471bdc6cd:

cvise produced this thing:

// $ cat a.cpp.cpp
struct SlotIndex { int lie; };
SlotIndex si7, si8;

unsigned u9, u6;
bool b3, b4;
unsigned &value() {
  return b4 ? u6 : u9;
}
void transferValues() {
  unsigned RegIdx;
  SlotIndex End;
  RegIdx = value();
  End = b3 ? si7 : si8;
}

$ g++ -O3  -c a.cpp.cpp -o a.o
during GIMPLE pass: phiprop
a.cpp.cpp: In function 'void transferValues()':
a.cpp.cpp:14:1: internal compiler error: Segmentation fault
   14 | }
      | ^
0x1d74824 diagnostic_impl(rich_location*, diagnostic_metadata const*, int, char
const*, __va_list_tag (*) [1], diagnostic_t)
        ???:0
0x1d74d97 internal_error(char const*, ...)
        ???:0
0xe9bfdf crash_signal(int)
        ???:0
0xa851da dominated_by_p(cdi_direction, basic_block_def const*, basic_block_def
const*)
        ???:0
0x102096b (anonymous namespace)::pass_phiprop::execute(function*)
        ???:0

$ g++  -v
Using built-in specs.
COLLECT_GCC=/<<NIX>>/gcc-14.0.0/bin/g++
COLLECT_LTO_WRAPPER=/<<NIX>>/gcc-14.0.0/libexec/gcc/x86_64-unknown-linux-gnu/14.0.0/lto-wrapper
Target: x86_64-unknown-linux-gnu
Configured with: 
Thread model: posix
Supported LTO compression algorithms: zlib
gcc version 14.0.0 99999999 (experimental) (GCC)

[Bug tree-optimization/110332] [14 regression] ICE in dominated_by_p when building LLVM with -O3

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110332

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2023-06-21

--- Comment #7 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Reduced C testcase:
```
struct s { int lie; };
struct s si7, si8;
unsigned u9, u6;
_Bool b3, b4;
unsigned transferValues(struct s *End) {
  unsigned RegIdx;
  unsigned *t = b4 ? &u6 : &u9;
  RegIdx = *t;
  *End = *(b3 ? &si7 : &si8);
  return RegIdx;
}
```

[Bug tree-optimization/110332] [14 regression] ICE in dominated_by_p when building LLVM with -O3

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110332

--- Comment #8 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #7)
Another one reduced C testcase, very similar to the previous one but slightly
more reduced:
```
_Bool a;
struct s { int t; } c, d;
unsigned e, f;
unsigned transferValues(struct s *End) {
  unsigned RegIdx = *(a ? &e : &f);
  *End = *(a ? &c : &d);
  return RegIdx;
}
```

[Bug tree-optimization/110332] [14 regression] ICE in dominated_by_p when building LLVM with -O3

[slyfox at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110332

--- Comment #9 from Sergei Trofimovich <slyfox at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #2)
> Either r14-1981 or r14-1951

Reverting r14-1981-g85107abeb71bbf restores llvm-12 build for me.

[Bug tree-optimization/110332] [14 regression] ICE in dominated_by_p when building LLVM with -O3

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110332

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org

--- Comment #10 from Richard Biener <rguenth at gcc dot gnu.org> ---
Mine.

[Bug tree-optimization/110332] [14 regression] ICE in dominated_by_p when building LLVM with -O3

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110332

--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:2ac41866270e9fbab504bbda7a942a97abaa203a

commit r14-2031-g2ac41866270e9fbab504bbda7a942a97abaa203a
Author: Richard Biener <rguenther@suse.de>
Date:   Thu Jun 22 09:04:01 2023 +0200

    tree-optimization/110332 - fix ICE with phiprop

    The following fixes an ICE that occurs when we visit an edge
    inserted load from the code validating correctness for inserting
    an aggregate copy there.  We can simply skip those loads here.

            PR tree-optimization/110332
            * tree-ssa-phiprop.cc (propagate_with_phi): Always
            check aliasing with edge inserted loads.

            * g++.dg/torture/pr110332.C: New testcase.
            * gcc.dg/torture/pr110332-1.c: Likewise.
            * gcc.dg/torture/pr110332-2.c: Likewise.

[Bug tree-optimization/110332] [14 regression] ICE in dominated_by_p when building LLVM with -O3

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110332

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #12 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.

[Bug tree-optimization/110332] [14 regression] ICE in dominated_by_p when building LLVM with -O3

[slyfox at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110332

--- Comment #13 from Sergei Trofimovich <slyfox at gcc dot gnu.org> ---
The fix fixes llvm-12 build for me. Thank you!