[Bug rtl-optimization/110390] New: ICE on valid code on x86_64-linux-gnu with sel-scheduling: in av_set_could_be_blocked_by_bookkeeping_p, at sel-sched.cc:3609

[Bug rtl-optimization/110390] New: ICE on valid code on x86_64-linux-gnu with sel-scheduling: in av_set_could_be_blocked_by_bookkeeping_p, at sel-sched.cc:3609

[zhendong.su at inf dot ethz.ch]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110390

            Bug ID: 110390
           Summary: ICE on valid code on x86_64-linux-gnu with
                    sel-scheduling: in
                    av_set_could_be_blocked_by_bookkeeping_p, at
                    sel-sched.cc:3609
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: rtl-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: zhendong.su at inf dot ethz.ch
  Target Milestone: ---

It appears to be a regression from 12.*, and affects 13.* and later.

Compiler Explorer: https://godbolt.org/z/Gd15nnhrv

[571] % gcctk -v
Using built-in specs.
COLLECT_GCC=gcctk
COLLECT_LTO_WRAPPER=/local/home/suz/suz-local/software/local/gcc-trunk/bin/../libexec/gcc/x86_64-pc-linux-gnu/14.0.0/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: ../gcc-trunk/configure --disable-bootstrap
--enable-checking=yes --prefix=/local/suz-local/software/local/gcc-trunk
--enable-sanitizers --enable-languages=c,c++ --disable-werror
--disable-multilib
Thread model: posix
Supported LTO compression algorithms: zlib
gcc version 14.0.0 20230623 (experimental) [master r14-924-gd709841ae0f] (GCC)
[572] %
[572] % gcctk -O2 -fno-tree-dce -fsel-sched-pipelining -fno-dce -fno-tree-ter
-fno-gcse -fno-ssa-phiopt -fno-tree-dse -fno-if-conversion -fno-thread-jumps
-fselective-scheduling2 -fno-guess-branch-probability small.c
during RTL pass: sched2
small.c: In function ‘main’:
small.c:23:1: internal compiler error: in
av_set_could_be_blocked_by_bookkeeping_p, at sel-sched.cc:3609
   23 | }
      | ^
0x7d6356 av_set_could_be_blocked_by_bookkeeping_p
        ../../gcc-trunk/gcc/sel-sched.cc:3609
0x7d6356 code_motion_process_successors
        ../../gcc-trunk/gcc/sel-sched.cc:6386
0x7d6356 code_motion_path_driver
        ../../gcc-trunk/gcc/sel-sched.cc:6608
0xf857a9 code_motion_process_successors
        ../../gcc-trunk/gcc/sel-sched.cc:6342
0xf857a9 code_motion_path_driver
        ../../gcc-trunk/gcc/sel-sched.cc:6608
0xf857a9 code_motion_process_successors
        ../../gcc-trunk/gcc/sel-sched.cc:6342
0xf857a9 code_motion_path_driver
        ../../gcc-trunk/gcc/sel-sched.cc:6608
0xf86858 find_used_regs
        ../../gcc-trunk/gcc/sel-sched.cc:3272
0xf86858 collect_unavailable_regs_from_bnds
        ../../gcc-trunk/gcc/sel-sched.cc:1586
0xf86858 find_best_reg_for_expr
        ../../gcc-trunk/gcc/sel-sched.cc:1649
0xf893ac fill_vec_av_set
        ../../gcc-trunk/gcc/sel-sched.cc:3784
0xf893ac fill_ready_list
        ../../gcc-trunk/gcc/sel-sched.cc:4014
0xf893ac find_best_expr
        ../../gcc-trunk/gcc/sel-sched.cc:4374
0xf893ac fill_insns
        ../../gcc-trunk/gcc/sel-sched.cc:5535
0xf893ac schedule_on_fences
        ../../gcc-trunk/gcc/sel-sched.cc:7353
0xf893ac sel_sched_region_2
        ../../gcc-trunk/gcc/sel-sched.cc:7491
0xf8a568 sel_sched_region_1
        ../../gcc-trunk/gcc/sel-sched.cc:7533
0xf8bb86 sel_sched_region(int)
        ../../gcc-trunk/gcc/sel-sched.cc:7634
0xf8bb86 sel_sched_region(int)
        ../../gcc-trunk/gcc/sel-sched.cc:7619
0xf8bd29 run_selective_scheduling()
        ../../gcc-trunk/gcc/sel-sched.cc:7720
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.
[573] %
[573] % cat small.c
int a, b, c, d, e, f;
extern void k();
int main() {
  int h = 6, i;
j:
  if (b)
    h = 0;
  if (c) {
    k();
    goto l;
  }
  int m = i = 0;
  for (; i < 2; i++)
    ;
  long n = a;
l:
  d = ~m || n ^ (a & f);
  m = f;
  f = ~(n && h | e) && a;
  if (h && a)
    goto j;
  return 0;
}

[Bug rtl-optimization/110390] ICE on valid code on x86_64-linux-gnu with sel-scheduling: in av_set_could_be_blocked_by_bookkeeping_p, at sel-sched.cc:3609

[zhendong.su at inf dot ethz.ch]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110390

--- Comment #1 from Zhendong Su <zhendong.su at inf dot ethz.ch> ---
Another reproducer with fewer flags (and affects 12.* and later).

Compiler Explorer: https://godbolt.org/z/fYqEz9EWx

[603] % gcctk -v
Using built-in specs.
COLLECT_GCC=gcctk
COLLECT_LTO_WRAPPER=/local/home/suz/suz-local/software/local/gcc-trunk/bin/../libexec/gcc/x86_64-pc-linux-gnu/14.0.0/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: ../gcc-trunk/configure --disable-bootstrap
--enable-checking=yes --prefix=/local/suz-local/software/local/gcc-trunk
--enable-sanitizers --enable-languages=c,c++ --disable-werror
--disable-multilib
Thread model: posix
Supported LTO compression algorithms: zlib
gcc version 14.0.0 20230624 (experimental) [master r14-924-gd709841ae0f] (GCC)
[604] %
[604] % gcctk -O3 -fsel-sched-pipelining -fschedule-insns
-fselective-scheduling2 -fPIC small.c
during RTL pass: sched2
small.c: In function ‘h’:
small.c:20:1: internal compiler error: in
av_set_could_be_blocked_by_bookkeeping_p, at sel-sched.cc:3609
   20 | }
      | ^
0x7d635a av_set_could_be_blocked_by_bookkeeping_p
        ../../gcc-trunk/gcc/sel-sched.cc:3609
0x7d635a code_motion_process_successors
        ../../gcc-trunk/gcc/sel-sched.cc:6386
0x7d635a code_motion_path_driver
        ../../gcc-trunk/gcc/sel-sched.cc:6608
0xf85b69 code_motion_process_successors
        ../../gcc-trunk/gcc/sel-sched.cc:6342
0xf85b69 code_motion_path_driver
        ../../gcc-trunk/gcc/sel-sched.cc:6608
0xf86c18 find_used_regs
        ../../gcc-trunk/gcc/sel-sched.cc:3272
0xf86c18 collect_unavailable_regs_from_bnds
        ../../gcc-trunk/gcc/sel-sched.cc:1586
0xf86c18 find_best_reg_for_expr
        ../../gcc-trunk/gcc/sel-sched.cc:1649
0xf8976c fill_vec_av_set
        ../../gcc-trunk/gcc/sel-sched.cc:3784
0xf8976c fill_ready_list
        ../../gcc-trunk/gcc/sel-sched.cc:4014
0xf8976c find_best_expr
        ../../gcc-trunk/gcc/sel-sched.cc:4374
0xf8976c fill_insns
        ../../gcc-trunk/gcc/sel-sched.cc:5535
0xf8976c schedule_on_fences
        ../../gcc-trunk/gcc/sel-sched.cc:7353
0xf8976c sel_sched_region_2
        ../../gcc-trunk/gcc/sel-sched.cc:7491
0xf8a928 sel_sched_region_1
        ../../gcc-trunk/gcc/sel-sched.cc:7533
0xf8bf46 sel_sched_region(int)
        ../../gcc-trunk/gcc/sel-sched.cc:7634
0xf8bf46 sel_sched_region(int)
        ../../gcc-trunk/gcc/sel-sched.cc:7619
0xf8c0e9 run_selective_scheduling()
        ../../gcc-trunk/gcc/sel-sched.cc:7720
0xf6d7ed rest_of_handle_sched2
        ../../gcc-trunk/gcc/sched-rgn.cc:3743
0xf6d7ed execute
        ../../gcc-trunk/gcc/sched-rgn.cc:3890
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.
[605] %
[605] % cat small.c
static int a;
int b, c, d, g;
long e, f;
extern void l(char *);
void h() {
  char i;
  int j = 1 >> f / b;
 L:
  f = -(-(f % g || a) * (c && f | e));
  if (a > e)
    l("");
  if (f) {
    l("A");
    i = j / g;
  }
  if (a)
    goto L;
  d = i;
  a = 0;
}

[Bug rtl-optimization/110390] ICE on valid code on x86_64-linux-gnu with sel-scheduling: in av_set_could_be_blocked_by_bookkeeping_p, at sel-sched.cc:3609

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110390

Thomas Koenig <tkoenig at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tkoenig at gcc dot gnu.org

--- Comment #2 from Thomas Koenig <tkoenig at gcc dot gnu.org> ---
Seems to be fixed on current trunk as of r14-5226-g0b94e9cc060906.

[Bug rtl-optimization/110390] ICE on valid code on x86_64-linux-gnu with sel-scheduling: in av_set_could_be_blocked_by_bookkeeping_p, at sel-sched.cc:3609

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110390

--- Comment #3 from Thomas Koenig <tkoenig at gcc dot gnu.org> ---
Fixed by r14-3414-g0cfc9c953d0221:

0cfc9c953d0221ec3971a25e6509ebe1041f142e is the first new commit
commit 0cfc9c953d0221ec3971a25e6509ebe1041f142e
Author: Andrew MacLeod <amacleod@redhat.com>
Date:   Thu Aug 17 12:34:59 2023 -0400

    Phi analyzer - Initialize with range instead of a tree.

    Rangers PHI analyzer currently only allows a single initializer to a group.
    This patch changes that to use an inialization range, which is
    cumulative of all integer constants, plus a single symbolic value.
    There is no other change to group functionality.

    This patch also changes the way PHI groups are printed so they show up in
the
    listing as they are encountered, rather than as a list at the end.  It
    was more difficult to see what was going on previously.

[Bug rtl-optimization/110390] ICE on valid code on x86_64-linux-gnu with sel-scheduling: in av_set_could_be_blocked_by_bookkeeping_p, at sel-sched.cc:3609

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110390

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Thomas Koenig from comment #3)
> Fixed by r14-3414-g0cfc9c953d0221:

That almost definitely just made the issue go latent.

[Bug rtl-optimization/110390] ICE on valid code on x86_64-linux-gnu with sel-scheduling: in av_set_could_be_blocked_by_bookkeeping_p, at sel-sched.cc:3609 since r13-3596-ge7310e24b1c0ca

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110390

Thomas Koenig <tkoenig at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://gcc.gnu.org/bugzill
                   |                            |a/show_bug.cgi?id=110390#
            Summary|ICE on valid code on        |ICE on valid code on
                   |x86_64-linux-gnu with       |x86_64-linux-gnu with
                   |sel-scheduling: in          |sel-scheduling: in
                   |av_set_could_be_blocked_by_ |av_set_could_be_blocked_by_
                   |bookkeeping_p, at           |bookkeeping_p, at
                   |sel-sched.cc:3609           |sel-sched.cc:3609 since
                   |                            |r13-3596-ge7310e24b1c0ca
                 CC|                            |amacleod at redhat dot com
           Keywords|needs-bisection             |

--- Comment #5 from Thomas Koenig <tkoenig at gcc dot gnu.org> ---
Bisects to r13-3596-ge7310e24b1c0ca.

No idea if this just exposed a latent bug, or introduced it.

e7310e24b1c0ca67b1bb507c1330b2bf39e59e32 is the first bad commit
commit e7310e24b1c0ca67b1bb507c1330b2bf39e59e32
Author: Andrew MacLeod <amacleod@redhat.com>
Date:   Tue Oct 25 16:42:41 2022 -0400

    Make ranger vrp1 default.

    Turn on ranger as the default vrp1 pass and adjust testcases.

            gcc/
            * params.opt (param_vrp1_mode): Make ranger default.

            gcc/testsuite/
            * gcc.dg/pr68217.c: Test [-INF, -INF][0, 0] instead of [-INF, 0].
            * gcc.dg/tree-ssa/vrp-unreachable.c: New.  Test unreachable
removal.

 gcc/params.opt                                  |  2 +-
 gcc/testsuite/gcc.dg/pr68217.c                  |  2 +-
 gcc/testsuite/gcc.dg/tree-ssa/vrp-unreachable.c | 42 +++++++++++++++++++++++++
 3 files changed, 44 insertions(+), 2 deletions(-)
 create mode 100644 gcc/testsuite/gcc.dg/tree-ssa/vrp-unreachable.c

[Bug rtl-optimization/110390] ICE on valid code on x86_64-linux-gnu with sel-scheduling: in av_set_could_be_blocked_by_bookkeeping_p, at sel-sched.cc:3609 since r13-3596-ge7310e24b1c0ca

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110390

--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Thomas Koenig from comment #5)
> Bisects to r13-3596-ge7310e24b1c0ca.
> 
> No idea if this just exposed a latent bug, or introduced it.

That almost definitely exposed it. 

Maybe someone could make a gimple testcase which exposes the bug such that it
is independent of the gimple level optimizations. Or even a RTL testcase ...

[Bug rtl-optimization/110390] [13/14 regression] ICE on valid code on x86_64-linux-gnu with sel-scheduling: in av_set_could_be_blocked_by_bookkeeping_p, at sel-sched.cc:3609 since r13-3596-ge7310e24b1c0ca

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110390

Sam James <sjames at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |needs-reduction
            Summary|ICE on valid code on        |[13/14 regression] ICE on
                   |x86_64-linux-gnu with       |valid code on
                   |sel-scheduling: in          |x86_64-linux-gnu with
                   |av_set_could_be_blocked_by_ |sel-scheduling: in
                   |bookkeeping_p, at           |av_set_could_be_blocked_by_
                   |sel-sched.cc:3609 since     |bookkeeping_p, at
                   |r13-3596-ge7310e24b1c0ca    |sel-sched.cc:3609 since
                   |                            |r13-3596-ge7310e24b1c0ca
                URL|https://gcc.gnu.org/bugzill |
                   |a/show_bug.cgi?id=110390#   |

--- Comment #7 from Sam James <sjames at gcc dot gnu.org> ---
I'll add 'needs-reduction' given pinskia's comment.

[Bug rtl-optimization/110390] [13/14 regression] ICE on valid code on x86_64-linux-gnu with sel-scheduling: in av_set_could_be_blocked_by_bookkeeping_p, at sel-sched.cc:3609 since r13-3596-ge7310e24b1c0ca

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110390

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.3

[Bug rtl-optimization/110390] [13/14 regression] ICE on valid code on x86_64-linux-gnu with sel-scheduling: in av_set_could_be_blocked_by_bookkeeping_p, at sel-sched.cc:3609 since r13-3596-ge7310e24b1c0ca

[law at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110390

Jeffrey A. Law <law at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |law at gcc dot gnu.org
           Priority|P3                          |P4

[Bug rtl-optimization/110390] [13/14/15 regression] ICE on valid code on x86_64-linux-gnu with sel-scheduling: in av_set_could_be_blocked_by_bookkeeping_p, at sel-sched.cc:3609 since r13-3596-ge7310e24b1c0ca

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110390

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|13.3                        |13.4

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 13.3 is being released, retargeting bugs to GCC 13.4.