public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/110406] d: Wrong code-gen returning POD structs by value Date: Wed, 28 Jun 2023 18:52:55 +0000 [thread overview] Message-ID: <bug-110406-4-xb72KYQLXK@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-110406-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110406 --- Comment #15 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The releases/gcc-13 branch has been updated by Iain Buclaw <ibuclaw@gcc.gnu.org>: https://gcc.gnu.org/g:f2eeda5652438fe783d4e3878139481a1b8606b6 commit r13-7496-gf2eeda5652438fe783d4e3878139481a1b8606b6 Author: Iain Buclaw <ibuclaw@gdcproject.org> Date: Wed Jun 28 18:30:31 2023 +0200 d: Fix wrong code-gen when returning structs by value. Since r13-1104, structs have have compute_record_mode called too early on them, causing them to return differently depending on the order that types are generated in, and whether there are forward references. This patch moves the call to compute_record_mode into its own function, and calls it after all fields have been given a size. PR d/106977 PR target/110406 gcc/d/ChangeLog: * types.cc (finish_aggregate_mode): New function. (finish_incomplete_fields): Call finish_aggregate_mode. (finish_aggregate_type): Replace call to compute_record_mode with finish_aggregate_mode. gcc/testsuite/ChangeLog: * gdc.dg/torture/pr110406.d: New test. (cherry picked from commit c201cd3be0d9ab887fafb0c33a9fc287c405c21c)
next prev parent reply other threads:[~2023-06-28 18:52 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-06-26 2:25 [Bug d/110406] New: " ibuclaw at gcc dot gnu.org 2023-06-26 2:33 ` [Bug d/110406] " pinskia at gcc dot gnu.org 2023-06-26 2:44 ` [Bug target/110406] " pinskia at gcc dot gnu.org 2023-06-26 3:06 ` ibuclaw at gcc dot gnu.org 2023-06-26 3:10 ` ibuclaw at gcc dot gnu.org 2023-06-26 4:21 ` pinskia at gcc dot gnu.org 2023-06-26 4:28 ` pinskia at gcc dot gnu.org 2023-06-26 4:32 ` pinskia at gcc dot gnu.org 2023-06-26 9:37 ` ibuclaw at gcc dot gnu.org 2023-06-26 9:38 ` ibuclaw at gcc dot gnu.org 2023-06-26 20:55 ` ibuclaw at gcc dot gnu.org 2023-06-27 8:52 ` iains at gcc dot gnu.org 2023-06-27 9:27 ` iains at gcc dot gnu.org 2023-06-28 16:33 ` ibuclaw at gcc dot gnu.org 2023-06-28 18:19 ` cvs-commit at gcc dot gnu.org 2023-06-28 18:52 ` cvs-commit at gcc dot gnu.org [this message] 2023-06-28 18:55 ` ibuclaw at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-110406-4-xb72KYQLXK@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).