public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "dje at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug testsuite/110419] [14 regression] new test case gfortran.dg/value_9.f90 in r14-2050-gd130ae8499e0c6 fails Date: Tue, 18 Jul 2023 20:09:54 +0000 [thread overview] Message-ID: <bug-110419-4-DaQlkMUIS8@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-110419-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110419 David Edelsohn <dje at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |dje at gcc dot gnu.org Last reconfirmed| |2023-07-18 Ever confirmed|0 |1 --- Comment #16 from David Edelsohn <dje at gcc dot gnu.org> --- As I wrote in issue 110360, the bug appears to be the memory layout and padding assumed by GFortran that does not take into account endianness. I have changed val() to print both c and x, and not halt. subroutine val (x, c) character(kind=1), intent(in) :: x ! control: pass by reference character(kind=1), value :: c print *, "by value(kind=1): ", x print *, "by value(kind=1): ", c ! if (c /= x) stop 1 c = "*" if (c /= "*") stop 2 end The output is: by value(kind=1): B by value(kind=1): B by value(kind=1): A by value(kind=1): A by value(kind=1): A by value(kind=1): <- c by value(kind=1): A by value(kind=1): <- c by value(kind=1): A by value(kind=1): <- c by value(kind=1): 1 by value(kind=1): <- c by value(kind=1): 1 by value(kind=1): <- c The assembly language for the first few calls is # call val ("B","B") lwz 31,LC..5(2) LOAD ADDRESS of x mr 3,31 COPY address to first parameter li 6,1 li 5,1 lbzu 4,148(3) LOAD BYTE of c as second parameter slwi 4,4,24 SHIFT c 24 bits bl .val.4 # call val ("A",char(65)) mr 30,31 COPY ADDRESS of x li 6,1 li 5,1 lbzu 4,152(30) LOAD BYTE of c as second parameter slwi 4,4,24 SHIFT c 24 bits mr 3,30 COPY address of first parameter bl .val.4 # call val ("A",char(a)) li 6,1 li 5,1 li 4,65 <- c NOT SHIFTED mr 3,30 <- x bl .val.4 # call val ("A",mychar(65)) li 6,1 li 5,1 li 4,65 <- c NOT SHIFTED mr 3,30 <- x bl .val.4 # call val ("A",mychar(a)) li 6,1 li 5,1 li 4,65 <- c NOT SHIFTED mr 3,30 <- x bl .val.4 GFortran is not taking account of endianness for the layout of values in memory compared to constants loaded into registers. This isn't an ABI issue of the target, this is a memory layout and register layout issue of GFortran. On a big endian system, a character / byte is loaded at the LSB, but GFortran seems to be comparing it to a memory image with the character / byte stored at the MSB, which would be correct for little endian. In some cases, GFortran is shifting the value and in other cases it is not. GFortran does not seem to have a consistent view of the memory layout for characters / bytes loaded into a larger object.
next prev parent reply other threads:[~2023-07-18 20:09 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-06-26 21:28 [Bug other/110419] New: " seurer at gcc dot gnu.org 2023-06-27 8:52 ` [Bug testsuite/110419] " rguenth at gcc dot gnu.org 2023-06-29 7:04 ` mikael at gcc dot gnu.org 2023-06-29 7:12 ` mikael at gcc dot gnu.org 2023-06-29 15:41 ` seurer at gcc dot gnu.org 2023-06-29 17:39 ` anlauf at gcc dot gnu.org 2023-07-02 19:19 ` anlauf at gcc dot gnu.org 2023-07-05 13:31 ` mikael at gcc dot gnu.org 2023-07-05 13:45 ` mikael at gcc dot gnu.org 2023-07-05 13:46 ` mikael at gcc dot gnu.org 2023-07-05 13:47 ` mikael at gcc dot gnu.org 2023-07-05 13:54 ` mikael at gcc dot gnu.org 2023-07-06 8:32 ` mikael at gcc dot gnu.org 2023-07-06 8:33 ` mikael at gcc dot gnu.org 2023-07-06 8:34 ` mikael at gcc dot gnu.org 2023-07-06 8:38 ` mikael at gcc dot gnu.org 2023-07-15 10:35 ` mikael at gcc dot gnu.org 2023-07-18 20:09 ` dje at gcc dot gnu.org [this message] 2023-07-30 19:50 ` mikael at gcc dot gnu.org 2023-07-31 14:58 ` mikael at gcc dot gnu.org 2023-08-10 7:40 ` mikael at gcc dot gnu.org 2023-08-14 20:11 ` cvs-commit at gcc dot gnu.org 2023-08-15 9:17 ` mikael at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-110419-4-DaQlkMUIS8@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).