public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug testsuite/110419] [14 regression] new test case gfortran.dg/value_9.f90 in r14-2050-gd130ae8499e0c6 fails Date: Mon, 14 Aug 2023 20:11:29 +0000 [thread overview] Message-ID: <bug-110419-4-JYPAUpxuit@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-110419-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110419 --- Comment #20 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Mikael Morin <mikael@gcc.gnu.org>: https://gcc.gnu.org/g:564b637f4a32883cbf3c3019d3cfcf0b0aec9b82 commit r14-3207-g564b637f4a32883cbf3c3019d3cfcf0b0aec9b82 Author: Mikael Morin <mikael@gcc.gnu.org> Date: Mon Aug 14 21:51:54 2023 +0200 fortran: Fix length one character dummy arg type [PR110419] Revision r14-2171-g8736d6b14a4dfdfb58c80ccd398981b0fb5d00aa changed the argument passing convention for length 1 value dummy arguments to pass just the single character by value. However, the procedure declarations weren't updated to reflect the change in the argument types. This change does the missing argument type update. The change of argument types generated an internal error in gfc_conv_string_parameter with value_9.f90. Indeed, that function is not prepared for bare character type, so it is updated as well. The condition guarding the single character argument passing code is loosened to not exclude non-interoperable kind (this fixes a regression with c_char_tests_2.f03). Finally, the constant string argument passing code is updated as well to extract the single char and pass it instead of passing it as a length one string. As the code taking care of non-constant arguments was already doing this, the condition guarding it is just removed. With these changes, value_9.f90 passes on 32 bits big-endian powerpc. PR fortran/110360 PR fortran/110419 gcc/fortran/ChangeLog: * trans-types.cc (gfc_sym_type): Use a bare character type for length one value character dummy arguments. * trans-expr.cc (gfc_conv_string_parameter): Handle single character case. (gfc_conv_procedure_call): Don't exclude interoperable kinds from single character handling. For single character dummy arguments, extend the existing handling of non-constant expressions to constant expressions. gcc/testsuite/ChangeLog: * gfortran.dg/bind_c_usage_13.f03: Update tree dump patterns.
next prev parent reply other threads:[~2023-08-14 20:11 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-06-26 21:28 [Bug other/110419] New: " seurer at gcc dot gnu.org 2023-06-27 8:52 ` [Bug testsuite/110419] " rguenth at gcc dot gnu.org 2023-06-29 7:04 ` mikael at gcc dot gnu.org 2023-06-29 7:12 ` mikael at gcc dot gnu.org 2023-06-29 15:41 ` seurer at gcc dot gnu.org 2023-06-29 17:39 ` anlauf at gcc dot gnu.org 2023-07-02 19:19 ` anlauf at gcc dot gnu.org 2023-07-05 13:31 ` mikael at gcc dot gnu.org 2023-07-05 13:45 ` mikael at gcc dot gnu.org 2023-07-05 13:46 ` mikael at gcc dot gnu.org 2023-07-05 13:47 ` mikael at gcc dot gnu.org 2023-07-05 13:54 ` mikael at gcc dot gnu.org 2023-07-06 8:32 ` mikael at gcc dot gnu.org 2023-07-06 8:33 ` mikael at gcc dot gnu.org 2023-07-06 8:34 ` mikael at gcc dot gnu.org 2023-07-06 8:38 ` mikael at gcc dot gnu.org 2023-07-15 10:35 ` mikael at gcc dot gnu.org 2023-07-18 20:09 ` dje at gcc dot gnu.org 2023-07-30 19:50 ` mikael at gcc dot gnu.org 2023-07-31 14:58 ` mikael at gcc dot gnu.org 2023-08-10 7:40 ` mikael at gcc dot gnu.org 2023-08-14 20:11 ` cvs-commit at gcc dot gnu.org [this message] 2023-08-15 9:17 ` mikael at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-110419-4-JYPAUpxuit@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).