[Bug libstdc++/110504] New: std::format("{:%S}", duration<long, std::ratio<1,2>>(4)) returns "02.0" instead of "02"

[Bug libstdc++/110504] New: std::format("{:%S}", duration<long, std::ratio<1,2>>(4)) returns "02.0" instead of "02"

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110504

            Bug ID: 110504
           Summary: std::format("{:%S}", duration<long,
                    std::ratio<1,2>>(4)) returns "02.0" instead of "02"
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: redi at gcc dot gnu.org
  Target Milestone: ---

And std::format("{:%M:%S}", duration<long, std::ratio<2, 3>>(99)) returns
"01:06.000000" instead of "01:06"

[Bug libstdc++/110504] std::format("{:%S}", duration<long, std::ratio<1,2>>(4)) returns "02.0" instead of "02"

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110504

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2023-06-30
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |redi at gcc dot gnu.org

[Bug libstdc++/110504] std::format("{:%S}", duration<long, std::ratio<1,2>>(4)) returns "02.0" instead of "02"

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110504

--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
I have a patch to fix this:

--- a/libstdc++-v3/include/bits/chrono_io.h
+++ b/libstdc++-v3/include/bits/chrono_io.h
@@ -1079,7 +1079,9 @@ namespace __format
            {
              locale __loc = _M_locale(__ctx);
              auto __ss = __hms.subseconds();
-             if constexpr (is_floating_point_v<rep>)
+             if (__ss == __ss.zero())
+               ; // Do not write all-zero fractional part.
+             else if constexpr (is_floating_point_v<rep>)
                {
                  __out = std::format_to(__loc, std::move(__out),
                                         _GLIBCXX_WIDEN("{:.{}Lg}"),


However the example in [time.clock.utc.nonmembers] suggests that in fact
printing the zeros is correct. The sys_time<milliseconds> value is printed as
"2015-06-30 23:59:60.000 UTC" which would be altered by the patch above.

[Bug libstdc++/110504] std::format("{:%S}", duration<long, std::ratio<1,2>>(4)) returns "02.0" instead of "02"

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110504

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |INVALID

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
The current code in libstdc++ is correct here.