public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "avieira at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/110557] [13/14 Regression] Wrong code for x86_64-linux-gnu with -O3 -mavx2: vectorized loop mishandles signed bit-fields Date: Thu, 06 Jul 2023 14:58:23 +0000 [thread overview] Message-ID: <bug-110557-4-Ias8dB7kRg@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-110557-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110557 --- Comment #5 from avieira at gcc dot gnu.org --- Hi Xi, Feel free to test your patch and submit it to the list for review. I had a look over and it looks correct to me. I feel like it also addresses the cases where the bitfield is 'sandwiched' like: int x : 7; ptrdiff_t y : 56; long long z: 1; As you left-shift it, and it also addresses the case where you have both sign-extension and have to widen-it, because you still transform the type into signed. But it might be nice to add tests to cover those two, just in case someone changes this. In the future, if you do plan to work on something it would be nice to let people know on the bugzilla ticket (preferably by assigning it to yourself) so that multiple people don't end up working on the same thing, I had started to write a patch, but wasn't as far as you and I like your approach :)
next prev parent reply other threads:[~2023-07-06 14:58 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-07-05 11:10 [Bug target/110557] New: " xry111 at gcc dot gnu.org 2023-07-05 11:11 ` [Bug target/110557] [13/14 Regression] " xry111 at gcc dot gnu.org 2023-07-05 13:15 ` [Bug tree-optimization/110557] " pinskia at gcc dot gnu.org 2023-07-06 8:17 ` rguenth at gcc dot gnu.org 2023-07-06 10:17 ` avieira at gcc dot gnu.org 2023-07-06 10:21 ` xry111 at gcc dot gnu.org 2023-07-06 11:30 ` xry111 at gcc dot gnu.org 2023-07-06 14:58 ` avieira at gcc dot gnu.org [this message] 2023-07-06 16:18 ` xry111 at gcc dot gnu.org 2023-07-06 16:32 ` xry111 at gcc dot gnu.org 2023-07-10 10:36 ` cvs-commit at gcc dot gnu.org 2023-07-10 10:36 ` cvs-commit at gcc dot gnu.org 2023-07-10 10:38 ` xry111 at gcc dot gnu.org 2023-07-11 8:16 ` xry111 at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-110557-4-Ias8dB7kRg@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).