public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "xry111 at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/110557] [13/14 Regression] Wrong code for x86_64-linux-gnu with -O3 -mavx2: vectorized loop mishandles signed bit-fields
Date: Thu, 06 Jul 2023 16:32:03 +0000 [thread overview]
Message-ID: <bug-110557-4-QQYS7ca5r5@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-110557-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110557
--- Comment #6 from Xi Ruoyao <xry111 at gcc dot gnu.org> ---
(In reply to avieira from comment #5)
> Hi Xi,
>
> Feel free to test your patch and submit it to the list for review. I had a
> look over and it looks correct to me.
https://gcc.gnu.org/pipermail/gcc-patches/2023-July/623782.html
The changes from the version posted here:
1. Add a test case (I already made it sandwiched because a very first, not
posted version of the patch failed with sandwiched cases).
2. Slightly adjusted the comment.
There is another issue: if mask_width + shift_n == prec, we should omit the
AND_EXPR even for unsigned bit-field. For example
movq $-256, %rax
vmovq %rax, %xmm1
vpunpcklqdq %xmm1, %xmm1, %xmm1
vpand (%rcx,%rdi,8), %xmm1, %xmm1
vpsrlq $8, %xmm1, %xmm1
can be just
vmovdqu (%rcx,%rdi,8), %xmm1
vpsrlq $8, %xmm1, %xmm1
But it's a different issue so we can fix it in a different patch.
next prev parent reply other threads:[~2023-07-06 16:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 11:10 [Bug target/110557] New: " xry111 at gcc dot gnu.org
2023-07-05 11:11 ` [Bug target/110557] [13/14 Regression] " xry111 at gcc dot gnu.org
2023-07-05 13:15 ` [Bug tree-optimization/110557] " pinskia at gcc dot gnu.org
2023-07-06 8:17 ` rguenth at gcc dot gnu.org
2023-07-06 10:17 ` avieira at gcc dot gnu.org
2023-07-06 10:21 ` xry111 at gcc dot gnu.org
2023-07-06 11:30 ` xry111 at gcc dot gnu.org
2023-07-06 14:58 ` avieira at gcc dot gnu.org
2023-07-06 16:18 ` xry111 at gcc dot gnu.org
2023-07-06 16:32 ` xry111 at gcc dot gnu.org [this message]
2023-07-10 10:36 ` cvs-commit at gcc dot gnu.org
2023-07-10 10:36 ` cvs-commit at gcc dot gnu.org
2023-07-10 10:38 ` xry111 at gcc dot gnu.org
2023-07-11 8:16 ` xry111 at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-110557-4-QQYS7ca5r5@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).