[Bug driver/110607] New: Makefile.in build broken build-tools when CXXFLAGS is defined

[Bug driver/110607] New: Makefile.in build broken build-tools when CXXFLAGS is defined

[sagebar at web dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110607

            Bug ID: 110607
           Summary: Makefile.in build broken build-tools when CXXFLAGS is
                    defined
           Product: gcc
           Version: 12.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: driver
          Assignee: unassigned at gcc dot gnu.org
          Reporter: sagebar at web dot de
  Target Milestone: ---

This part in the main makefile:

> 177 # These variables must be set on the make command line for directories
> 178 # built for the build system to override those in BASE_FLAGS_TO_PASS.
> 179 EXTRA_BUILD_FLAGS = \
> 180         CFLAGS="$(CFLAGS_FOR_BUILD)" \
> 181         LDFLAGS="$(LDFLAGS_FOR_BUILD)"

Should instead be:

> 177 # These variables must be set on the make command line for directories
> 178 # built for the build system to override those in BASE_FLAGS_TO_PASS.
> 179 EXTRA_BUILD_FLAGS = \
> 180         CFLAGS="$(CFLAGS_FOR_BUILD)" \
> 181         CXXFLAGS="$(CXXFLAGS_FOR_BUILD)" \
> 182         LDFLAGS="$(LDFLAGS_FOR_BUILD)"

Since some components of the build system are compiled as c++, if one wants to
define custom CXX-flags in cross-compilation situations, these flags then also
get used when building build-tools (which causes breakage)

[Bug bootstrap/110607] Makefile.in builds broken build-tools when CXXFLAGS is defined

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110607

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2023-07-09
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---


Looks like this has been posted a few times.


Feb this year:
https://inbox.sourceware.org/gcc-patches/20230222123411.419584-1-Yash.Shinde@windriver.com/

September last year:
https://gcc.gnu.org/pipermail/gcc-patches/2022-September/601344.html
With an approval in November:
https://gcc.gnu.org/pipermail/gcc-patches/2022-November/606922.html

[Bug bootstrap/110607] Makefile.in builds broken build-tools when CXXFLAGS is defined

[sagebar at web dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110607

--- Comment #2 from sagebar at web dot de ---
@Andrew Pinski

Sorry if this is a known bug. I simply checked the current gcc master
(https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=Makefile.tpl;h=d0fe7e2fb778b3c3fa2cc8742e06cf1f78fdc5f2;hb=HEAD#l183),
which is still affected. I was not aware that a fix was already pending but not
yet merged.