[Bug plugins/110610] New: File insn-opinit.h not installed ?

[Bug plugins/110610] New: File insn-opinit.h not installed ?

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110610

            Bug ID: 110610
           Summary: File insn-opinit.h not installed ?
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: plugins
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dcb314 at hotmail dot com
  Target Milestone: ---

Recent linux kernels seem to think that file insn-opinit.h is available
in a gcc install.

  CC      /home/dcb38/linuxKernel/linux-6.4/tools/objtool/arch/x86/special.o
In file included from scripts/gcc-plugins/gcc-common.h:73,
                 from scripts/gcc-plugins/stackleak_plugin.c:30:
/home/dcb38/gcc/results.20230701.valgrind/lib/gcc/x86_64-pc-linux-gnu/14.0.0/plugin/include/internal-fn.h:24:10:
fatal error: insn-opinit.h: No such file or directory
   24 | #include "insn-opinit.h"
      |          ^~~~~~~~~~~~~~~

I found a straightforward copy of the file from a gcc build made the problem
go away:

$ history | grep insn | grep cp
 1019  cp /home/dcb38/gcc/working/gcc/insn-opinit.h
/home/dcb38/gcc/results.20230708.asan.ubsan/lib/gcc/x86_64-pc-linux-gnu/14.0.0/plugin/include/
 1022  history | grep insn | grep cp
$ 

I am pretty sure there is a better way than a "cp" command to solve this
problem.
Perhaps the install could do the copy instead ?

[Bug plugins/110610] File insn-opinit.h not installed ?

[xry111 at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110610

Xi Ruoyao <xry111 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |xry111 at gcc dot gnu.org

--- Comment #1 from Xi Ruoyao <xry111 at gcc dot gnu.org> ---
(In reply to David Binderman from comment #0)
> Recent linux kernels seem to think that file insn-opinit.h is available
> in a gcc install.

Not really "recent linux kernels", it has been use GCC plugins for a long time
(but you can disable it in the configuration).  And it seems r14-1551 has added
#include "insn-opinit.h" into internal-fn.h but did not installed
insn-opinit.h.

[Bug plugins/110610] File insn-opinit.h not installed ?

[avieira at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110610

avieira at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |avieira at gcc dot gnu.org

--- Comment #2 from avieira at gcc dot gnu.org ---
I can't reproduce this but it seems like the modula2 build also suffers from
the same issue, see PR110284.

David, what exactly are you trying to build? Can you give us the configure
command?

[Bug plugins/110610] File insn-opinit.h not installed ?

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110610

--- Comment #3 from David Binderman <dcb314 at hotmail dot com> ---
(In reply to avieira from comment #2)
> I can't reproduce this but it seems like the modula2 build also suffers from
> the same issue, see PR110284.
> 
> David, what exactly are you trying to build? Can you give us the configure
> command?

Perhaps I haven't given enough clues. 

I was trying to build linux-6.4 & yesterday's linux-6.5-rc1 with recent gcc
trunk 
dated 20230701 & 20230708.

Configure lines are

make distclean
make allyesconfig
make

[Bug plugins/110610] File insn-opinit.h not installed ?

[xry111 at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110610

--- Comment #4 from Xi Ruoyao <xry111 at gcc dot gnu.org> ---
(In reply to avieira from comment #2)
> I can't reproduce this but it seems like the modula2 build also suffers from
> the same issue, see PR110284.
> 
> David, what exactly are you trying to build? Can you give us the configure
> command?

The OP is building a GCC plugin, it includes internal-fn.h.  But internal-fn.h
includes insn-opinit.h, and insn-opinit.h is not installed.

See
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/scripts/gcc-plugins/gcc-common.h#n73

[Bug plugins/110610] File insn-opinit.h not installed ?

[avieira at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110610

--- Comment #5 from avieira at gcc dot gnu.org ---
intenral-fn.h is generated at gcc build-time. I'm not sure we want to 'install'
it with a gcc install. Might make more sense to trigger a the generation of it
when building this gcc-plugin. But I'm not sure... I'll ask around the
community see what people think.

[Bug plugins/110610] File insn-opinit.h not installed ?

[xry111 at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110610

--- Comment #6 from Xi Ruoyao <xry111 at gcc dot gnu.org> ---
(In reply to avieira from comment #5)
> intenral-fn.h is generated at gcc build-time.

I guess you mean insn-opinit.h, not internal-fn.h.  internal-fn.h is in the GCC
Git repo.

> I'm not sure we want to
> 'install' it with a gcc install.

We are already installing insn-{addr,attr-common,attr,codes,...}.h anyway.

[Bug plugins/110610] File insn-opinit.h not installed ?

[avieira at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110610

--- Comment #7 from avieira at gcc dot gnu.org ---
> I guess you mean insn-opinit.h, not internal-fn.h.  internal-fn.h is in the GCC Git repo.

Yeah sorry! I did mean insn-opinit.h

> We are already installing insn-{addr,attr-common,attr,codes,...}.h anyway.

Fair!

[Bug plugins/110610] File insn-opinit.h not installed ?

[avieira at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110610

--- Comment #8 from avieira at gcc dot gnu.org ---
I'll try adding to one of the header file lists in gcc's makefile. Probably the
INTERNAL_FN_H one.

[Bug plugins/110610] File insn-opinit.h not installed ?

[avieira at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110610

avieira at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2023-07-10
     Ever confirmed|0                           |1
           Assignee|unassigned at gcc dot gnu.org      |avieira at gcc dot gnu.org
             Status|UNCONFIRMED                 |ASSIGNED

[Bug plugins/110610] File insn-opinit.h not installed ?

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110610

--- Comment #9 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
I am shocked that optabs.h is not included for PLUGIN_HEADERS ....

[Bug plugins/110610] [14 Regression] File insn-opinit.h not installed ?

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110610

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |14.0

[Bug plugins/110610] [14 Regression] File insn-opinit.h not installed ?

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110610

--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Andre Simoes Dias Vieira
<avieira@gcc.gnu.org>:

https://gcc.gnu.org/g:caabf0973a4e9a26421c94d540e3e20051e93e77

commit r14-2585-gcaabf0973a4e9a26421c94d540e3e20051e93e77
Author: Andre Vieira <andre.simoesdiasvieira@arm.com>
Date:   Mon Jul 17 17:00:54 2023 +0100

    Include insn-opinit.h in PLUGIN_H [PR110610]

    This patch fixes PR110610 by including insn-opinit.h in the INTERNAL_FN_H
list,
    as insn-opinit.h is now required by internal-fn.h. This will lead to
    insn-opinit.h being installed in the plugin directory.

    gcc/ChangeLog:

            PR plugins/110610
            * Makefile.in (INTERNAL_FN_H): Add insn-opinit.h.

[Bug plugins/110610] [14 Regression] File insn-opinit.h not installed ?

[avieira at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110610

avieira at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #11 from avieira at gcc dot gnu.org ---
This should fix it. David please reopen if the problem still persists.